Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler-v2] feature gating for semantic change of _ to Move 2.1 #15199

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Nov 5, 2024

Description

Feature gating for #14962 from Move 2.0 to Move 2.1

How Has This Been Tested?

Existing tests

Key Areas to Review

Check whether all places are covered: #14962

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 5, 2024

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rahxephon89 and the rest of your teammates on Graphite Graphite

@rahxephon89 rahxephon89 changed the title change feature gating for _ to 2.1 [Compiler-v2] change feature gating for _ to 2.1 Nov 5, 2024
@rahxephon89 rahxephon89 changed the title [Compiler-v2] change feature gating for _ to 2.1 [Compiler-v2] fea gating for _ to Move 2.1 Nov 5, 2024
@rahxephon89 rahxephon89 changed the title [Compiler-v2] fea gating for _ to Move 2.1 [Compiler-v2] feature gating for _ to Move 2.1 Nov 5, 2024
@rahxephon89 rahxephon89 changed the title [Compiler-v2] feature gating for _ to Move 2.1 [Compiler-v2] feature gating for semantic change of _ to Move 2.1 Nov 5, 2024
@rahxephon89 rahxephon89 marked this pull request as ready for review November 5, 2024 23:08
@rahxephon89 rahxephon89 enabled auto-merge (squash) November 5, 2024 23:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Forge suite realistic_env_max_load success on 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e

two traffics test: inner traffic : committed: 14490.25 txn/s, latency: 2743.09 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 5509520
two traffics test : committed: 100.03 txn/s, latency: 1646.68 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 9700 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.010, avg: 1.549", "ConsensusProposalToOrdered: max: 0.320, avg: 0.293", "ConsensusOrderedToCommit: max: 0.365, avg: 0.354", "ConsensusProposalToCommit: max: 0.657, avg: 0.646"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.92s no progress at version 2606409 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.55s no progress at version 2606407 (avg 8.55s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Forge suite framework_upgrade success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e (PR)
Upgrade the nodes to version: 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1237.75 txn/s, submitted: 1240.81 txn/s, failed submission: 3.06 txn/s, expired: 3.06 txn/s, latency: 2497.42 ms, (p50: 2300 ms, p70: 2700, p90: 4200 ms, p99: 5700 ms), latency samples: 113120
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1207.39 txn/s, submitted: 1210.08 txn/s, failed submission: 2.68 txn/s, expired: 2.68 txn/s, latency: 2472.66 ms, (p50: 2400 ms, p70: 2700, p90: 3800 ms, p99: 5500 ms), latency samples: 108100
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e passed
Upgrade the remaining nodes to version: 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1301.21 txn/s, submitted: 1304.72 txn/s, failed submission: 3.52 txn/s, expired: 3.52 txn/s, latency: 2284.60 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4500 ms), latency samples: 118440
Test Ok

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 14881.55 txn/s, latency: 2295.10 ms, (p50: 1900 ms, p70: 2100, p90: 2200 ms, p99: 7300 ms), latency samples: 544100
2. Upgrading first Validator to new version: 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6959.40 txn/s, latency: 4000.20 ms, (p50: 4500 ms, p70: 4700, p90: 5000 ms, p99: 5100 ms), latency samples: 128480
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6982.79 txn/s, latency: 4605.62 ms, (p50: 5000 ms, p70: 5100, p90: 6200 ms, p99: 6500 ms), latency samples: 233540
3. Upgrading rest of first batch to new version: 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6261.79 txn/s, latency: 4539.49 ms, (p50: 4900 ms, p70: 5200, p90: 6200 ms, p99: 6400 ms), latency samples: 125420
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6138.68 txn/s, latency: 5255.28 ms, (p50: 5700 ms, p70: 5800, p90: 7000 ms, p99: 7300 ms), latency samples: 208020
4. upgrading second batch to new version: 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8251.46 txn/s, latency: 3304.51 ms, (p50: 3600 ms, p70: 4100, p90: 4400 ms, p99: 4700 ms), latency samples: 152060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7506.46 txn/s, latency: 4228.62 ms, (p50: 4500 ms, p70: 4800, p90: 5400 ms, p99: 6400 ms), latency samples: 250940
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 74f8b4dbde414cfe1ce9d672bee7c702abe06d0e passed
Test Ok

@rahxephon89 rahxephon89 merged commit 9a29c98 into main Nov 5, 2024
82 of 92 checks passed
@rahxephon89 rahxephon89 deleted the teng/fix-gating-underscore branch November 5, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants