Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK support for prover and pepper use with keyless #15191

Merged
merged 11 commits into from
Nov 7, 2024

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Nov 5, 2024

Description

This adds the ability to derive keyless accounts in rust. It supports the fetching of the pepper and proof given a JWT and an associated EphemeralKeyPair

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 5, 2024

⏱️ 4h 31m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 13m 🟩🟩🟩
test-target-determinator 18m 🟩🟩🟩🟩
rust-cargo-deny 16m 🟩🟩🟩🟩🟥 (+5 more)
check-dynamic-deps 16m 🟩🟩🟩🟩🟩 (+7 more)
execution-performance / test-target-determinator 14m 🟩🟩🟩
check 11m 🟩🟩🟩
rust-images / rust-all 11m 🟥🟥🟥🟥🟥 (+2 more)
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
fetch-last-released-docker-image-tag 7m 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 24m 18m +36%

settingsfeedbackdocs ⋅ learn more about trunk.io

@heliuchuan heliuchuan marked this pull request as ready for review November 5, 2024 11:02
Copy link
Contributor

@alinush alinush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the hardcoded JWT!

@heliuchuan heliuchuan enabled auto-merge (squash) November 7, 2024 01:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Forge suite realistic_env_max_load success on 0d701b1daf4c370d4082318102b2cf1fe556ee56

two traffics test: inner traffic : committed: 14279.04 txn/s, latency: 2783.04 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5429220
two traffics test : committed: 100.04 txn/s, latency: 1521.39 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 6700 ms), latency samples: 1840
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.053, avg: 1.631", "ConsensusProposalToOrdered: max: 0.329, avg: 0.296", "ConsensusOrderedToCommit: max: 0.374, avg: 0.361", "ConsensusProposalToCommit: max: 0.668, avg: 0.657"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 34677 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.41s no progress at version 2478140 (avg 8.41s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Forge suite framework_upgrade success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0d701b1daf4c370d4082318102b2cf1fe556ee56

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0d701b1daf4c370d4082318102b2cf1fe556ee56 (PR)
Upgrade the nodes to version: 0d701b1daf4c370d4082318102b2cf1fe556ee56
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1306.99 txn/s, submitted: 1309.47 txn/s, failed submission: 2.48 txn/s, expired: 2.48 txn/s, latency: 2345.54 ms, (p50: 2100 ms, p70: 2500, p90: 3600 ms, p99: 5400 ms), latency samples: 115820
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1232.13 txn/s, submitted: 1235.05 txn/s, failed submission: 2.91 txn/s, expired: 2.91 txn/s, latency: 2526.64 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 6000 ms), latency samples: 109940
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0d701b1daf4c370d4082318102b2cf1fe556ee56 passed
Upgrade the remaining nodes to version: 0d701b1daf4c370d4082318102b2cf1fe556ee56
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1258.15 txn/s, submitted: 1260.16 txn/s, failed submission: 2.01 txn/s, expired: 2.01 txn/s, latency: 2396.08 ms, (p50: 2100 ms, p70: 2700, p90: 3600 ms, p99: 5200 ms), latency samples: 112660
Test Ok

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0d701b1daf4c370d4082318102b2cf1fe556ee56

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0d701b1daf4c370d4082318102b2cf1fe556ee56 (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 14266.71 txn/s, latency: 2347.51 ms, (p50: 1900 ms, p70: 2100, p90: 2700 ms, p99: 8400 ms), latency samples: 493160
2. Upgrading first Validator to new version: 0d701b1daf4c370d4082318102b2cf1fe556ee56
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6468.08 txn/s, latency: 4424.31 ms, (p50: 4900 ms, p70: 5300, p90: 5400 ms, p99: 5500 ms), latency samples: 124780
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6641.40 txn/s, latency: 4902.76 ms, (p50: 5300 ms, p70: 5500, p90: 6200 ms, p99: 6700 ms), latency samples: 227600
3. Upgrading rest of first batch to new version: 0d701b1daf4c370d4082318102b2cf1fe556ee56
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6254.98 txn/s, latency: 4355.94 ms, (p50: 4900 ms, p70: 5100, p90: 5200 ms, p99: 5500 ms), latency samples: 125940
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6727.94 txn/s, latency: 4822.50 ms, (p50: 5100 ms, p70: 5300, p90: 6400 ms, p99: 7000 ms), latency samples: 233180
4. upgrading second batch to new version: 0d701b1daf4c370d4082318102b2cf1fe556ee56
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9510.42 txn/s, latency: 2960.82 ms, (p50: 3300 ms, p70: 3500, p90: 3600 ms, p99: 3900 ms), latency samples: 164140
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9559.63 txn/s, latency: 3346.27 ms, (p50: 3400 ms, p70: 3600, p90: 4800 ms, p99: 5200 ms), latency samples: 316940
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0d701b1daf4c370d4082318102b2cf1fe556ee56 passed
Test Ok

@heliuchuan heliuchuan merged commit c2489a6 into main Nov 7, 2024
47 of 48 checks passed
@heliuchuan heliuchuan deleted the add-sdk-for-keyless branch November 7, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants