Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optqs][co] Implement optQS payload validation in CO #15188

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[optqs][co] Implement optQS payload validation in CO #15188

merged 1 commit into from
Nov 6, 2024

Conversation

ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Nov 5, 2024 •
edited
Loading

Description

Fixes verification of OptQuorumStore payloads in Consensus Observer.

Test Plan

Verified with test run

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 5, 2024 •
edited
Loading

⏱️ 2h 16m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 8m 🟩 🟥 🟩 
rust-cargo-deny 9m 🟩 🟩 🟩 🟩 🟩 
execution-performance / test-target-determinator 9m 🟩 🟩 
test-target-determinator 9m 🟩 🟩 
check 7m 🟩 🟩 
check-dynamic-deps 6m 🟩 🟩 🟩 🟩 🟩 
rust-doc-tests 5m 🟩 
rust-doc-tests 5m 🟩 
fetch-last-released-docker-image-tag 3m 🟩 🟩 
general-lints 2m 🟩 🟩 🟩 🟩 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun force-pushed the balaji/optqs-co branch 2 times, most recently from 012832f to 45de7dc Compare November 5, 2024 19:02
@ibalajiarun ibalajiarun requested a review from JoshLind November 5, 2024 19:31
@ibalajiarun ibalajiarun marked this pull request as ready for review November 5, 2024 19:31
JoshLind
JoshLind approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@JoshLind JoshLind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Thanks @ibalajiarun 😄

consensus/src/consensus_observer/network/observer_message.rs
@@ -1185,6 +1332,11 @@ mod test {
// Create multiple signed transactions
let num_signed_transactions = 10;
let mut signed_transactions = create_signed_transactions(num_signed_transactions);
let signed_transactions_for_optqs: Vec<_> = signed_transactions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, I forgot how long this test was 😄

@ibalajiarun ibalajiarun enabled auto-merge (squash) November 5, 2024 22:41
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite realistic_env_max_load success on b918339bd7786d4b016caa96212761daad7d539f

two traffics test: inner traffic : committed: 14411.29 txn/s, latency: 2756.90 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5479520
two traffics test : committed: 99.93 txn/s, latency: 1623.51 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 10500 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.023, avg: 1.571", "ConsensusProposalToOrdered: max: 0.315, avg: 0.292", "ConsensusOrderedToCommit: max: 0.369, avg: 0.359", "ConsensusProposalToCommit: max: 0.660, avg: 0.651"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.96s no progress at version 2359278 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.66s no progress at version 2359276 (avg 8.66s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite framework_upgrade success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b918339bd7786d4b016caa96212761daad7d539f

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b918339bd7786d4b016caa96212761daad7d539f (PR)
Upgrade the nodes to version: b918339bd7786d4b016caa96212761daad7d539f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1436.62 txn/s, submitted: 1440.16 txn/s, failed submission: 3.54 txn/s, expired: 3.54 txn/s, latency: 2138.49 ms, (p50: 2100 ms, p70: 2300, p90: 3100 ms, p99: 4000 ms), latency samples: 129960
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1407.20 txn/s, submitted: 1411.46 txn/s, failed submission: 4.25 txn/s, expired: 4.25 txn/s, latency: 2130.63 ms, (p50: 2100 ms, p70: 2100, p90: 3300 ms, p99: 4800 ms), latency samples: 125780
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b918339bd7786d4b016caa96212761daad7d539f passed
Upgrade the remaining nodes to version: b918339bd7786d4b016caa96212761daad7d539f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1374.81 txn/s, submitted: 1377.66 txn/s, failed submission: 2.84 txn/s, expired: 2.84 txn/s, latency: 2133.65 ms, (p50: 2100 ms, p70: 2100, p90: 3000 ms, p99: 4600 ms), latency samples: 125680
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b918339bd7786d4b016caa96212761daad7d539f

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b918339bd7786d4b016caa96212761daad7d539f (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 16965.72 txn/s, latency: 1995.62 ms, (p50: 2000 ms, p70: 2100, p90: 2200 ms, p99: 3100 ms), latency samples: 540720
2. Upgrading first Validator to new version: b918339bd7786d4b016caa96212761daad7d539f
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5984.81 txn/s, latency: 4724.70 ms, (p50: 5300 ms, p70: 5700, p90: 5900 ms, p99: 6100 ms), latency samples: 113180
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6144.70 txn/s, latency: 5273.95 ms, (p50: 5700 ms, p70: 5800, p90: 6900 ms, p99: 7100 ms), latency samples: 206360
3. Upgrading rest of first batch to new version: b918339bd7786d4b016caa96212761daad7d539f
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6745.91 txn/s, latency: 4298.81 ms, (p50: 4900 ms, p70: 5200, p90: 5300 ms, p99: 5300 ms), latency samples: 124960
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6779.21 txn/s, latency: 4743.05 ms, (p50: 5300 ms, p70: 5400, p90: 5600 ms, p99: 5900 ms), latency samples: 228060
4. upgrading second batch to new version: b918339bd7786d4b016caa96212761daad7d539f
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8460.48 txn/s, latency: 3421.53 ms, (p50: 3800 ms, p70: 4000, p90: 4400 ms, p99: 4500 ms), latency samples: 152640
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7622.91 txn/s, latency: 4248.31 ms, (p50: 4100 ms, p70: 4700, p90: 6100 ms, p99: 6500 ms), latency samples: 259840
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b918339bd7786d4b016caa96212761daad7d539f passed
Test Ok

@ibalajiarun ibalajiarun merged commit 8b472e7 into main Nov 6, 2024
45 of 48 checks passed
@ibalajiarun ibalajiarun deleted the balaji/optqs-co branch November 6, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekun000 zekun000 zekun000 approved these changes

@JoshLind JoshLind JoshLind approved these changes

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibalajiarun @JoshLind @zekun000