Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the ecosysystem-infra team as the proto owner. #15180

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Nov 4, 2024

Description

Make ecosystem-infra the owner of protos. This can make sure the changes can be handled correctly downstream.

How Has This Been Tested?

n/a

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 4, 2024

⏱️ 1h 9m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 25m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-doc-tests 5m 🟩
rust-cargo-deny 4m 🟩🟩
check 4m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 3m 🟩
check-dynamic-deps 2m 🟩🟩
fetch-last-released-docker-image-tag 1m 🟩
general-lints 55s 🟩🟩
semgrep/ci 47s 🟩🟩
file_change_determinator 23s 🟩🟩
file_change_determinator 11s 🟩
permission-check 9s 🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 25m 16m +60%
execution-performance / test-target-determinator 4m 5m -22%
test-target-determinator 3m 4m -24%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @larry-aptos and the rest of your teammates on Graphite Graphite

@larry-aptos larry-aptos marked this pull request as ready for review November 4, 2024 20:58
@larry-aptos larry-aptos requested a review from a team November 4, 2024 21:43
@larry-aptos larry-aptos enabled auto-merge (squash) November 6, 2024 01:39

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite realistic_env_max_load success on 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710

two traffics test: inner traffic : committed: 14316.99 txn/s, latency: 2776.35 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5444880
two traffics test : committed: 100.08 txn/s, latency: 1453.04 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 7300 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.005, avg: 1.590", "ConsensusProposalToOrdered: max: 0.317, avg: 0.293", "ConsensusOrderedToCommit: max: 0.377, avg: 0.364", "ConsensusProposalToCommit: max: 0.668, avg: 0.658"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.09s no progress at version 2839799 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.50s no progress at version 2839797 (avg 8.50s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite framework_upgrade success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710 (PR)
Upgrade the nodes to version: 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1338.88 txn/s, submitted: 1342.68 txn/s, failed submission: 3.79 txn/s, expired: 3.79 txn/s, latency: 2314.10 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5100 ms), latency samples: 120060
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1311.98 txn/s, submitted: 1314.63 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2258.10 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 5100 ms), latency samples: 119260
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710 passed
Upgrade the remaining nodes to version: 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1335.91 txn/s, submitted: 1338.36 txn/s, failed submission: 2.45 txn/s, expired: 2.45 txn/s, latency: 2312.37 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4300 ms), latency samples: 119740
Test Ok

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710 (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 13880.14 txn/s, latency: 2076.10 ms, (p50: 1700 ms, p70: 1900, p90: 2300 ms, p99: 14800 ms), latency samples: 548460
2. Upgrading first Validator to new version: 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7000.55 txn/s, latency: 3985.14 ms, (p50: 4100 ms, p70: 4500, p90: 5400 ms, p99: 5800 ms), latency samples: 131540
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7039.82 txn/s, latency: 4606.42 ms, (p50: 4900 ms, p70: 5000, p90: 5800 ms, p99: 6400 ms), latency samples: 237720
3. Upgrading rest of first batch to new version: 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6418.99 txn/s, latency: 4405.44 ms, (p50: 5100 ms, p70: 5300, p90: 5400 ms, p99: 5700 ms), latency samples: 117980
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5979.08 txn/s, latency: 5025.58 ms, (p50: 5500 ms, p70: 5600, p90: 5700 ms, p99: 5800 ms), latency samples: 218300
4. upgrading second batch to new version: 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8572.68 txn/s, latency: 3270.57 ms, (p50: 3200 ms, p70: 3500, p90: 4800 ms, p99: 5200 ms), latency samples: 154460
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8365.41 txn/s, latency: 3849.52 ms, (p50: 3700 ms, p70: 4000, p90: 5200 ms, p99: 6300 ms), latency samples: 284000
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 1ee68dac254e400e0bf0cf4cbc4ce7c3f165d710 passed
Test Ok

@larry-aptos larry-aptos merged commit 5013fb4 into main Nov 6, 2024
94 checks passed
@larry-aptos larry-aptos deleted the 11-04-include_the_ecosysystem-infra_team_as_the_proto_owner branch November 6, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants