Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflow delegator in transaction generator #15179

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

vusirikala
Copy link
Contributor

@vusirikala vusirikala commented Nov 4, 2024

Description

This PR refactors the workflow delegator. Workflow delegator uses custom logic when to switch after the first stage vs the rest of the stages. Refactoring it to use a more generic StageSwitchCondition. I usee this code in stable coin testing and felt like it could be helpful in the main branch too.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Sorry, something went wrong.

Copy link

trunk-io bot commented Nov 4, 2024

⏱️ 1h 21m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 24m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-cargo-deny 6m 🟩🟩🟩
test-target-determinator 5m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩
check 4m 🟩
rust-move-tests 3m
fetch-last-released-docker-image-tag 2m 🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 38s 🟩🟩🟩
file_change_determinator 11s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 24m 16m +52%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@igor-aptos igor-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@vusirikala vusirikala enabled auto-merge (squash) November 4, 2024 21:06

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ Forge suite realistic_env_max_load success on a2459a55f30e2760205171644a71424f8454b350

two traffics test: inner traffic : committed: 14248.68 txn/s, latency: 2785.88 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5417660
two traffics test : committed: 100.09 txn/s, latency: 1564.13 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 6900 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.975, avg: 1.566", "ConsensusProposalToOrdered: max: 0.324, avg: 0.295", "ConsensusOrderedToCommit: max: 0.371, avg: 0.361", "ConsensusProposalToCommit: max: 0.666, avg: 0.656"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 2761045 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.41s no progress at version 2761043 (avg 8.41s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a2459a55f30e2760205171644a71424f8454b350

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a2459a55f30e2760205171644a71424f8454b350 (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 12282.48 txn/s, latency: 2645.78 ms, (p50: 1700 ms, p70: 2000, p90: 3900 ms, p99: 20800 ms), latency samples: 465140
2. Upgrading first Validator to new version: a2459a55f30e2760205171644a71424f8454b350
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5907.58 txn/s, latency: 4884.11 ms, (p50: 5700 ms, p70: 5800, p90: 5900 ms, p99: 6100 ms), latency samples: 112640
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5631.08 txn/s, latency: 5358.77 ms, (p50: 5900 ms, p70: 6000, p90: 6000 ms, p99: 6400 ms), latency samples: 211880
3. Upgrading rest of first batch to new version: a2459a55f30e2760205171644a71424f8454b350
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6666.11 txn/s, latency: 4222.51 ms, (p50: 4800 ms, p70: 5100, p90: 5200 ms, p99: 5200 ms), latency samples: 121200
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6090.72 txn/s, latency: 5258.27 ms, (p50: 5300 ms, p70: 5400, p90: 7300 ms, p99: 7500 ms), latency samples: 229540
4. upgrading second batch to new version: a2459a55f30e2760205171644a71424f8454b350
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6674.35 txn/s, latency: 4230.33 ms, (p50: 4100 ms, p70: 4500, p90: 6800 ms, p99: 7200 ms), latency samples: 130240
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6343.52 txn/s, latency: 4649.61 ms, (p50: 4300 ms, p70: 5500, p90: 6900 ms, p99: 7300 ms), latency samples: 238840
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a2459a55f30e2760205171644a71424f8454b350 passed
Test Ok

@vusirikala vusirikala merged commit 016e8e9 into main Nov 4, 2024
92 checks passed
@vusirikala vusirikala deleted the satya/refactor_workflow_delegator branch November 4, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants