-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FUZZER] Multiple utils and library refactor, fuzzers #15176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 29m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
gedigi
reviewed
Nov 4, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gedigi
approved these changes
Nov 12, 2024
gedigi
reviewed
Nov 12, 2024
@@ -14,6 +14,7 @@ anyhow = { workspace = true } | |||
arbitrary = { workspace = true, features = ["derive_arbitrary"], optional = true } | |||
bcs = { workspace = true } | |||
bytes = { workspace = true } | |||
dearbitrary = { version = "1.0.4", optional = true, features = ["derive"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the same pattern where the external dependency version is declared at the workspace level?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
GotenJBZ
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New structure for utils:
helpers.rs
contains generic data structures and helpful functions. Specific data structures or functions for specific fuzzers are now located invm.rs
andauthenticator.rs
.testsuite/fuzz/src/main.rs
is now a CLI that introduces helpful commands to build fuzzers. Currently, onlycompile_federated_jwk
has been introduced, but others can be ported. This is a good PoC to show how to generate custom scripts/modules and embed them in the fuzzer's code if required for the setup. A newdata
folder is now present, which is used for support files for the new CLI.I turned all the fuzzers back on, as the build now works as expected on OSS-Fuzz.
How Has This Been Tested?
./fuzz.sh test
Key Areas to Review
N/A
Type of Change
Which Components or Systems Does This Change Impact?
Checklist