Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup trace file after coverage map is generated successfully #15153

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

brmataptos
Copy link
Contributor

@brmataptos brmataptos commented Nov 1, 2024

Description

During move test --coverage, a huge .trace file is generated, but is
then processed to generate a more compact coverage map which should
contain all neededed data. We now delete the .trace file after
successful generation of the coverage map.

Fixes #15054 .

How Has This Been Tested?

Ran manually on a few cases. Made sure that aptos move coverage ... features work without .trace file.

Key Areas to Review

?

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 1, 2024

@brmataptos brmataptos enabled auto-merge (squash) November 1, 2024 23:38

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 2, 2024

✅ Forge suite realistic_env_max_load success on fdf7844116925c733558adbcfd43e2b222f1f931

two traffics test: inner traffic : committed: 14302.88 txn/s, latency: 2779.07 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5438380
two traffics test : committed: 99.96 txn/s, latency: 1561.29 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 5300 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.037, avg: 1.578", "ConsensusProposalToOrdered: max: 0.324, avg: 0.294", "ConsensusOrderedToCommit: max: 0.369, avg: 0.359", "ConsensusProposalToCommit: max: 0.663, avg: 0.653"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.96s no progress at version 5952794 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.45s no progress at version 5952792 (avg 8.42s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 2, 2024

✅ Forge suite framework_upgrade success on 641ccd865fb3fe61699219aa0968d86101623353 ==> fdf7844116925c733558adbcfd43e2b222f1f931

Compatibility test results for 641ccd865fb3fe61699219aa0968d86101623353 ==> fdf7844116925c733558adbcfd43e2b222f1f931 (PR)
Upgrade the nodes to version: fdf7844116925c733558adbcfd43e2b222f1f931
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1301.69 txn/s, submitted: 1305.08 txn/s, failed submission: 3.39 txn/s, expired: 3.39 txn/s, latency: 2360.25 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 6000 ms), latency samples: 115220
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.04 txn/s, submitted: 1366.97 txn/s, failed submission: 2.93 txn/s, expired: 2.93 txn/s, latency: 2212.58 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5100 ms), latency samples: 121040
5. check swarm health
Compatibility test for 641ccd865fb3fe61699219aa0968d86101623353 ==> fdf7844116925c733558adbcfd43e2b222f1f931 passed
Upgrade the remaining nodes to version: fdf7844116925c733558adbcfd43e2b222f1f931
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1375.57 txn/s, submitted: 1378.89 txn/s, failed submission: 3.32 txn/s, expired: 3.32 txn/s, latency: 2147.18 ms, (p50: 2100 ms, p70: 2100, p90: 3300 ms, p99: 4700 ms), latency samples: 124300
Test Ok

Copy link
Contributor

github-actions bot commented Nov 2, 2024

✅ Forge suite compat success on 641ccd865fb3fe61699219aa0968d86101623353 ==> fdf7844116925c733558adbcfd43e2b222f1f931

Compatibility test results for 641ccd865fb3fe61699219aa0968d86101623353 ==> fdf7844116925c733558adbcfd43e2b222f1f931 (PR)
1. Check liveness of validators at old version: 641ccd865fb3fe61699219aa0968d86101623353
compatibility::simple-validator-upgrade::liveness-check : committed: 16990.21 txn/s, latency: 1940.66 ms, (p50: 1900 ms, p70: 2100, p90: 2400 ms, p99: 2700 ms), latency samples: 552020
2. Upgrading first Validator to new version: fdf7844116925c733558adbcfd43e2b222f1f931
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6876.42 txn/s, latency: 4118.33 ms, (p50: 4700 ms, p70: 5000, p90: 5100 ms, p99: 5100 ms), latency samples: 125220
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7183.32 txn/s, latency: 4557.25 ms, (p50: 5000 ms, p70: 5100, p90: 5200 ms, p99: 5200 ms), latency samples: 235380
3. Upgrading rest of first batch to new version: fdf7844116925c733558adbcfd43e2b222f1f931
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5787.88 txn/s, latency: 4971.83 ms, (p50: 5700 ms, p70: 5900, p90: 6000 ms, p99: 6200 ms), latency samples: 111360
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5518.89 txn/s, latency: 5456.62 ms, (p50: 5900 ms, p70: 6100, p90: 6200 ms, p99: 7200 ms), latency samples: 214300
4. upgrading second batch to new version: fdf7844116925c733558adbcfd43e2b222f1f931
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8498.89 txn/s, latency: 3208.35 ms, (p50: 2400 ms, p70: 3400, p90: 7600 ms, p99: 8600 ms), latency samples: 152800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8470.78 txn/s, latency: 3660.77 ms, (p50: 2900 ms, p70: 4600, p90: 6000 ms, p99: 8300 ms), latency samples: 304980
5. check swarm health
Compatibility test for 641ccd865fb3fe61699219aa0968d86101623353 ==> fdf7844116925c733558adbcfd43e2b222f1f931 passed
Test Ok

@brmataptos brmataptos merged commit c05b1f7 into main Nov 2, 2024
86 of 92 checks passed
@brmataptos brmataptos deleted the brm-issue-15054 branch November 2, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Huge .trace file occurs after running tests/build many times (sometimes in parallel)
3 participants