Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop writing down usage at all versions #15148

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Oct 31, 2024

Description

write only at chunk boundaries and the latest checkpoint (used to be enabled with sharding but it's actually orthognal)

How Has This Been Tested?

existing coverage

Key Areas to Review

Type of Change

  • New feature

Which Components or Systems Does This Change Impact?

  • Validator Node

Copy link

trunk-io bot commented Oct 31, 2024

⏱️ 3h 5m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 58m 🟥🟩🟥🟩
execution-performance / test-target-determinator 18m 🟩🟩🟩🟩
dispatch_event 18m 🟩
test-target-determinator 18m 🟩🟩🟩🟩
check 15m 🟩🟩🟩🟩
rust-move-tests 9m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
fetch-last-released-docker-image-tag 6m 🟩🟩🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 4m
general-lints 2m 🟩🟩🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@msmouse msmouse requested a review from zekun000 October 31, 2024 23:56
@msmouse msmouse enabled auto-merge (squash) October 31, 2024 23:58
@msmouse msmouse added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 1, 2024
@msmouse msmouse requested a review from areshand November 1, 2024 00:03

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

write only at chunk boundaries and the latest checkpoint
(used to be enabled with sharding but it's actually orthognal)
@msmouse msmouse force-pushed the 1031-alden-skip-usage branch from aa477d0 to 427ab68 Compare November 1, 2024 16:52

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Forge suite realistic_env_max_load success on 427ab68b89ce4a6ac75295b6d2888f0d53dca767

two traffics test: inner traffic : committed: 14029.70 txn/s, latency: 2833.05 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5334400
two traffics test : committed: 100.05 txn/s, latency: 1474.87 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 4700 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.093, avg: 1.650", "ConsensusProposalToOrdered: max: 0.321, avg: 0.300", "ConsensusOrderedToCommit: max: 0.409, avg: 0.394", "ConsensusProposalToCommit: max: 0.709, avg: 0.695"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 30466 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.53s no progress at version 2682054 (avg 8.53s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Forge suite framework_upgrade success on 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 427ab68b89ce4a6ac75295b6d2888f0d53dca767

Compatibility test results for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 427ab68b89ce4a6ac75295b6d2888f0d53dca767 (PR)
Upgrade the nodes to version: 427ab68b89ce4a6ac75295b6d2888f0d53dca767
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1380.06 txn/s, submitted: 1383.37 txn/s, failed submission: 3.30 txn/s, expired: 3.30 txn/s, latency: 2212.05 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5400 ms), latency samples: 125400
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1440.63 txn/s, submitted: 1443.59 txn/s, failed submission: 2.95 txn/s, expired: 2.95 txn/s, latency: 2112.68 ms, (p50: 2000 ms, p70: 2100, p90: 3100 ms, p99: 4800 ms), latency samples: 126900
5. check swarm health
Compatibility test for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 427ab68b89ce4a6ac75295b6d2888f0d53dca767 passed
Upgrade the remaining nodes to version: 427ab68b89ce4a6ac75295b6d2888f0d53dca767
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1377.94 txn/s, submitted: 1382.83 txn/s, failed submission: 4.88 txn/s, expired: 4.88 txn/s, latency: 2151.58 ms, (p50: 2100 ms, p70: 2400, p90: 2900 ms, p99: 4200 ms), latency samples: 124220
Test Ok

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Forge suite compat success on 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 427ab68b89ce4a6ac75295b6d2888f0d53dca767

Compatibility test results for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 427ab68b89ce4a6ac75295b6d2888f0d53dca767 (PR)
1. Check liveness of validators at old version: 4ce6dddf9e0cfe007f84cbb4756368295417b3ce
compatibility::simple-validator-upgrade::liveness-check : committed: 15942.30 txn/s, latency: 2076.73 ms, (p50: 1900 ms, p70: 2100, p90: 2700 ms, p99: 4000 ms), latency samples: 520060
2. Upgrading first Validator to new version: 427ab68b89ce4a6ac75295b6d2888f0d53dca767
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7015.76 txn/s, latency: 4041.82 ms, (p50: 4700 ms, p70: 4800, p90: 5000 ms, p99: 5000 ms), latency samples: 129680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6306.82 txn/s, latency: 4809.25 ms, (p50: 5000 ms, p70: 5100, p90: 5200 ms, p99: 7200 ms), latency samples: 240460
3. Upgrading rest of first batch to new version: 427ab68b89ce4a6ac75295b6d2888f0d53dca767
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6448.24 txn/s, latency: 4422.56 ms, (p50: 5100 ms, p70: 5300, p90: 5400 ms, p99: 5500 ms), latency samples: 115200
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6571.08 txn/s, latency: 4976.68 ms, (p50: 5400 ms, p70: 5500, p90: 5600 ms, p99: 5700 ms), latency samples: 223820
4. upgrading second batch to new version: 427ab68b89ce4a6ac75295b6d2888f0d53dca767
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 1327.04 txn/s, latency: 17252.50 ms, (p50: 18900 ms, p70: 25100, p90: 27100 ms, p99: 28700 ms), latency samples: 57120
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1349.29 txn/s, latency: 19794.03 ms, (p50: 24700 ms, p70: 26800, p90: 28600 ms, p99: 29900 ms), latency samples: 76440
5. check swarm health
Compatibility test for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 427ab68b89ce4a6ac75295b6d2888f0d53dca767 passed
Test Ok

@msmouse msmouse merged commit 5a7a416 into main Nov 1, 2024
48 checks passed
@msmouse msmouse deleted the 1031-alden-skip-usage branch November 1, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants