Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Txns for Default Processor #15142

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add Txns for Default Processor #15142

merged 3 commits into from
Oct 31, 2024

Conversation

dermanyang
Copy link
Contributor

@dermanyang dermanyang commented Oct 31, 2024

Description

Generate new transactions for the default_processor diff tests from mainnet.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 31, 2024

⏱️ 1h 56m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 18m 🟥
rust-cargo-deny 11m 🟩🟩🟩🟩🟩 (+2 more)
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
check-dynamic-deps 9m 🟩🟩🟩🟩🟩 (+2 more)
dispatch_event 8m 🟩
dispatch_event 8m 🟩
check 7m 🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 3m 🟩🟩🟩🟩🟩 (+2 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 12s 25m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@dermanyang dermanyang changed the title Generate txns Add Txns for Default Processor Oct 31, 2024
@dermanyang dermanyang marked this pull request as ready for review October 31, 2024 18:20
@dermanyang dermanyang requested review from yuunlimm and rtso October 31, 2024 18:20
@dermanyang dermanyang added indexer API CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR and removed indexer API labels Oct 31, 2024
@dermanyang dermanyang enabled auto-merge (squash) October 31, 2024 21:17

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 47931d470ceacea20479dcb8a9d5d109a4e58918

two traffics test: inner traffic : committed: 14396.89 txn/s, latency: 2760.17 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5474980
two traffics test : committed: 100.03 txn/s, latency: 1424.49 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 3900 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.033, avg: 1.589", "ConsensusProposalToOrdered: max: 0.314, avg: 0.291", "ConsensusOrderedToCommit: max: 0.368, avg: 0.358", "ConsensusProposalToCommit: max: 0.658, avg: 0.649"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.03s no progress at version 2368149 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.71s no progress at version 2368147 (avg 8.71s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 47931d470ceacea20479dcb8a9d5d109a4e58918

Compatibility test results for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 47931d470ceacea20479dcb8a9d5d109a4e58918 (PR)
1. Check liveness of validators at old version: 4ce6dddf9e0cfe007f84cbb4756368295417b3ce
compatibility::simple-validator-upgrade::liveness-check : committed: 14153.14 txn/s, latency: 2381.47 ms, (p50: 1700 ms, p70: 1900, p90: 2800 ms, p99: 17600 ms), latency samples: 544960
2. Upgrading first Validator to new version: 47931d470ceacea20479dcb8a9d5d109a4e58918
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6798.63 txn/s, latency: 4047.52 ms, (p50: 4100 ms, p70: 4800, p90: 5400 ms, p99: 5900 ms), latency samples: 128680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6724.36 txn/s, latency: 4752.26 ms, (p50: 5100 ms, p70: 5300, p90: 6400 ms, p99: 6700 ms), latency samples: 228360
3. Upgrading rest of first batch to new version: 47931d470ceacea20479dcb8a9d5d109a4e58918
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6863.96 txn/s, latency: 4129.35 ms, (p50: 4600 ms, p70: 5000, p90: 5300 ms, p99: 5500 ms), latency samples: 129160
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6853.94 txn/s, latency: 4700.20 ms, (p50: 5000 ms, p70: 5200, p90: 6300 ms, p99: 6800 ms), latency samples: 230600
4. upgrading second batch to new version: 47931d470ceacea20479dcb8a9d5d109a4e58918
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8611.51 txn/s, latency: 3269.01 ms, (p50: 3400 ms, p70: 4000, p90: 4600 ms, p99: 4700 ms), latency samples: 160620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7456.55 txn/s, latency: 4035.80 ms, (p50: 3600 ms, p70: 4600, p90: 5400 ms, p99: 6100 ms), latency samples: 278160
5. check swarm health
Compatibility test for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 47931d470ceacea20479dcb8a9d5d109a4e58918 passed
Test Ok

@dermanyang dermanyang merged commit 2fa2e6f into main Oct 31, 2024
227 of 241 checks passed
@dermanyang dermanyang deleted the sdy/default_processor_txns branch October 31, 2024 21:52
msmouse pushed a commit that referenced this pull request Nov 1, 2024
* Generate txns

* remove api key

* generate txn for defualt cti
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants