Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix forge profiling link #15141

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix forge profiling link #15141

merged 2 commits into from
Nov 13, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Oct 31, 2024

Description

Fix the links to the Forge CPU profiles. Grafana updated the pyroscope app and some of the parameters changed

How Has This Been Tested?

python3 -m unittest forge_test.py

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon requested review from ibalajiarun, perryjrandall and a team October 31, 2024 17:43
Copy link

trunk-io bot commented Oct 31, 2024

⏱️ 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 9m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 54s 🟩
general-lints 26s 🟩
semgrep/ci 26s 🟩
file_change_determinator 12s 🟩
determine-forge-run-metadata 4s 🟩🟩
permission-check 2s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@aluon aluon enabled auto-merge (squash) November 12, 2024 23:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b4e09cd40826db88b64c002276e6e4045188bc97

two traffics test: inner traffic : committed: 14360.30 txn/s, latency: 2769.80 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4500 ms), latency samples: 5460220
two traffics test : committed: 99.94 txn/s, latency: 1582.83 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 8100 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.992, avg: 1.572", "ConsensusProposalToOrdered: max: 0.336, avg: 0.297", "ConsensusOrderedToCommit: max: 0.365, avg: 0.352", "ConsensusProposalToCommit: max: 0.656, avg: 0.649"]
Max non-epoch-change gap was: 1 rounds at version 37021 (avg 0.00) [limit 4], 2.08s no progress at version 37021 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.36s no progress at version 2720927 (avg 8.36s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 8a161886956d0b8360b152f051628bed624f7c24 ==> b4e09cd40826db88b64c002276e6e4045188bc97

Compatibility test results for 8a161886956d0b8360b152f051628bed624f7c24 ==> b4e09cd40826db88b64c002276e6e4045188bc97 (PR)
Upgrade the nodes to version: b4e09cd40826db88b64c002276e6e4045188bc97
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1450.19 txn/s, submitted: 1452.88 txn/s, failed submission: 2.68 txn/s, expired: 2.68 txn/s, latency: 2142.20 ms, (p50: 2100 ms, p70: 2100, p90: 3300 ms, p99: 4800 ms), latency samples: 129660
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1396.91 txn/s, submitted: 1399.11 txn/s, failed submission: 2.21 txn/s, expired: 2.21 txn/s, latency: 2130.70 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4200 ms), latency samples: 126500
5. check swarm health
Compatibility test for 8a161886956d0b8360b152f051628bed624f7c24 ==> b4e09cd40826db88b64c002276e6e4045188bc97 passed
Upgrade the remaining nodes to version: b4e09cd40826db88b64c002276e6e4045188bc97
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1553.05 txn/s, submitted: 1556.45 txn/s, failed submission: 3.40 txn/s, expired: 3.40 txn/s, latency: 2094.12 ms, (p50: 1900 ms, p70: 2100, p90: 3300 ms, p99: 4500 ms), latency samples: 137000
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 8a161886956d0b8360b152f051628bed624f7c24 ==> b4e09cd40826db88b64c002276e6e4045188bc97

Compatibility test results for 8a161886956d0b8360b152f051628bed624f7c24 ==> b4e09cd40826db88b64c002276e6e4045188bc97 (PR)
1. Check liveness of validators at old version: 8a161886956d0b8360b152f051628bed624f7c24
compatibility::simple-validator-upgrade::liveness-check : committed: 15042.30 txn/s, latency: 2294.60 ms, (p50: 1800 ms, p70: 1900, p90: 3000 ms, p99: 8500 ms), latency samples: 562820
2. Upgrading first Validator to new version: b4e09cd40826db88b64c002276e6e4045188bc97
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7728.79 txn/s, latency: 3495.56 ms, (p50: 3600 ms, p70: 4300, p90: 4800 ms, p99: 5000 ms), latency samples: 139980
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7980.35 txn/s, latency: 4002.41 ms, (p50: 4100 ms, p70: 4200, p90: 6200 ms, p99: 6300 ms), latency samples: 266120
3. Upgrading rest of first batch to new version: b4e09cd40826db88b64c002276e6e4045188bc97
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7579.27 txn/s, latency: 3797.98 ms, (p50: 4200 ms, p70: 4400, p90: 4500 ms, p99: 4600 ms), latency samples: 144260
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6986.88 txn/s, latency: 4244.77 ms, (p50: 4500 ms, p70: 4600, p90: 4600 ms, p99: 5900 ms), latency samples: 264920
4. upgrading second batch to new version: b4e09cd40826db88b64c002276e6e4045188bc97
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10780.34 txn/s, latency: 2602.78 ms, (p50: 2500 ms, p70: 2900, p90: 4100 ms, p99: 4500 ms), latency samples: 208980
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10692.86 txn/s, latency: 2890.73 ms, (p50: 2500 ms, p70: 2900, p90: 5500 ms, p99: 7400 ms), latency samples: 347860
5. check swarm health
Compatibility test for 8a161886956d0b8360b152f051628bed624f7c24 ==> b4e09cd40826db88b64c002276e6e4045188bc97 passed
Test Ok

@aluon aluon merged commit 94ff412 into main Nov 13, 2024
48 checks passed
@aluon aluon deleted the aluon/push-qoyzlsxrzxpp branch November 13, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants