Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] [Cli] Fix typo #15132

Merged
merged 5 commits into from
Nov 1, 2024
Merged

[Bugfix] [Cli] Fix typo #15132

merged 5 commits into from
Nov 1, 2024

Conversation

fEst1ck
Copy link
Contributor

@fEst1ck fEst1ck commented Oct 31, 2024

Description

Fixed #15131

How Has This Been Tested?

Run cargo run -p aptos -- move compile --help and check the output.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Copy link

trunk-io bot commented Oct 31, 2024

⏱️ 1h 31m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 13m 🟩🟩🟩
test-target-determinator 13m 🟩🟩🟩
check-dynamic-deps 11m 🟩🟩🟩🟩🟩 (+2 more)
check 11m 🟩🟩🟩
rust-cargo-deny 6m 🟥🟥🟩 (+3 more)
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 24m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@gregnazario
Copy link
Contributor

Please update changelog

@fEst1ck fEst1ck enabled auto-merge (squash) October 31, 2024 23:57

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@@ -4,6 +4,9 @@ All notable changes to the Aptos CLI will be captured in this file. This project

## Unreleased

## [4.3.1] - 2024/10/31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fEst1ck, do we plan to release 4.3.1 for this typo? If not, you could add it under Unreleased.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Thanks for pointing out

@fEst1ck fEst1ck disabled auto-merge November 1, 2024 01:07
@fEst1ck fEst1ck enabled auto-merge (squash) November 1, 2024 01:36

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Forge suite realistic_env_max_load success on 3dd84850d3598aee86e6a86f0a1722c963b22ffc

two traffics test: inner traffic : committed: 14279.80 txn/s, latency: 2784.80 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5429500
two traffics test : committed: 100.09 txn/s, latency: 1471.65 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 3300 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.031, avg: 1.602", "ConsensusProposalToOrdered: max: 0.320, avg: 0.295", "ConsensusOrderedToCommit: max: 0.364, avg: 0.353", "ConsensusProposalToCommit: max: 0.657, avg: 0.648"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.25s no progress at version 15901 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.42s no progress at version 2611279 (avg 8.42s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Forge suite framework_upgrade success on 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 3dd84850d3598aee86e6a86f0a1722c963b22ffc

Compatibility test results for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 3dd84850d3598aee86e6a86f0a1722c963b22ffc (PR)
Upgrade the nodes to version: 3dd84850d3598aee86e6a86f0a1722c963b22ffc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1399.51 txn/s, submitted: 1402.28 txn/s, failed submission: 2.77 txn/s, expired: 2.77 txn/s, latency: 2404.09 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5300 ms), latency samples: 121260
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1329.53 txn/s, submitted: 1334.57 txn/s, failed submission: 5.04 txn/s, expired: 5.04 txn/s, latency: 2217.06 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4500 ms), latency samples: 121280
5. check swarm health
Compatibility test for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 3dd84850d3598aee86e6a86f0a1722c963b22ffc passed
Upgrade the remaining nodes to version: 3dd84850d3598aee86e6a86f0a1722c963b22ffc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.65 txn/s, submitted: 1366.00 txn/s, failed submission: 1.35 txn/s, expired: 1.35 txn/s, latency: 2245.10 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4900 ms), latency samples: 121300
Test Ok

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Forge suite compat success on 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 3dd84850d3598aee86e6a86f0a1722c963b22ffc

Compatibility test results for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 3dd84850d3598aee86e6a86f0a1722c963b22ffc (PR)
1. Check liveness of validators at old version: 4ce6dddf9e0cfe007f84cbb4756368295417b3ce
compatibility::simple-validator-upgrade::liveness-check : committed: 14618.12 txn/s, latency: 2328.06 ms, (p50: 2000 ms, p70: 2100, p90: 2300 ms, p99: 7500 ms), latency samples: 542740
2. Upgrading first Validator to new version: 3dd84850d3598aee86e6a86f0a1722c963b22ffc
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6619.38 txn/s, latency: 4177.75 ms, (p50: 4900 ms, p70: 5000, p90: 5300 ms, p99: 5800 ms), latency samples: 117140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6639.59 txn/s, latency: 4833.45 ms, (p50: 5200 ms, p70: 5300, p90: 6700 ms, p99: 6900 ms), latency samples: 221340
3. Upgrading rest of first batch to new version: 3dd84850d3598aee86e6a86f0a1722c963b22ffc
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6151.21 txn/s, latency: 4602.27 ms, (p50: 5100 ms, p70: 5600, p90: 5700 ms, p99: 5900 ms), latency samples: 113400
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6180.99 txn/s, latency: 5196.49 ms, (p50: 5700 ms, p70: 5900, p90: 6600 ms, p99: 7000 ms), latency samples: 208260
4. upgrading second batch to new version: 3dd84850d3598aee86e6a86f0a1722c963b22ffc
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9226.06 txn/s, latency: 3030.95 ms, (p50: 3400 ms, p70: 3600, p90: 3700 ms, p99: 4000 ms), latency samples: 166520
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9035.93 txn/s, latency: 3610.65 ms, (p50: 3800 ms, p70: 3900, p90: 4100 ms, p99: 4300 ms), latency samples: 293660
5. check swarm health
Compatibility test for 4ce6dddf9e0cfe007f84cbb4756368295417b3ce ==> 3dd84850d3598aee86e6a86f0a1722c963b22ffc passed
Test Ok

@fEst1ck fEst1ck merged commit 19a1871 into aptos-labs:main Nov 1, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [CLI] Typo in aptos move compile help messages
4 participants