Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[small] Consolidate/deduplicate some Framework Move structs in rust #15125

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

igor-aptos
Copy link
Contributor

Description

We have some of the common structs in multiple places - Rosetta, tests. I needed to add some of these for perf testing as well, so consolidating them a bit first.

How Has This Been Tested?

CI

Type of Change

  • Refactoring

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 30, 2024

⏱️ 3h 5m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 8m 🟩🟩🟩
test-target-determinator 20m 🟩🟩🟩🟩
execution-performance / test-target-determinator 14m 🟩🟩🟩
check 11m 🟩🟩🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
fetch-last-released-docker-image-tag 6m 🟩🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 3m 🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@lightmark lightmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@gregnazario take a look on rosetta?

@igor-aptos igor-aptos enabled auto-merge (rebase) November 1, 2024 16:51
@igor-aptos
Copy link
Contributor Author

@gregnazario landing, as changes should be trivial, but if you have any concerns, let me know.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos requested a review from grao1991 as a code owner November 5, 2024 21:09
@igor-aptos
Copy link
Contributor Author

@lightmark , @msmouse fyi - made file layout more consistent (all fa events in one file, all coin events in another), and added MoveEventV1Type and TypeInfoResource.

fixed the unit test (there was a typo in the strings). landing now

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

fixing unit test failure

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite realistic_env_max_load success on b905dd7a81862ec120381231d6dfe3ab4a58f46d

two traffics test: inner traffic : committed: 14112.13 txn/s, latency: 2816.19 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 12600 ms), latency samples: 5365920
two traffics test : committed: 100.11 txn/s, latency: 1712.32 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 10900 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.051, avg: 1.562", "ConsensusProposalToOrdered: max: 0.323, avg: 0.292", "ConsensusOrderedToCommit: max: 0.369, avg: 0.360", "ConsensusProposalToCommit: max: 0.663, avg: 0.652"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.12s no progress at version 5698500 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.67s no progress at version 5698498 (avg 8.56s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite framework_upgrade success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b905dd7a81862ec120381231d6dfe3ab4a58f46d

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b905dd7a81862ec120381231d6dfe3ab4a58f46d (PR)
Upgrade the nodes to version: b905dd7a81862ec120381231d6dfe3ab4a58f46d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1308.76 txn/s, submitted: 1311.85 txn/s, failed submission: 3.09 txn/s, expired: 3.09 txn/s, latency: 2320.12 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5700 ms), latency samples: 118740
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1355.87 txn/s, submitted: 1358.52 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2186.84 ms, (p50: 1800 ms, p70: 2100, p90: 3600 ms, p99: 5100 ms), latency samples: 122780
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b905dd7a81862ec120381231d6dfe3ab4a58f46d passed
Upgrade the remaining nodes to version: b905dd7a81862ec120381231d6dfe3ab4a58f46d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1361.50 txn/s, submitted: 1363.05 txn/s, failed submission: 1.55 txn/s, expired: 1.55 txn/s, latency: 2177.24 ms, (p50: 1900 ms, p70: 2400, p90: 3300 ms, p99: 5100 ms), latency samples: 122980
Test Ok

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b905dd7a81862ec120381231d6dfe3ab4a58f46d

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b905dd7a81862ec120381231d6dfe3ab4a58f46d (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 14290.42 txn/s, latency: 2377.67 ms, (p50: 1800 ms, p70: 1900, p90: 4500 ms, p99: 10300 ms), latency samples: 510620
2. Upgrading first Validator to new version: b905dd7a81862ec120381231d6dfe3ab4a58f46d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6909.59 txn/s, latency: 4093.97 ms, (p50: 4800 ms, p70: 4900, p90: 5000 ms, p99: 5100 ms), latency samples: 128760
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6454.63 txn/s, latency: 5032.08 ms, (p50: 5200 ms, p70: 5300, p90: 6600 ms, p99: 7000 ms), latency samples: 223520
3. Upgrading rest of first batch to new version: b905dd7a81862ec120381231d6dfe3ab4a58f46d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7033.83 txn/s, latency: 4008.89 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5100 ms), latency samples: 128800
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6585.09 txn/s, latency: 4885.54 ms, (p50: 5000 ms, p70: 5000, p90: 6600 ms, p99: 6900 ms), latency samples: 224640
4. upgrading second batch to new version: b905dd7a81862ec120381231d6dfe3ab4a58f46d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8603.23 txn/s, latency: 3306.75 ms, (p50: 3300 ms, p70: 3600, p90: 5000 ms, p99: 5200 ms), latency samples: 158700
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8151.85 txn/s, latency: 3892.21 ms, (p50: 3500 ms, p70: 4600, p90: 6000 ms, p99: 6800 ms), latency samples: 263980
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> b905dd7a81862ec120381231d6dfe3ab4a58f46d passed
Test Ok

@igor-aptos igor-aptos merged commit 44ec93b into main Nov 6, 2024
48 checks passed
@igor-aptos igor-aptos deleted the igor/event_v2_rust branch November 6, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants