-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[small] Consolidate/deduplicate some Framework Move structs in rust #15125
Conversation
⏱️ 3h 5m total CI duration on this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gregnazario take a look on rosetta?
@gregnazario landing, as changes should be trivial, but if you have any concerns, let me know. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eded498
to
cc94b3b
Compare
@lightmark , @msmouse fyi - made file layout more consistent (all fa events in one file, all coin events in another), and added MoveEventV1Type and TypeInfoResource. fixed the unit test (there was a typo in the strings). landing now |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fixing unit test failure
cc94b3b
to
b905dd7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
We have some of the common structs in multiple places - Rosetta, tests. I needed to add some of these for perf testing as well, so consolidating them a bit first.
How Has This Been Tested?
CI
Type of Change
Checklist