[cli] Release 4.3.0 & Chunked publish override #15122

gregnazario · 2024-10-30T18:19:39Z

Description

Fixes parsing of large packages override address

How Has This Been Tested?

This works now with localnet when deploying locally. It didn't work with address aliases / missing 0x before.

Now:

../../../target/cli/aptos move publish --profile local2 --named-addresses hello_blockchain=local2 --chunked-publish --large-packages-module-address local
Compiling, may take a little while to download git dependencies...
INCLUDING DEPENDENCY AptosFramework
INCLUDING DEPENDENCY AptosStdlib
INCLUDING DEPENDENCY MoveStdlib
BUILDING Examples
package size 1718 bytes
Publishing package in chunked mode will submit 1 transactions for staging and publishing code.

Transaction 1 of 1
Do you want to submit a transaction for a range of [8700 - 13000] Octas at a gas unit price of 100 Octas? [yes/no] >
y
Transaction submitted: https://explorer.aptoslabs.com/txn/0x39de952efb6141c0e8e202586bff56782f76981eaea1d8506178664a0e475b6a
Transaction executed: Success (0x39de952efb6141c0e8e202586bff56782f76981eaea1d8506178664a0e475b6a)

All Transactions Submitted Successfully.

Submitted Transactions:
[
    "0x39de952efb6141c0e8e202586bff56782f76981eaea1d8506178664a0e475b6a"
]

{
  "Result": {
    "transaction_hash": "0x39de952efb6141c0e8e202586bff56782f76981eaea1d8506178664a0e475b6a",
    "gas_used": 87,
    "gas_unit_price": 100,
    "sender": "bbc26d8b2194683644c3a6355f963bb9cd51dc1f788d26302aee4cc329bc8201",
    "sequence_number": 1,
    "success": true,
    "timestamp_us": 1730312302622749,
    "version": 7457,
    "vm_status": "Executed successfully"
  }
}

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

The CLI was parsing the address deep in the code instead of the top level argument parsing. This now also allows you to use address aliasing

trunk-io · 2024-10-30T18:19:42Z

⏱️ 58m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	22m	🟩
rust-move-tests	9m	🟩
rust-doc-tests	5m	🟩
test-target-determinator	5m	🟩
execution-performance / test-target-determinator	5m	🟩
check	4m	🟩
check-dynamic-deps	3m	🟩 🟩
rust-cargo-deny	2m	⬜ 🟩
fetch-last-released-docker-image-tag	2m	🟩
semgrep/ci	49s	🟩 🟩
general-lints	42s	⬜ 🟩
file_change_determinator	22s	🟩 🟩
rust-move-tests	17s	⬜
file_change_determinator	13s	🟩
permission-check	12s	🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

github-actions · 2024-10-30T18:47:31Z

✅ Forge suite `realistic_env_max_load` success on `8f8fb4036ce4e7b6277c9cf169d7e65f29d38968`

two traffics test: inner traffic : committed: 14554.69 txn/s, latency: 2730.57 ms, (p50: 2400 ms, p70: 2700, p90: 3000 ms, p99: 6400 ms), latency samples: 5534000
two traffics test : committed: 100.00 txn/s, latency: 1961.32 ms, (p50: 1400 ms, p70: 1400, p90: 4300 ms, p99: 9100 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.743, avg: 1.271", "ConsensusProposalToOrdered: max: 0.316, avg: 0.290", "ConsensusOrderedToCommit: max: 0.367, avg: 0.354", "ConsensusProposalToCommit: max: 0.653, avg: 0.644"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.95s no progress at version 2910562 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.63s no progress at version 2910560 (avg 8.63s) [limit 15].
Test Ok

github-actions · 2024-10-30T18:50:26Z

✅ Forge suite `framework_upgrade` success on `9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd` ==> `8f8fb4036ce4e7b6277c9cf169d7e65f29d38968`

Compatibility test results for 9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd ==> 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968 (PR)
Upgrade the nodes to version: 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1227.31 txn/s, submitted: 1228.64 txn/s, failed submission: 1.33 txn/s, expired: 1.33 txn/s, latency: 2501.00 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5500 ms), latency samples: 110720
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1255.32 txn/s, submitted: 1257.73 txn/s, failed submission: 2.41 txn/s, expired: 2.41 txn/s, latency: 2381.37 ms, (p50: 2100 ms, p70: 2500, p90: 3600 ms, p99: 5700 ms), latency samples: 114460
5. check swarm health
Compatibility test for 9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd ==> 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968 passed
Upgrade the remaining nodes to version: 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1390.33 txn/s, submitted: 1393.71 txn/s, failed submission: 3.38 txn/s, expired: 3.38 txn/s, latency: 2154.81 ms, (p50: 2000 ms, p70: 2100, p90: 3300 ms, p99: 5100 ms), latency samples: 123540
Test Ok

github-actions · 2024-10-30T18:53:54Z

✅ Forge suite `compat` success on `9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd` ==> `8f8fb4036ce4e7b6277c9cf169d7e65f29d38968`

Compatibility test results for 9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd ==> 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968 (PR)
1. Check liveness of validators at old version: 9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd
compatibility::simple-validator-upgrade::liveness-check : committed: 13828.25 txn/s, latency: 2485.10 ms, (p50: 1600 ms, p70: 1800, p90: 2600 ms, p99: 25400 ms), latency samples: 536880
2. Upgrading first Validator to new version: 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6824.18 txn/s, latency: 4146.93 ms, (p50: 4400 ms, p70: 4700, p90: 5500 ms, p99: 5800 ms), latency samples: 131620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6796.47 txn/s, latency: 4759.98 ms, (p50: 5100 ms, p70: 5300, p90: 6400 ms, p99: 6900 ms), latency samples: 230860
3. Upgrading rest of first batch to new version: 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6693.14 txn/s, latency: 4273.96 ms, (p50: 4900 ms, p70: 5100, p90: 5300 ms, p99: 5300 ms), latency samples: 121900
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6618.74 txn/s, latency: 4828.77 ms, (p50: 5300 ms, p70: 5500, p90: 6100 ms, p99: 6400 ms), latency samples: 220700
4. upgrading second batch to new version: 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8804.54 txn/s, latency: 3195.72 ms, (p50: 3400 ms, p70: 3700, p90: 4400 ms, p99: 5100 ms), latency samples: 156400
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8592.30 txn/s, latency: 3700.70 ms, (p50: 3600 ms, p70: 4300, p90: 5000 ms, p99: 5900 ms), latency samples: 287000
5. check swarm health
Compatibility test for 9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd ==> 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968 passed
Test Ok

gregnazario added 2 commits October 30, 2024 14:16

[cli] Fix address parsing for large package publishing override address

0d1fea9

The CLI was parsing the address deep in the code instead of the top level argument parsing. This now also allows you to use address aliasing

[cli] Release 4.3.0

8f8fb40

gregnazario requested review from banool, davidiw, movekevin and wrwg as code owners October 30, 2024 18:19

gregnazario self-assigned this Oct 30, 2024

gregnazario enabled auto-merge (rebase) October 30, 2024 18:20

banool approved these changes Oct 30, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

GhostWalker562 approved these changes Oct 30, 2024

View reviewed changes

gregnazario merged commit fab5b45 into aptos-labs:main Oct 30, 2024
86 of 92 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cli] Release 4.3.0 & Chunked publish override #15122

[cli] Release 4.3.0 & Chunked publish override #15122

gregnazario commented Oct 30, 2024

trunk-io bot commented Oct 30, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

[cli] Release 4.3.0 & Chunked publish override #15122

[cli] Release 4.3.0 & Chunked publish override #15122

Conversation

gregnazario commented Oct 30, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Oct 30, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 30, 2024

✅ Forge suite realistic_env_max_load success on 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968

github-actions bot commented Oct 30, 2024

✅ Forge suite framework_upgrade success on 9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd ==> 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968

github-actions bot commented Oct 30, 2024

✅ Forge suite compat success on 9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd ==> 8f8fb4036ce4e7b6277c9cf169d7e65f29d38968

trunk-io bot commented Oct 30, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `8f8fb4036ce4e7b6277c9cf169d7e65f29d38968`

✅ Forge suite `framework_upgrade` success on `9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd` ==> `8f8fb4036ce4e7b6277c9cf169d7e65f29d38968`

✅ Forge suite `compat` success on `9c922ebe94f5ff4b58df4617f3ff003e2ce10ccd` ==> `8f8fb4036ce4e7b6277c9cf169d7e65f29d38968`