Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add token v2 tests txns #15110

Merged
merged 3 commits into from
Oct 30, 2024
Merged

add token v2 tests txns #15110

merged 3 commits into from
Oct 30, 2024

Conversation

rtso
Copy link
Contributor

@rtso rtso commented Oct 29, 2024

Description

Add contextual token v2 test transactions

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 29, 2024

⏱️ 2h 11m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 24m 🟥
dispatch_event 23m 🟥
dispatch_event 21m 🟩
execution-performance / test-target-determinator 14m 🟩🟩🟩
test-target-determinator 10m 🟩🟩
check 7m 🟩🟩
rust-cargo-deny 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
general-lints 1m 🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 5m 4m +25%
execution-performance / single-node-performance 10s 24m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

rtso commented Oct 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rtso and the rest of your teammates on Graphite Graphite

@rtso rtso requested review from dermanyang and yuunlimm October 29, 2024 19:16
@rtso rtso marked this pull request as ready for review October 29, 2024 19:16
@rtso rtso enabled auto-merge (rebase) October 29, 2024 19:56

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 6871d5162fdb54cf1314f32edaa3d984ffd5e220

two traffics test: inner traffic : committed: 14181.18 txn/s, latency: 2801.62 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5392020
two traffics test : committed: 100.01 txn/s, latency: 1630.92 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 10700 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.093, avg: 1.622", "ConsensusProposalToOrdered: max: 0.329, avg: 0.298", "ConsensusOrderedToCommit: max: 0.356, avg: 0.347", "ConsensusProposalToCommit: max: 0.654, avg: 0.645"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.93s no progress at version 2192556 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.72s no progress at version 2192554 (avg 8.72s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 347b8f99af8307c426dc1c25243582fb25ae0f3e ==> 6871d5162fdb54cf1314f32edaa3d984ffd5e220

Compatibility test results for 347b8f99af8307c426dc1c25243582fb25ae0f3e ==> 6871d5162fdb54cf1314f32edaa3d984ffd5e220 (PR)
1. Check liveness of validators at old version: 347b8f99af8307c426dc1c25243582fb25ae0f3e
compatibility::simple-validator-upgrade::liveness-check : committed: 4555.46 txn/s, submitted: 4566.75 txn/s, expired: 11.29 txn/s, latency: 5858.31 ms, (p50: 1700 ms, p70: 2700, p90: 7600 ms, p99: 56200 ms), latency samples: 377724
2. Upgrading first Validator to new version: 6871d5162fdb54cf1314f32edaa3d984ffd5e220
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6002.24 txn/s, latency: 4772.36 ms, (p50: 5400 ms, p70: 5800, p90: 5900 ms, p99: 6000 ms), latency samples: 112320
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6419.68 txn/s, latency: 5028.46 ms, (p50: 5500 ms, p70: 5700, p90: 5800 ms, p99: 6000 ms), latency samples: 221300
3. Upgrading rest of first batch to new version: 6871d5162fdb54cf1314f32edaa3d984ffd5e220
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6492.76 txn/s, latency: 4359.35 ms, (p50: 5000 ms, p70: 5200, p90: 5400 ms, p99: 5400 ms), latency samples: 118800
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6343.38 txn/s, latency: 5159.58 ms, (p50: 5200 ms, p70: 5300, p90: 6900 ms, p99: 7400 ms), latency samples: 224360
4. upgrading second batch to new version: 6871d5162fdb54cf1314f32edaa3d984ffd5e220
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6244.45 txn/s, latency: 3942.74 ms, (p50: 3400 ms, p70: 3800, p90: 9000 ms, p99: 9600 ms), latency samples: 119780
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6777.88 txn/s, latency: 4432.25 ms, (p50: 2900 ms, p70: 4900, p90: 9100 ms, p99: 10100 ms), latency samples: 241860
5. check swarm health
Compatibility test for 347b8f99af8307c426dc1c25243582fb25ae0f3e ==> 6871d5162fdb54cf1314f32edaa3d984ffd5e220 passed
Test Ok

@rtso rtso merged commit 751286c into main Oct 30, 2024
49 checks passed
@rtso rtso deleted the 10-29-add_token_v2_tests_txns branch October 30, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants