Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade validator not in set error to warn #15102

Merged
merged 1 commit into from
Oct 28, 2024
Merged

downgrade validator not in set error to warn #15102

merged 1 commit into from
Oct 28, 2024

Conversation

zekun000
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 28, 2024

⏱️ 31m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 4m 🟩🟩
check-dynamic-deps 2m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 1m 🟩
general-lints 55s 🟩🟩
semgrep/ci 38s 🟩🟩
file_change_determinator 24s 🟩🟩
file_change_determinator 11s 🟩
execution-performance / single-node-performance 10s 🟩
permission-check 7s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 19m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zekun000 zekun000 enabled auto-merge (rebase) October 28, 2024 21:43

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ed20c328cd8b5f2693b498268ca0209e53d6024a

two traffics test: inner traffic : committed: 14232.48 txn/s, latency: 2792.12 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5411500
two traffics test : committed: 99.97 txn/s, latency: 1452.42 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 2600 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.084, avg: 1.617", "ConsensusProposalToOrdered: max: 0.311, avg: 0.295", "ConsensusOrderedToCommit: max: 0.391, avg: 0.380", "ConsensusProposalToCommit: max: 0.684, avg: 0.675"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 6044338 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.84s no progress at version 1740190 (avg 8.69s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on abbdda713c7f2349f8963ef4c952eb72368c23d4 ==> ed20c328cd8b5f2693b498268ca0209e53d6024a

Compatibility test results for abbdda713c7f2349f8963ef4c952eb72368c23d4 ==> ed20c328cd8b5f2693b498268ca0209e53d6024a (PR)
Upgrade the nodes to version: ed20c328cd8b5f2693b498268ca0209e53d6024a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1493.25 txn/s, submitted: 1496.00 txn/s, failed submission: 2.75 txn/s, expired: 2.75 txn/s, latency: 2237.77 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4500 ms), latency samples: 119440
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1287.86 txn/s, submitted: 1290.73 txn/s, failed submission: 2.87 txn/s, expired: 2.87 txn/s, latency: 2290.60 ms, (p50: 2100 ms, p70: 2400, p90: 3200 ms, p99: 5000 ms), latency samples: 116620
5. check swarm health
Compatibility test for abbdda713c7f2349f8963ef4c952eb72368c23d4 ==> ed20c328cd8b5f2693b498268ca0209e53d6024a passed
Upgrade the remaining nodes to version: ed20c328cd8b5f2693b498268ca0209e53d6024a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1344.38 txn/s, submitted: 1346.19 txn/s, failed submission: 1.81 txn/s, expired: 1.81 txn/s, latency: 2283.13 ms, (p50: 2100 ms, p70: 2400, p90: 3400 ms, p99: 5200 ms), latency samples: 118880
Test Ok

Copy link
Contributor

✅ Forge suite compat success on abbdda713c7f2349f8963ef4c952eb72368c23d4 ==> ed20c328cd8b5f2693b498268ca0209e53d6024a

Compatibility test results for abbdda713c7f2349f8963ef4c952eb72368c23d4 ==> ed20c328cd8b5f2693b498268ca0209e53d6024a (PR)
1. Check liveness of validators at old version: abbdda713c7f2349f8963ef4c952eb72368c23d4
compatibility::simple-validator-upgrade::liveness-check : committed: 16543.99 txn/s, latency: 2041.56 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 3700 ms), latency samples: 535740
2. Upgrading first Validator to new version: ed20c328cd8b5f2693b498268ca0209e53d6024a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6889.31 txn/s, latency: 4131.59 ms, (p50: 4800 ms, p70: 5000, p90: 5100 ms, p99: 5200 ms), latency samples: 123060
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7084.93 txn/s, latency: 4612.08 ms, (p50: 5100 ms, p70: 5200, p90: 5300 ms, p99: 5300 ms), latency samples: 232600
3. Upgrading rest of first batch to new version: ed20c328cd8b5f2693b498268ca0209e53d6024a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5993.78 txn/s, latency: 4798.37 ms, (p50: 5500 ms, p70: 5800, p90: 5900 ms, p99: 6000 ms), latency samples: 113320
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5556.56 txn/s, latency: 5411.65 ms, (p50: 5900 ms, p70: 6000, p90: 6100 ms, p99: 6300 ms), latency samples: 206120
4. upgrading second batch to new version: ed20c328cd8b5f2693b498268ca0209e53d6024a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7157.54 txn/s, latency: 4074.63 ms, (p50: 4100 ms, p70: 4400, p90: 6000 ms, p99: 6500 ms), latency samples: 132940
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6962.69 txn/s, latency: 4502.79 ms, (p50: 4200 ms, p70: 5800, p90: 6100 ms, p99: 7400 ms), latency samples: 233420
5. check swarm health
Compatibility test for abbdda713c7f2349f8963ef4c952eb72368c23d4 ==> ed20c328cd8b5f2693b498268ca0209e53d6024a passed
Test Ok

@zekun000 zekun000 merged commit 7ea4594 into main Oct 28, 2024
92 checks passed
@zekun000 zekun000 deleted the zekun/error branch October 28, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants