Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more FA test txn's #15081

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add more FA test txn's #15081

merged 2 commits into from
Oct 28, 2024

Conversation

rtso
Copy link
Contributor

@rtso rtso commented Oct 24, 2024

Description

Add test transactions that include the rest of the resources and events that are indexed by the FA processor.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 24, 2024

⏱️ 2h 5m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-smoke-tests 28m 🟥
test-target-determinator 14m 🟩🟩🟩
execution-performance / test-target-determinator 13m 🟩🟩🟩
check 11m 🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
dispatch_event 6m 🟥
dispatch_event 5m 🟥
dispatch_event 5m 🟥
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 4m 🟩🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rtso rtso changed the title add more fa txns Add more FA test txn's Oct 24, 2024
Copy link
Contributor Author

rtso commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rtso and the rest of your teammates on Graphite Graphite

@rtso rtso requested review from yuunlimm and a team October 24, 2024 22:43
@rtso rtso marked this pull request as ready for review October 24, 2024 22:43
@rtso rtso enabled auto-merge (rebase) October 24, 2024 23:19

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@rtso rtso force-pushed the 10-24-add_more_fa_txns branch from 75a8f81 to 9ffc0a3 Compare October 25, 2024 16:38

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ccb4b6e5dc460f7939100dcf6b1c199b081b704e

two traffics test: inner traffic : committed: 14066.97 txn/s, latency: 2823.98 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5348720
two traffics test : committed: 100.00 txn/s, latency: 1605.43 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 10000 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.082, avg: 1.631", "ConsensusProposalToOrdered: max: 0.340, avg: 0.301", "ConsensusOrderedToCommit: max: 0.367, avg: 0.353", "ConsensusProposalToCommit: max: 0.664, avg: 0.654"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.21s no progress at version 41926 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.40s no progress at version 2746420 (avg 8.40s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> ccb4b6e5dc460f7939100dcf6b1c199b081b704e

Compatibility test results for f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> ccb4b6e5dc460f7939100dcf6b1c199b081b704e (PR)
1. Check liveness of validators at old version: f38ec72e975a4dff4e9919e7a1d8118a75858bab
compatibility::simple-validator-upgrade::liveness-check : committed: 13368.58 txn/s, latency: 2146.13 ms, (p50: 1900 ms, p70: 2000, p90: 2600 ms, p99: 8100 ms), latency samples: 516380
2. Upgrading first Validator to new version: ccb4b6e5dc460f7939100dcf6b1c199b081b704e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6213.97 txn/s, latency: 4531.59 ms, (p50: 4700 ms, p70: 5200, p90: 6100 ms, p99: 6600 ms), latency samples: 121200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6056.99 txn/s, latency: 5332.98 ms, (p50: 5600 ms, p70: 5900, p90: 7000 ms, p99: 7500 ms), latency samples: 209340
3. Upgrading rest of first batch to new version: ccb4b6e5dc460f7939100dcf6b1c199b081b704e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5696.40 txn/s, latency: 5103.50 ms, (p50: 5900 ms, p70: 6100, p90: 6300 ms, p99: 6400 ms), latency samples: 111780
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5463.56 txn/s, latency: 5927.65 ms, (p50: 6300 ms, p70: 6400, p90: 7100 ms, p99: 7900 ms), latency samples: 181600
4. upgrading second batch to new version: ccb4b6e5dc460f7939100dcf6b1c199b081b704e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8375.07 txn/s, latency: 3343.67 ms, (p50: 3700 ms, p70: 3900, p90: 4100 ms, p99: 4300 ms), latency samples: 155800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7457.91 txn/s, latency: 3900.89 ms, (p50: 4100 ms, p70: 4200, p90: 4600 ms, p99: 5800 ms), latency samples: 281840
5. check swarm health
Compatibility test for f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> ccb4b6e5dc460f7939100dcf6b1c199b081b704e passed
Test Ok

@rtso rtso merged commit b92cbb8 into main Oct 28, 2024
48 of 49 checks passed
@rtso rtso deleted the 10-24-add_more_fa_txns branch October 28, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants