Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bumping to 4.2.6 to fix in issue with --move-2 flag #15064

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Oct 23, 2024

Description

Bumping version of cli to fix a bug with move-2 flag

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 23, 2024

⏱️ 2h 10m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-smoke-tests 32m 🟩
execution-performance / single-node-performance 22m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
rust-move-tests 5m
rust-move-tests 5m
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
check-dynamic-deps 4m 🟩🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

wrwg commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite Graphite

@wrwg wrwg marked this pull request as ready for review October 23, 2024 20:17
crates/aptos/Cargo.toml Show resolved Hide resolved
@wrwg wrwg enabled auto-merge (squash) October 23, 2024 22:13

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa

two traffics test: inner traffic : committed: 14207.67 txn/s, latency: 2794.92 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5402100
two traffics test : committed: 100.01 txn/s, latency: 1527.49 ms, (p50: 1500 ms, p70: 1500, p90: 1600 ms, p99: 6200 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.014, avg: 1.584", "ConsensusProposalToOrdered: max: 0.323, avg: 0.295", "ConsensusOrderedToCommit: max: 0.386, avg: 0.375", "ConsensusProposalToCommit: max: 0.681, avg: 0.670"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.04s no progress at version 14889 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.49s no progress at version 2936456 (avg 8.49s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa (PR)
Upgrade the nodes to version: b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1253.81 txn/s, submitted: 1257.20 txn/s, failed submission: 3.39 txn/s, expired: 3.39 txn/s, latency: 2460.26 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5100 ms), latency samples: 110980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1163.11 txn/s, submitted: 1165.75 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2732.58 ms, (p50: 2400 ms, p70: 3000, p90: 4200 ms, p99: 6500 ms), latency samples: 96880
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa passed
Upgrade the remaining nodes to version: b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1203.99 txn/s, submitted: 1206.65 txn/s, failed submission: 2.66 txn/s, expired: 2.66 txn/s, latency: 2489.54 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5200 ms), latency samples: 108460
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 14278.80 txn/s, latency: 2399.44 ms, (p50: 1800 ms, p70: 1900, p90: 3800 ms, p99: 12100 ms), latency samples: 514840
2. Upgrading first Validator to new version: b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6463.28 txn/s, latency: 4411.27 ms, (p50: 4700 ms, p70: 5500, p90: 5600 ms, p99: 5700 ms), latency samples: 120680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6577.15 txn/s, latency: 4957.75 ms, (p50: 5400 ms, p70: 5500, p90: 5800 ms, p99: 6600 ms), latency samples: 226780
3. Upgrading rest of first batch to new version: b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 1289.88 txn/s, latency: 17661.21 ms, (p50: 18700 ms, p70: 23900, p90: 27700 ms, p99: 28600 ms), latency samples: 56260
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6361.12 txn/s, latency: 5022.34 ms, (p50: 5600 ms, p70: 5800, p90: 6200 ms, p99: 6700 ms), latency samples: 212340
4. upgrading second batch to new version: b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9379.03 txn/s, latency: 2987.93 ms, (p50: 3300 ms, p70: 3600, p90: 3900 ms, p99: 4200 ms), latency samples: 165780
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8362.05 txn/s, latency: 3808.65 ms, (p50: 3700 ms, p70: 4000, p90: 6300 ms, p99: 6600 ms), latency samples: 285680
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b3ea0d2d788ac5aaf292671ff7dbee42ac9e0caa passed
Test Ok

@wrwg wrwg merged commit ad0b8eb into main Oct 23, 2024
87 of 92 checks passed
@wrwg wrwg deleted the wrwg/cli-4.2.6 branch October 23, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants