Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode enable_storage_sharding #15063

Merged
merged 1 commit into from
Oct 23, 2024
Merged

hardcode enable_storage_sharding #15063

merged 1 commit into from
Oct 23, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Oct 23, 2024

Description

Set enable_storage_sharding and enable_event to be true

How Has This Been Tested?

Will run adhoc forge
https://github.com/aptos-labs/aptos-core/actions/runs/11488481527

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 23, 2024

⏱️ 1h 19m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
adhoc-forge-test / forge 31m 🟩🟩
test-target-determinator 13m 🟩🟩🟩
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
check-dynamic-deps 3m 🟩🟩🟩🟩
rust-move-tests 2m 🟩
general-lints 2m 🟩🟩🟩
rust-move-tests 2m 🟩
semgrep/ci 2m 🟩🟩🟩🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 1m 🟩
file_change_determinator 34s 🟩🟩🟩
file_change_determinator 33s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@aluon aluon added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Oct 23, 2024
@aluon aluon force-pushed the aluon/push-qkmxmppstqmk branch from 5b0755a to 812966d Compare October 23, 2024 21:27
@aluon aluon marked this pull request as ready for review October 23, 2024 21:29
@aluon aluon requested review from sionescu, ibalajiarun, fEst1ck and a team October 23, 2024 21:29
@aluon aluon requested a review from perryjrandall October 23, 2024 21:32
@aluon aluon changed the title log helm values hardcode enable_storage_sharding Oct 23, 2024
@aluon aluon enabled auto-merge (squash) October 23, 2024 22:17

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 812966d7b8ddd50e1bb934d655f1860c69a94162

two traffics test: inner traffic : committed: 14259.07 txn/s, latency: 2784.15 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5421620
two traffics test : committed: 100.02 txn/s, latency: 1573.77 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 9600 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.848, avg: 1.514", "ConsensusProposalToOrdered: max: 0.318, avg: 0.296", "ConsensusOrderedToCommit: max: 0.380, avg: 0.370", "ConsensusProposalToCommit: max: 0.674, avg: 0.666"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.01s no progress at version 2056162 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.47s no progress at version 2056160 (avg 7.31s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 812966d7b8ddd50e1bb934d655f1860c69a94162

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 812966d7b8ddd50e1bb934d655f1860c69a94162 (PR)
Upgrade the nodes to version: 812966d7b8ddd50e1bb934d655f1860c69a94162
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1195.18 txn/s, submitted: 1198.07 txn/s, failed submission: 2.90 txn/s, expired: 2.90 txn/s, latency: 2698.97 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 6000 ms), latency samples: 107320
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1153.06 txn/s, submitted: 1154.42 txn/s, failed submission: 1.36 txn/s, expired: 1.36 txn/s, latency: 2632.80 ms, (p50: 2100 ms, p70: 2700, p90: 4500 ms, p99: 6400 ms), latency samples: 102040
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 812966d7b8ddd50e1bb934d655f1860c69a94162 passed
Upgrade the remaining nodes to version: 812966d7b8ddd50e1bb934d655f1860c69a94162
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1094.67 txn/s, submitted: 1097.52 txn/s, failed submission: 2.86 txn/s, expired: 2.86 txn/s, latency: 2702.32 ms, (p50: 2400 ms, p70: 3000, p90: 4500 ms, p99: 6000 ms), latency samples: 99600
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 812966d7b8ddd50e1bb934d655f1860c69a94162

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 812966d7b8ddd50e1bb934d655f1860c69a94162 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 16400.47 txn/s, latency: 2069.85 ms, (p50: 2100 ms, p70: 2200, p90: 2300 ms, p99: 3300 ms), latency samples: 525880
2. Upgrading first Validator to new version: 812966d7b8ddd50e1bb934d655f1860c69a94162
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5966.22 txn/s, latency: 4797.08 ms, (p50: 5400 ms, p70: 5800, p90: 5900 ms, p99: 6100 ms), latency samples: 112140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5667.03 txn/s, latency: 5678.12 ms, (p50: 6000 ms, p70: 6100, p90: 7200 ms, p99: 7700 ms), latency samples: 190240
3. Upgrading rest of first batch to new version: 812966d7b8ddd50e1bb934d655f1860c69a94162
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5886.17 txn/s, latency: 4831.41 ms, (p50: 5500 ms, p70: 5800, p90: 5900 ms, p99: 6200 ms), latency samples: 112020
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6070.12 txn/s, latency: 5322.85 ms, (p50: 5700 ms, p70: 5800, p90: 7100 ms, p99: 7500 ms), latency samples: 208180
4. upgrading second batch to new version: 812966d7b8ddd50e1bb934d655f1860c69a94162
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8674.29 txn/s, latency: 3207.90 ms, (p50: 3400 ms, p70: 3700, p90: 4400 ms, p99: 4900 ms), latency samples: 156100
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8167.76 txn/s, latency: 3873.31 ms, (p50: 3600 ms, p70: 4700, p90: 5300 ms, p99: 6500 ms), latency samples: 268880
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 812966d7b8ddd50e1bb934d655f1860c69a94162 passed
Test Ok

@aluon aluon merged commit c944c77 into main Oct 23, 2024
93 of 94 checks passed
@aluon aluon deleted the aluon/push-qkmxmppstqmk branch October 23, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants