Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Replace unwraps with better error handling #15061

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

gregnazario
Copy link
Contributor

Description

Makes error handling come out of stderr instead of relying on panics.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@gregnazario gregnazario requested a review from 0xmaayan October 23, 2024 18:35
@gregnazario gregnazario requested a review from banool as a code owner October 23, 2024 18:35
Copy link

trunk-io bot commented Oct 23, 2024

⏱️ 49m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 8m 🟩🟩
test-target-determinator 7m 🟩
check 7m 🟩
rust-cargo-deny 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 4m 🟩🟩
rust-doc-tests 3m
check-dynamic-deps 2m 🟩🟩🟩
rust-move-tests 2m 🟩
general-lints 2m 🟩🟩🟩
rust-move-tests 1m 🟩
rust-move-tests 1m 🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 30s 🟩🟩🟩
file_change_determinator 20s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d17121aeef9a35d3904e4c1dd9d938b09043b5d0

two traffics test: inner traffic : committed: 13889.74 txn/s, latency: 2858.64 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3300 ms), latency samples: 5281280
two traffics test : committed: 100.06 txn/s, latency: 1509.28 ms, (p50: 1500 ms, p70: 1500, p90: 1700 ms, p99: 3800 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.090, avg: 1.632", "ConsensusProposalToOrdered: max: 0.333, avg: 0.301", "ConsensusOrderedToCommit: max: 0.385, avg: 0.371", "ConsensusProposalToCommit: max: 0.680, avg: 0.672"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.91s no progress at version 2748999 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.26s no progress at version 2748997 (avg 8.26s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> d17121aeef9a35d3904e4c1dd9d938b09043b5d0

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> d17121aeef9a35d3904e4c1dd9d938b09043b5d0 (PR)
Upgrade the nodes to version: d17121aeef9a35d3904e4c1dd9d938b09043b5d0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1245.92 txn/s, submitted: 1247.90 txn/s, failed submission: 1.99 txn/s, expired: 1.99 txn/s, latency: 2490.08 ms, (p50: 2400 ms, p70: 2700, p90: 3400 ms, p99: 5100 ms), latency samples: 112920
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1240.74 txn/s, submitted: 1243.38 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2414.01 ms, (p50: 2300 ms, p70: 2600, p90: 3600 ms, p99: 5300 ms), latency samples: 112740
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> d17121aeef9a35d3904e4c1dd9d938b09043b5d0 passed
Upgrade the remaining nodes to version: d17121aeef9a35d3904e4c1dd9d938b09043b5d0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1164.67 txn/s, submitted: 1166.81 txn/s, failed submission: 2.14 txn/s, expired: 2.14 txn/s, latency: 2837.45 ms, (p50: 2400 ms, p70: 3000, p90: 4800 ms, p99: 6600 ms), latency samples: 98180
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> d17121aeef9a35d3904e4c1dd9d938b09043b5d0

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> d17121aeef9a35d3904e4c1dd9d938b09043b5d0 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 13837.72 txn/s, latency: 2071.22 ms, (p50: 1800 ms, p70: 1900, p90: 2200 ms, p99: 14900 ms), latency samples: 540280
2. Upgrading first Validator to new version: d17121aeef9a35d3904e4c1dd9d938b09043b5d0
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6656.01 txn/s, latency: 4178.53 ms, (p50: 4600 ms, p70: 4700, p90: 5600 ms, p99: 5800 ms), latency samples: 128900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7015.28 txn/s, latency: 4591.34 ms, (p50: 4800 ms, p70: 4900, p90: 6400 ms, p99: 6800 ms), latency samples: 237220
3. Upgrading rest of first batch to new version: d17121aeef9a35d3904e4c1dd9d938b09043b5d0
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7062.21 txn/s, latency: 4007.96 ms, (p50: 4400 ms, p70: 4800, p90: 5000 ms, p99: 5000 ms), latency samples: 129500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7098.41 txn/s, latency: 4588.75 ms, (p50: 4900 ms, p70: 5100, p90: 5800 ms, p99: 6300 ms), latency samples: 240760
4. upgrading second batch to new version: d17121aeef9a35d3904e4c1dd9d938b09043b5d0
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8082.64 txn/s, latency: 3523.08 ms, (p50: 3200 ms, p70: 3400, p90: 5900 ms, p99: 6300 ms), latency samples: 146020
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7489.61 txn/s, latency: 4264.22 ms, (p50: 3600 ms, p70: 5700, p90: 6300 ms, p99: 8100 ms), latency samples: 244780
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> d17121aeef9a35d3904e4c1dd9d938b09043b5d0 passed
Test Ok

@0xmaayan 0xmaayan merged commit 31f3820 into aptos-labs:main Oct 23, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants