Make StateComputeResult an combination of immutable stage outputs

[msmouse]

Description

This is to make it easy to move data and logic between stages.

How Has This Been Tested?

existing coverage

Key Areas to Review

Type of Change

• Refactoring

Which Components or Systems Does This Change Impact?

• Validator Node

[trunk-io]

⏱️ 28h 59m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	10h 2m	🟥 🟩 🟩 🟥 🟩 (+25 more)
single-node-performance	6h 17m	🟥 🟥 🟩 🟩 🟥 (+10 more)
execution-performance / test-target-determinator	2h 2m	🟩 🟩 🟩 🟩 🟩 (+23 more)
test-target-determinator	1h 24m	🟩 🟩 ⬜ 🟩 🟩 (+17 more)
check	1h 11m	🟩 🟩 ⬜ 🟩 🟩 (+17 more)
test-target-determinator	59m	🟩 🟩 🟩 🟩 🟩 (+10 more)
check-dynamic-deps	35m	🟩 🟩 🟩 🟩 🟩 (+18 more)
rust-cargo-deny	35m	🟩 🟩 ⬜ 🟩 🟩 (+16 more)
fetch-last-released-docker-image-tag	33m	🟩 🟩 ⬜ 🟩 🟩 (+17 more)
rust-smoke-tests	30m	🟥
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	34m	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on 8a333147b518446ce5ea2b39417f0b0039a34869

two traffics test: inner traffic : committed: 14308.13 txn/s, latency: 2777.50 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5440260
two traffics test : committed: 99.94 txn/s, latency: 1496.24 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 7400 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.999, avg: 1.573", "ConsensusProposalToOrdered: max: 0.325, avg: 0.293", "ConsensusOrderedToCommit: max: 0.367, avg: 0.352", "ConsensusProposalToCommit: max: 0.658, avg: 0.645"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 44817 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.50s no progress at version 2486330 (avg 8.50s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> 8a333147b518446ce5ea2b39417f0b0039a34869

Compatibility test results for f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> 8a333147b518446ce5ea2b39417f0b0039a34869 (PR)
Upgrade the nodes to version: 8a333147b518446ce5ea2b39417f0b0039a34869
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1240.50 txn/s, submitted: 1244.04 txn/s, failed submission: 3.54 txn/s, expired: 3.54 txn/s, latency: 2400.25 ms, (p50: 2400 ms, p70: 2400, p90: 3600 ms, p99: 5400 ms), latency samples: 112040
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1267.45 txn/s, submitted: 1269.88 txn/s, failed submission: 2.42 txn/s, expired: 2.42 txn/s, latency: 2385.11 ms, (p50: 2400 ms, p70: 2600, p90: 3500 ms, p99: 4500 ms), latency samples: 115000
5. check swarm health
Compatibility test for f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> 8a333147b518446ce5ea2b39417f0b0039a34869 passed
Upgrade the remaining nodes to version: 8a333147b518446ce5ea2b39417f0b0039a34869
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1409.15 txn/s, submitted: 1411.85 txn/s, failed submission: 2.71 txn/s, expired: 2.71 txn/s, latency: 2147.29 ms, (p50: 1800 ms, p70: 2100, p90: 3300 ms, p99: 5800 ms), latency samples: 124880
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> 8a333147b518446ce5ea2b39417f0b0039a34869

Compatibility test results for f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> 8a333147b518446ce5ea2b39417f0b0039a34869 (PR)
1. Check liveness of validators at old version: f38ec72e975a4dff4e9919e7a1d8118a75858bab
compatibility::simple-validator-upgrade::liveness-check : committed: 14667.04 txn/s, latency: 2261.56 ms, (p50: 1900 ms, p70: 2100, p90: 2900 ms, p99: 8700 ms), latency samples: 559920
2. Upgrading first Validator to new version: 8a333147b518446ce5ea2b39417f0b0039a34869
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6969.29 txn/s, latency: 4044.54 ms, (p50: 4400 ms, p70: 4800, p90: 5400 ms, p99: 5700 ms), latency samples: 131620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6980.65 txn/s, latency: 4629.61 ms, (p50: 4900 ms, p70: 5100, p90: 6300 ms, p99: 6700 ms), latency samples: 234360
3. Upgrading rest of first batch to new version: 8a333147b518446ce5ea2b39417f0b0039a34869
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6745.56 txn/s, latency: 4249.88 ms, (p50: 4900 ms, p70: 5100, p90: 5200 ms, p99: 5400 ms), latency samples: 124800
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6689.81 txn/s, latency: 4863.44 ms, (p50: 5300 ms, p70: 5400, p90: 6100 ms, p99: 6700 ms), latency samples: 224360
4. upgrading second batch to new version: 8a333147b518446ce5ea2b39417f0b0039a34869
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8760.76 txn/s, latency: 3271.67 ms, (p50: 3600 ms, p70: 3900, p90: 4100 ms, p99: 4400 ms), latency samples: 156000
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7695.29 txn/s, latency: 3890.26 ms, (p50: 3900 ms, p70: 4100, p90: 4400 ms, p99: 5800 ms), latency samples: 284660
5. check swarm health
Compatibility test for f38ec72e975a4dff4e9919e7a1d8118a75858bab ==> 8a333147b518446ce5ea2b39417f0b0039a34869 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking