[cli 4.2.4] Preparing for CLI release #15027

wrwg · 2024-10-21T07:00:33Z

Updating CHANGELOG
Marking Move 2.1 stable and the default

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-10-21T07:00:37Z

⏱️ 6h 21m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	2h 38m	🟩 🟩 🟥 🟥 🟩 (+2 more)
execution-performance / test-target-determinator	22m	🟩 🟩 🟩 🟩 🟩 (+1 more)
test-target-determinator	19m	🟩 ⬜ 🟩 🟩 🟩 (+1 more)
rust-targeted-unit-tests	18m	🟩
rust-cargo-deny	17m	🟩 🟩 ⬜ 🟩 🟩 (+5 more)
check	15m	🟩 🟩 ⬜ 🟩 🟩
rust-move-tests	12m	🟥 🟩
check-dynamic-deps	12m	🟩 🟩 🟩 🟩 🟩 (+5 more)
fetch-last-released-docker-image-tag	10m	🟩 ⬜ 🟩 🟩 🟩 (+1 more)
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟥

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

wrwg · 2024-10-21T07:00:48Z

[cli 4.2.4] Preparing for CLI release #15027 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite

rahxephon89 · 2024-10-21T18:50:57Z

Should we use language version 2.1 when specifying move-2?

aptos-core/crates/aptos/src/common/types.rs

Line 1155 in a822e65

/// Defaults to `1`, or `2` if `--move-2` is selected.

@wrwg @brmataptos

0xmaayan

LGTM

- Updating CHANGELOG - Marking Move 2.1 stable and the default

vineethk · 2024-10-22T22:40:59Z

crates/aptos/src/common/types.rs

@@ -1181,7 +1181,7 @@ pub struct MovePackageDir {
    pub language_version: Option<LanguageVersion>,

    /// Select bytecode, language version, and compiler to support Move 2:
-    /// Same as `--bytecode_version=7 --language_version=2.0 --compiler_version=2.0`
+    /// Same as `--bytecode_version=7 --language_version=2.1 --compiler_version=2.0`


In the attributes for the field language_version above, we have default_value_if("move_2", "true", "2.0"): should we change this to default_value_if("move_2", "true", "2.1")?

github-actions · 2024-10-22T22:52:11Z

✅ Forge suite `realistic_env_max_load` success on `eef61fa4491c0d1e6fcf663506561877f578d4e4`

two traffics test: inner traffic : committed: 14206.23 txn/s, latency: 2795.46 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5401500
two traffics test : committed: 100.04 txn/s, latency: 1628.97 ms, (p50: 1500 ms, p70: 1500, p90: 1700 ms, p99: 11100 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.234, avg: 0.219", "QsPosToProposal: max: 1.202, avg: 1.162", "ConsensusProposalToOrdered: max: 0.319, avg: 0.294", "ConsensusOrderedToCommit: max: 0.384, avg: 0.374", "ConsensusProposalToCommit: max: 0.678, avg: 0.668"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 2764259 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.52s no progress at version 2764257 (avg 8.52s) [limit 15].
Test Ok

github-actions · 2024-10-22T22:53:11Z

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `eef61fa4491c0d1e6fcf663506561877f578d4e4`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> eef61fa4491c0d1e6fcf663506561877f578d4e4 (PR)
Upgrade the nodes to version: eef61fa4491c0d1e6fcf663506561877f578d4e4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1108.21 txn/s, submitted: 1110.20 txn/s, failed submission: 1.99 txn/s, expired: 1.99 txn/s, latency: 3515.42 ms, (p50: 2400 ms, p70: 3000, p90: 5100 ms, p99: 16900 ms), latency samples: 100200
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1319.01 txn/s, submitted: 1320.96 txn/s, failed submission: 1.96 txn/s, expired: 1.96 txn/s, latency: 2521.55 ms, (p50: 2400 ms, p70: 2700, p90: 4000 ms, p99: 5700 ms), latency samples: 107840
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> eef61fa4491c0d1e6fcf663506561877f578d4e4 passed
Upgrade the remaining nodes to version: eef61fa4491c0d1e6fcf663506561877f578d4e4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1190.46 txn/s, submitted: 1192.69 txn/s, failed submission: 2.23 txn/s, expired: 2.23 txn/s, latency: 2514.54 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5700 ms), latency samples: 106780
Test Ok

github-actions · 2024-10-22T22:55:25Z

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `eef61fa4491c0d1e6fcf663506561877f578d4e4`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> eef61fa4491c0d1e6fcf663506561877f578d4e4 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 15211.32 txn/s, latency: 2218.15 ms, (p50: 1900 ms, p70: 2100, p90: 2600 ms, p99: 6600 ms), latency samples: 494000
2. Upgrading first Validator to new version: eef61fa4491c0d1e6fcf663506561877f578d4e4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6295.12 txn/s, latency: 4403.84 ms, (p50: 4600 ms, p70: 5200, p90: 5800 ms, p99: 6300 ms), latency samples: 119560
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6352.35 txn/s, latency: 5065.33 ms, (p50: 5500 ms, p70: 5700, p90: 6000 ms, p99: 7000 ms), latency samples: 217080
3. Upgrading rest of first batch to new version: eef61fa4491c0d1e6fcf663506561877f578d4e4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6818.42 txn/s, latency: 4145.99 ms, (p50: 4800 ms, p70: 5000, p90: 5100 ms, p99: 5200 ms), latency samples: 124100
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6408.06 txn/s, latency: 5072.50 ms, (p50: 5200 ms, p70: 5200, p90: 6600 ms, p99: 7000 ms), latency samples: 223140
4. upgrading second batch to new version: eef61fa4491c0d1e6fcf663506561877f578d4e4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9125.98 txn/s, latency: 3027.60 ms, (p50: 3200 ms, p70: 3600, p90: 4300 ms, p99: 4500 ms), latency samples: 167280
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8828.59 txn/s, latency: 3606.16 ms, (p50: 3600 ms, p70: 3800, p90: 5700 ms, p99: 6000 ms), latency samples: 294900
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> eef61fa4491c0d1e6fcf663506561877f578d4e4 passed
Test Ok

wrwg force-pushed the wrwg/cli_4.2.4 branch from 1c1962d to cc827cf Compare October 22, 2024 00:28

wrwg requested review from brmataptos, fEst1ck, rahxephon89 and vineethk October 22, 2024 00:29

0xmaayan approved these changes Oct 22, 2024

View reviewed changes

wrwg force-pushed the wrwg/cli_4.2.4 branch from cc827cf to c4c27a9 Compare October 22, 2024 00:31

wrwg marked this pull request as ready for review October 22, 2024 00:31

wrwg requested review from gregnazario, banool, davidiw and movekevin as code owners October 22, 2024 00:31

wrwg force-pushed the wrwg/cli_4.2.4 branch from c4c27a9 to 2e40d4b Compare October 22, 2024 17:30

rahxephon89 approved these changes Oct 22, 2024

View reviewed changes

wrwg added CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR CICD:run-forge-e2e-perf Run the e2e perf forge only labels Oct 22, 2024

This comment has been minimized.

Sign in to view

wrwg force-pushed the wrwg/cli_4.2.4 branch from 2e40d4b to be2e37e Compare October 22, 2024 19:43

This comment has been minimized.

Sign in to view

wrwg enabled auto-merge (squash) October 22, 2024 20:17

wrwg force-pushed the wrwg/cli_4.2.4 branch from be2e37e to 426cd53 Compare October 22, 2024 20:18

This comment has been minimized.

Sign in to view

[cli 4.2.4] Preparing for CLI release

eef61fa

- Updating CHANGELOG - Marking Move 2.1 stable and the default

wrwg force-pushed the wrwg/cli_4.2.4 branch from 426cd53 to eef61fa Compare October 22, 2024 20:59

This comment has been minimized.

Sign in to view

vineethk reviewed Oct 22, 2024

View reviewed changes

wrwg merged commit 280e15b into main Oct 22, 2024
51 of 54 checks passed

wrwg deleted the wrwg/cli_4.2.4 branch October 22, 2024 22:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cli 4.2.4] Preparing for CLI release #15027

[cli 4.2.4] Preparing for CLI release #15027

wrwg commented Oct 21, 2024

trunk-io bot commented Oct 21, 2024 •

edited

Loading

wrwg commented Oct 21, 2024

rahxephon89 commented Oct 21, 2024 •

edited by brmataptos

Loading

0xmaayan left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vineethk Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

[cli 4.2.4] Preparing for CLI release #15027

[cli 4.2.4] Preparing for CLI release #15027

Conversation

wrwg commented Oct 21, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Oct 21, 2024 • edited Loading

wrwg commented Oct 21, 2024

rahxephon89 commented Oct 21, 2024 • edited by brmataptos Loading

0xmaayan left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vineethk Oct 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 22, 2024

✅ Forge suite realistic_env_max_load success on eef61fa4491c0d1e6fcf663506561877f578d4e4

github-actions bot commented Oct 22, 2024

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> eef61fa4491c0d1e6fcf663506561877f578d4e4

github-actions bot commented Oct 22, 2024

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> eef61fa4491c0d1e6fcf663506561877f578d4e4

trunk-io bot commented Oct 21, 2024 •

edited

Loading

rahxephon89 commented Oct 21, 2024 •

edited by brmataptos

Loading

✅ Forge suite `realistic_env_max_load` success on `eef61fa4491c0d1e6fcf663506561877f578d4e4`

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `eef61fa4491c0d1e6fcf663506561877f578d4e4`

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `eef61fa4491c0d1e6fcf663506561877f578d4e4`