Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move examples] Add an example for a redemption contract for redeeming coins for fungible assets #15019

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

movekevin
Copy link
Contributor

Description

Add an example for a redemption contract for redeeming coins for fungible assets

How Has This Been Tested?

Unit tests

Key Areas to Review

Contract + Tests

Copy link

trunk-io bot commented Oct 19, 2024

⏱️ 2h 43m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-smoke-tests 27m 🟥
execution-performance / test-target-determinator 23m 🟩🟩🟩🟩🟩
test-target-determinator 15m 🟩🟩🟩
check 14m 🟩🟩🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-cargo-deny 9m 🟩🟩🟩 (+1 more)
rust-move-tests 8m 🟩
rust-move-tests 8m
fetch-last-released-docker-image-tag 7m 🟩🟩🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
general-lints 3m 🟩🟩🟩🟩🟩 (+1 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@Alexzander-Stone Alexzander-Stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Few nitpicks and a possible additional check during tests added.
Logic and utilized data structures look good to me.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7ccba601345f60d24419fd143ec7a681364f0182

two traffics test: inner traffic : committed: 14116.15 txn/s, latency: 2816.65 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5367280
two traffics test : committed: 100.09 txn/s, latency: 1944.72 ms, (p50: 1600 ms, p70: 2200, p90: 2400 ms, p99: 5900 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.618, avg: 1.124", "ConsensusProposalToOrdered: max: 0.333, avg: 0.300", "ConsensusOrderedToCommit: max: 0.379, avg: 0.368", "ConsensusProposalToCommit: max: 0.677, avg: 0.668"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.14s no progress at version 2653563 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.24s no progress at version 2653561 (avg 8.24s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7ccba601345f60d24419fd143ec7a681364f0182

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7ccba601345f60d24419fd143ec7a681364f0182 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 16636.96 txn/s, latency: 2041.36 ms, (p50: 2100 ms, p70: 2200, p90: 2400 ms, p99: 2700 ms), latency samples: 536000
2. Upgrading first Validator to new version: 7ccba601345f60d24419fd143ec7a681364f0182
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6555.70 txn/s, latency: 4314.57 ms, (p50: 5000 ms, p70: 5200, p90: 5300 ms, p99: 5400 ms), latency samples: 120460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6605.75 txn/s, latency: 4905.30 ms, (p50: 5300 ms, p70: 5400, p90: 5500 ms, p99: 5700 ms), latency samples: 223820
3. Upgrading rest of first batch to new version: 7ccba601345f60d24419fd143ec7a681364f0182
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5804.53 txn/s, latency: 5016.12 ms, (p50: 5700 ms, p70: 5900, p90: 6100 ms, p99: 6200 ms), latency samples: 112760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5986.76 txn/s, latency: 5408.36 ms, (p50: 5900 ms, p70: 6100, p90: 6200 ms, p99: 6300 ms), latency samples: 210620
4. upgrading second batch to new version: 7ccba601345f60d24419fd143ec7a681364f0182
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7917.21 txn/s, latency: 3592.30 ms, (p50: 3900 ms, p70: 4100, p90: 4500 ms, p99: 4800 ms), latency samples: 143600
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7644.12 txn/s, latency: 4150.95 ms, (p50: 4200 ms, p70: 4500, p90: 6100 ms, p99: 6600 ms), latency samples: 252760
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7ccba601345f60d24419fd143ec7a681364f0182 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants