Print local testnet logs as `println` and errors as `eprintln` #15005

0xmaayan · 2024-10-18T16:25:34Z

Description

The local testnet currently prints regular logs using eprintln, which is intended for error messages. Update the logs to use println for regular output and reserve eprintln for errors (such as Docker setup issues).

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-10-18T16:25:37Z

⏱️ 1h 26m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
forge-framework-upgrade-test / forge	21m	🟥 🟥
test-target-determinator	9m	🟩 🟩
execution-performance / test-target-determinator	9m	🟩 🟩
check	8m	🟩 🟩
rust-cargo-deny	7m	🟩 🟩 🟩 🟩
check-dynamic-deps	6m	🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
fetch-last-released-docker-image-tag	3m	🟩 🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩
general-lints	2m	🟩 🟩 🟩 🟩
rust-move-tests	2m	🟩
rust-move-tests	2m	🟩
rust-move-tests	1m	🟩
rust-move-tests	1m	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	10s	18m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

banool · 2024-10-18T16:28:59Z

crates/aptos/src/node/local_testnet/docker.rs

@@ -30,7 +30,8 @@ pub const CONTAINER_NETWORK_NAME: &str = "aptos-local-testnet-network";
 /// there no second location, there is just the one named pipe.
 pub async fn get_docker() -> Result<Docker> {
    let docker = Docker::connect_with_local_defaults()
-        .context(format!("{} (init_default)", ERROR_MESSAGE))?;
+        .context(format!("{} (init_default)", ERROR_MESSAGE))
+        .inspect_err(|e| eprintln!("{:#}", e))?;


Just confirming, you're happy for this to be spread across multiple lines? If not, you can just use {} instead of {:#}.

looks like it is one line?

Unexpected error: Failed to apply pre run steps for Postgres: Docker is not available, confirm it is installed and running. See https://aptos.dev/guides/local-development-network#faq for assistance. (version_home): error trying to connect: No such file or directory (os error 2): No such file or directory (os error 2)

gregnazario · 2024-10-18T16:40:14Z

Note: Probably add it to the changelog

0xmaayan · 2024-10-18T16:43:43Z

Update the logs to use println for regular output and reserve eprintln for errors

thanks. done

github-actions · 2024-10-18T18:24:04Z

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `addb198db275cffda72cc7c88df41571f1bbaabc`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> addb198db275cffda72cc7c88df41571f1bbaabc (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 13205.46 txn/s, latency: 2581.66 ms, (p50: 2200 ms, p70: 2400, p90: 3500 ms, p99: 8100 ms), latency samples: 427860
2. Upgrading first Validator to new version: addb198db275cffda72cc7c88df41571f1bbaabc
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7311.17 txn/s, latency: 3884.83 ms, (p50: 4400 ms, p70: 4700, p90: 4800 ms, p99: 4900 ms), latency samples: 133760
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6758.94 txn/s, latency: 4349.04 ms, (p50: 4700 ms, p70: 4800, p90: 5000 ms, p99: 5300 ms), latency samples: 253160
3. Upgrading rest of first batch to new version: addb198db275cffda72cc7c88df41571f1bbaabc
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7354.45 txn/s, latency: 3878.87 ms, (p50: 4300 ms, p70: 4600, p90: 4800 ms, p99: 4800 ms), latency samples: 138100
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6590.61 txn/s, latency: 4904.93 ms, (p50: 4800 ms, p70: 5100, p90: 7000 ms, p99: 7300 ms), latency samples: 229520
4. upgrading second batch to new version: addb198db275cffda72cc7c88df41571f1bbaabc
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9455.47 txn/s, latency: 2856.48 ms, (p50: 2900 ms, p70: 3000, p90: 4400 ms, p99: 4800 ms), latency samples: 188220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10048.83 txn/s, latency: 3089.82 ms, (p50: 2800 ms, p70: 2900, p90: 5800 ms, p99: 7400 ms), latency samples: 325800
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> addb198db275cffda72cc7c88df41571f1bbaabc passed
Test Ok

github-actions · 2024-10-18T18:25:12Z

✅ Forge suite `realistic_env_max_load` success on `addb198db275cffda72cc7c88df41571f1bbaabc`

two traffics test: inner traffic : committed: 14037.43 txn/s, submitted: 14038.11 txn/s, expired: 0.68 txn/s, latency: 2825.99 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5337340
two traffics test : committed: 100.11 txn/s, latency: 1634.15 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 11200 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.246, avg: 0.226", "QsPosToProposal: max: 1.170, avg: 1.121", "ConsensusProposalToOrdered: max: 0.317, avg: 0.298", "ConsensusOrderedToCommit: max: 0.492, avg: 0.469", "ConsensusProposalToCommit: max: 0.790, avg: 0.767"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.06s no progress at version 2384061 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.54s no progress at version 2384059 (avg 8.54s) [limit 15].
Test Ok

github-actions · 2024-10-18T18:27:11Z

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `addb198db275cffda72cc7c88df41571f1bbaabc`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> addb198db275cffda72cc7c88df41571f1bbaabc (PR)
Upgrade the nodes to version: addb198db275cffda72cc7c88df41571f1bbaabc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1183.22 txn/s, submitted: 1184.34 txn/s, failed submission: 1.12 txn/s, expired: 1.12 txn/s, latency: 2518.71 ms, (p50: 2100 ms, p70: 2400, p90: 5100 ms, p99: 7200 ms), latency samples: 105580
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1148.27 txn/s, submitted: 1149.68 txn/s, failed submission: 1.41 txn/s, expired: 1.41 txn/s, latency: 2781.19 ms, (p50: 2400 ms, p70: 3000, p90: 4800 ms, p99: 6900 ms), latency samples: 97700
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> addb198db275cffda72cc7c88df41571f1bbaabc passed
Upgrade the remaining nodes to version: addb198db275cffda72cc7c88df41571f1bbaabc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1049.47 txn/s, submitted: 1051.02 txn/s, failed submission: 1.55 txn/s, expired: 1.55 txn/s, latency: 2864.95 ms, (p50: 2400 ms, p70: 3200, p90: 4800 ms, p99: 6700 ms), latency samples: 94920
Test Ok

0xmaayan requested review from gregnazario and banool as code owners October 18, 2024 16:25

banool approved these changes Oct 18, 2024

View reviewed changes

gregnazario approved these changes Oct 18, 2024

View reviewed changes

print local testnet log as println and errors as eprintln

f6988a0

0xmaayan force-pushed the maayan/log_errors_as_eprintln branch from b65c2c9 to f6988a0 Compare October 18, 2024 16:43

0xmaayan mentioned this pull request Oct 18, 2024

Do not ignore stderr when stdout is disabled aptos-labs/aptos-ts-sdk#547

Merged

1 task

0xmaayan enabled auto-merge (squash) October 18, 2024 16:54

This comment has been minimized.

Sign in to view

Merge branch 'main' into maayan/log_errors_as_eprintln

addb198

This comment has been minimized.

Sign in to view

0xmaayan merged commit 20ba96d into main Oct 18, 2024
48 checks passed

0xmaayan deleted the maayan/log_errors_as_eprintln branch October 18, 2024 18:27

This was referenced Oct 22, 2024

[aptos-workspace-server] service-startup using shared futures #15046

Merged

Update cli command to use println instead of eprintln for informational logs #15050

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print local testnet logs as `println` and errors as `eprintln` #15005

Print local testnet logs as `println` and errors as `eprintln` #15005

0xmaayan commented Oct 18, 2024

trunk-io bot commented Oct 18, 2024 •

edited

Loading

banool Oct 18, 2024

0xmaayan Oct 18, 2024

gregnazario commented Oct 18, 2024

0xmaayan commented Oct 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

Print local testnet logs as println and errors as eprintln #15005

Print local testnet logs as println and errors as eprintln #15005

Conversation

0xmaayan commented Oct 18, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Oct 18, 2024 • edited Loading

banool Oct 18, 2024

Choose a reason for hiding this comment

0xmaayan Oct 18, 2024

Choose a reason for hiding this comment

gregnazario commented Oct 18, 2024

0xmaayan commented Oct 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 18, 2024

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> addb198db275cffda72cc7c88df41571f1bbaabc

github-actions bot commented Oct 18, 2024

✅ Forge suite realistic_env_max_load success on addb198db275cffda72cc7c88df41571f1bbaabc

github-actions bot commented Oct 18, 2024

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> addb198db275cffda72cc7c88df41571f1bbaabc

Print local testnet logs as `println` and errors as `eprintln` #15005

Print local testnet logs as `println` and errors as `eprintln` #15005

trunk-io bot commented Oct 18, 2024 •

edited

Loading

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `addb198db275cffda72cc7c88df41571f1bbaabc`

✅ Forge suite `realistic_env_max_load` success on `addb198db275cffda72cc7c88df41571f1bbaabc`

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `addb198db275cffda72cc7c88df41571f1bbaabc`