Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out disabled fuzzers to prevent them from appearing in the list #14994

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

zi0Black
Copy link
Contributor

Description

Workaround since cargo fuzz list return all the bins in the cargo toml.

How Has This Been Tested?

N/A

Key Areas to Review

N/A

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@zi0Black zi0Black requested review from gedigi and GotenJBZ October 17, 2024 11:22
Copy link

trunk-io bot commented Oct 17, 2024

⏱️ 39m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 5m 🟩
check 4m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
check-dynamic-deps 2m 🟩🟩🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 2m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 35s 🟩🟩🟩
file_change_determinator 14s 🟩
execution-performance / single-node-performance 12s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 12s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zi0Black zi0Black enabled auto-merge (squash) October 17, 2024 13:16

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 10243.41 txn/s, latency: 2860.77 ms, (p50: 1900 ms, p70: 2100, p90: 2700 ms, p99: 27800 ms), latency samples: 472480
2. Upgrading first Validator to new version: 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6006.09 txn/s, latency: 4675.73 ms, (p50: 5200 ms, p70: 5700, p90: 5900 ms, p99: 5900 ms), latency samples: 112200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5276.43 txn/s, latency: 5866.96 ms, (p50: 6300 ms, p70: 6400, p90: 6500 ms, p99: 7700 ms), latency samples: 196360
3. Upgrading rest of first batch to new version: 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7084.81 txn/s, latency: 4003.74 ms, (p50: 4600 ms, p70: 4700, p90: 5000 ms, p99: 5100 ms), latency samples: 130460
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6390.79 txn/s, latency: 5085.89 ms, (p50: 5000 ms, p70: 5300, p90: 7200 ms, p99: 7400 ms), latency samples: 229780
4. upgrading second batch to new version: 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11412.03 txn/s, latency: 2399.72 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 201680
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11239.13 txn/s, latency: 2783.43 ms, (p50: 2600 ms, p70: 2700, p90: 4600 ms, p99: 5800 ms), latency samples: 363260
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e

two traffics test: inner traffic : committed: 13611.27 txn/s, submitted: 13614.79 txn/s, expired: 3.52 txn/s, latency: 2891.88 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 6300 ms), latency samples: 5175320
two traffics test : committed: 100.07 txn/s, latency: 1963.55 ms, (p50: 1500 ms, p70: 1600, p90: 2100 ms, p99: 10700 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.244, avg: 0.227", "QsPosToProposal: max: 1.177, avg: 1.105", "ConsensusProposalToOrdered: max: 0.323, avg: 0.306", "ConsensusOrderedToCommit: max: 0.511, avg: 0.484", "ConsensusProposalToCommit: max: 0.812, avg: 0.790"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.17s no progress at version 5702982 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.36s no progress at version 1591828 (avg 8.23s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e (PR)
Upgrade the nodes to version: 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1233.21 txn/s, submitted: 1236.77 txn/s, failed submission: 3.56 txn/s, expired: 3.56 txn/s, latency: 2365.94 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5100 ms), latency samples: 110980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1191.73 txn/s, submitted: 1194.00 txn/s, failed submission: 2.27 txn/s, expired: 2.27 txn/s, latency: 2591.75 ms, (p50: 2400 ms, p70: 3000, p90: 4200 ms, p99: 5400 ms), latency samples: 104900
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e passed
Upgrade the remaining nodes to version: 7de8f5dab87b76f50bf5d8e2f8e0b69e38d56c9e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1166.86 txn/s, submitted: 1169.08 txn/s, failed submission: 2.22 txn/s, expired: 2.22 txn/s, latency: 2593.72 ms, (p50: 2400 ms, p70: 2900, p90: 4000 ms, p99: 6000 ms), latency samples: 104920
Test Ok

@zi0Black zi0Black merged commit a7f73c0 into main Oct 17, 2024
92 checks passed
@zi0Black zi0Black deleted the oss-fuzz-build branch October 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants