Group DB commit paramenters to ChunkToCommit

[msmouse]

Description

Consolidate db commit call sites, preparing for further refactors.

How Has This Been Tested?

existing coverrage

Key Areas to Review

Type of Change

• Refactoring

Which Components or Systems Does This Change Impact?

• Validator Node

[trunk-io]

⏱️ 7h 36m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	3h 26m	🟥 🟩 🟩 🟩 🟩 (+4 more)
execution-performance / test-target-determinator	40m	🟩 🟩 🟩 🟩 🟩 (+4 more)
test-target-determinator	30m	⬜ ⬜ 🟩 🟩 🟩 (+4 more)
check	27m	⬜ ⬜ 🟩 🟩 🟩 (+4 more)
forge-e2e-test / forge	23m	🟩
rust-cargo-deny	14m	🟩 ⬜ 🟩 🟩 🟩 (+5 more)
fetch-last-released-docker-image-tag	13m	🟩 ⬜ 🟩 🟩 🟩 (+4 more)
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
check-dynamic-deps	9m	🟩 🟩 🟩 🟩 🟩 (+5 more)
rust-move-tests	9m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
general-lints	5m	🟩 🟩 🟩 🟩 🟩 (+5 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	24m	18m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> e9b4cd0f294137a5145f125d70c68244b63a4f1c

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> e9b4cd0f294137a5145f125d70c68244b63a4f1c (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 11340.55 txn/s, latency: 2916.31 ms, (p50: 2400 ms, p70: 2900, p90: 5300 ms, p99: 8200 ms), latency samples: 380620
2. Upgrading first Validator to new version: e9b4cd0f294137a5145f125d70c68244b63a4f1c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6279.58 txn/s, latency: 4268.81 ms, (p50: 4600 ms, p70: 4800, p90: 5700 ms, p99: 5900 ms), latency samples: 131000
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6930.66 txn/s, latency: 4466.97 ms, (p50: 4400 ms, p70: 4600, p90: 7000 ms, p99: 7300 ms), latency samples: 236760
3. Upgrading rest of first batch to new version: e9b4cd0f294137a5145f125d70c68244b63a4f1c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7518.05 txn/s, latency: 3776.95 ms, (p50: 4200 ms, p70: 4400, p90: 4600 ms, p99: 4800 ms), latency samples: 140440
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6615.20 txn/s, latency: 4853.14 ms, (p50: 4800 ms, p70: 5000, p90: 7100 ms, p99: 7300 ms), latency samples: 223300
4. upgrading second batch to new version: e9b4cd0f294137a5145f125d70c68244b63a4f1c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9379.85 txn/s, latency: 2784.47 ms, (p50: 2400 ms, p70: 3000, p90: 5000 ms, p99: 6700 ms), latency samples: 201260
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9717.63 txn/s, latency: 3172.82 ms, (p50: 2600 ms, p70: 3000, p90: 6900 ms, p99: 9000 ms), latency samples: 321100
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> e9b4cd0f294137a5145f125d70c68244b63a4f1c passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on e9b4cd0f294137a5145f125d70c68244b63a4f1c

two traffics test: inner traffic : committed: 12420.52 txn/s, submitted: 12423.15 txn/s, expired: 2.63 txn/s, latency: 3195.87 ms, (p50: 3000 ms, p70: 3300, p90: 3300 ms, p99: 4800 ms), latency samples: 4722540
two traffics test : committed: 99.97 txn/s, latency: 1504.99 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 2900 ms), latency samples: 1940
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.254, avg: 0.231", "QsPosToProposal: max: 1.543, avg: 1.436", "ConsensusProposalToOrdered: max: 0.334, avg: 0.322", "ConsensusOrderedToCommit: max: 0.445, avg: 0.434", "ConsensusProposalToCommit: max: 0.775, avg: 0.756"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.78s no progress at version 2386410 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.49s no progress at version 2386408 (avg 4.16s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> e9b4cd0f294137a5145f125d70c68244b63a4f1c

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> e9b4cd0f294137a5145f125d70c68244b63a4f1c (PR)
Upgrade the nodes to version: e9b4cd0f294137a5145f125d70c68244b63a4f1c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1187.25 txn/s, submitted: 1189.08 txn/s, failed submission: 1.83 txn/s, expired: 1.83 txn/s, latency: 2598.99 ms, (p50: 2100 ms, p70: 2400, p90: 4700 ms, p99: 7600 ms), latency samples: 103540
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1034.51 txn/s, submitted: 1036.29 txn/s, failed submission: 1.78 txn/s, expired: 1.78 txn/s, latency: 2875.94 ms, (p50: 2700 ms, p70: 3000, p90: 5100 ms, p99: 6500 ms), latency samples: 92780
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> e9b4cd0f294137a5145f125d70c68244b63a4f1c passed
Upgrade the remaining nodes to version: e9b4cd0f294137a5145f125d70c68244b63a4f1c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1007.34 txn/s, submitted: 1010.26 txn/s, failed submission: 2.91 txn/s, expired: 2.91 txn/s, latency: 2980.43 ms, (p50: 2700 ms, p70: 3200, p90: 4600 ms, p99: 6400 ms), latency samples: 89880
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking