Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml to enable new storage format by default. #14981

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

grao1991
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 16, 2024

⏱️ 48m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
check-dynamic-deps 10m 🟩🟩🟩🟩🟩
rust-cargo-deny 6m 🟩🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
rust-move-tests 2m 🟩
general-lints 2m 🟩🟩🟩🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
rust-move-tests 1m
file_change_determinator 59s 🟩🟩🟩🟩🟩
rust-move-tests 58s
permission-check 15s 🟩🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@grao1991 grao1991 marked this pull request as ready for review October 16, 2024 19:18
@grao1991 grao1991 requested a review from a team as a code owner October 16, 2024 19:18
@sherry-x sherry-x enabled auto-merge (rebase) October 16, 2024 19:22

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 6599ac28ad2b79d294cd6f0cbe490bd1b131acd6

two traffics test: inner traffic : committed: 13734.42 txn/s, submitted: 13735.58 txn/s, expired: 1.16 txn/s, latency: 2898.19 ms, (p50: 2400 ms, p70: 2700, p90: 3800 ms, p99: 11400 ms), latency samples: 5222240
two traffics test : committed: 99.98 txn/s, latency: 2514.98 ms, (p50: 1500 ms, p70: 1700, p90: 5200 ms, p99: 13500 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.236, avg: 0.217", "QsPosToProposal: max: 0.927, avg: 0.767", "ConsensusProposalToOrdered: max: 0.324, avg: 0.303", "ConsensusOrderedToCommit: max: 0.488, avg: 0.472", "ConsensusProposalToCommit: max: 0.806, avg: 0.775"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.90s no progress at version 2495412 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.63s no progress at version 2495410 (avg 7.63s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6599ac28ad2b79d294cd6f0cbe490bd1b131acd6

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6599ac28ad2b79d294cd6f0cbe490bd1b131acd6 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 12821.79 txn/s, latency: 2531.91 ms, (p50: 1900 ms, p70: 2200, p90: 5200 ms, p99: 9600 ms), latency samples: 439020
2. Upgrading first Validator to new version: 6599ac28ad2b79d294cd6f0cbe490bd1b131acd6
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5598.07 txn/s, latency: 5163.20 ms, (p50: 5800 ms, p70: 6300, p90: 6500 ms, p99: 6600 ms), latency samples: 105000
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5265.50 txn/s, latency: 5971.31 ms, (p50: 6400 ms, p70: 6600, p90: 7500 ms, p99: 8100 ms), latency samples: 199720
3. Upgrading rest of first batch to new version: 6599ac28ad2b79d294cd6f0cbe490bd1b131acd6
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6555.20 txn/s, latency: 4199.95 ms, (p50: 4600 ms, p70: 4800, p90: 5400 ms, p99: 5800 ms), latency samples: 133680
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6583.04 txn/s, latency: 4884.34 ms, (p50: 4900 ms, p70: 5400, p90: 7300 ms, p99: 7700 ms), latency samples: 223680
4. upgrading second batch to new version: 6599ac28ad2b79d294cd6f0cbe490bd1b131acd6
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11447.84 txn/s, latency: 2387.49 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3000 ms), latency samples: 197100
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11696.34 txn/s, latency: 2659.55 ms, (p50: 2600 ms, p70: 2700, p90: 3000 ms, p99: 3400 ms), latency samples: 376620
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6599ac28ad2b79d294cd6f0cbe490bd1b131acd6 passed
Test Ok

@sherry-x sherry-x merged commit b8b116f into main Oct 16, 2024
89 of 92 checks passed
@sherry-x sherry-x deleted the grao1991-patch-1 branch October 16, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants