Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rosetta] Remove supported currencies with an empty symbol #14973

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

gregnazario
Copy link
Contributor

Description

Removes poorly formatted currencies, with a warning on startup of Rosetta.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 16, 2024

⏱️ 39m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check-dynamic-deps 4m 🟩🟩🟩
test-target-determinator 4m 🟩
check 4m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
rust-move-tests 2m 🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 34s 🟩🟩🟩
file_change_determinator 14s 🟩
execution-performance / single-node-performance 10s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

crates/aptos-rosetta/src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@GhostWalker562 GhostWalker562 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gregnazario gregnazario enabled auto-merge (squash) October 16, 2024 22:42

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 16b668a779c5c43dcd4ad6e0b0f49b6a4f8d9f9c

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 16b668a779c5c43dcd4ad6e0b0f49b6a4f8d9f9c (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 13348.90 txn/s, latency: 2518.79 ms, (p50: 2100 ms, p70: 2200, p90: 5900 ms, p99: 10800 ms), latency samples: 435860
2. Upgrading first Validator to new version: 16b668a779c5c43dcd4ad6e0b0f49b6a4f8d9f9c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7075.38 txn/s, latency: 3967.22 ms, (p50: 4200 ms, p70: 4500, p90: 5500 ms, p99: 5800 ms), latency samples: 130520
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7352.79 txn/s, latency: 4393.79 ms, (p50: 4500 ms, p70: 4800, p90: 6200 ms, p99: 6500 ms), latency samples: 246580
3. Upgrading rest of first batch to new version: 16b668a779c5c43dcd4ad6e0b0f49b6a4f8d9f9c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6784.87 txn/s, latency: 4096.86 ms, (p50: 4500 ms, p70: 4700, p90: 5300 ms, p99: 5400 ms), latency samples: 143640
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7214.79 txn/s, latency: 4478.70 ms, (p50: 4500 ms, p70: 4900, p90: 6400 ms, p99: 6500 ms), latency samples: 244620
4. upgrading second batch to new version: 16b668a779c5c43dcd4ad6e0b0f49b6a4f8d9f9c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10469.09 txn/s, latency: 2570.97 ms, (p50: 2700 ms, p70: 3000, p90: 3200 ms, p99: 3400 ms), latency samples: 187220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10450.44 txn/s, latency: 2931.09 ms, (p50: 2700 ms, p70: 2900, p90: 5000 ms, p99: 6500 ms), latency samples: 346160
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 16b668a779c5c43dcd4ad6e0b0f49b6a4f8d9f9c passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 16b668a779c5c43dcd4ad6e0b0f49b6a4f8d9f9c

two traffics test: inner traffic : committed: 13874.98 txn/s, submitted: 13877.61 txn/s, expired: 2.63 txn/s, latency: 2857.72 ms, (p50: 2400 ms, p70: 2600, p90: 3000 ms, p99: 17100 ms), latency samples: 5275900
two traffics test : committed: 100.02 txn/s, latency: 3080.76 ms, (p50: 1500 ms, p70: 1900, p90: 6400 ms, p99: 20500 ms), latency samples: 2000
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.235, avg: 0.220", "QsPosToProposal: max: 0.683, avg: 0.561", "ConsensusProposalToOrdered: max: 0.331, avg: 0.304", "ConsensusOrderedToCommit: max: 0.524, avg: 0.489", "ConsensusProposalToCommit: max: 0.825, avg: 0.793"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.85s no progress at version 2466462 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.27s no progress at version 2466460 (avg 5.19s) [limit 15].
Test Ok

@gregnazario gregnazario merged commit c8511eb into aptos-labs:main Oct 16, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants