Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect Domain Reference in RUST_SECURE_CODING.md #14956

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

meetrick
Copy link
Contributor

Updated the incorrect domain reference from create.io to crates.io in the “Rustup” section. This ensures the correct Rust package management site is referenced for security considerations.

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Updated the incorrect domain reference from create.io to crates.io
in the “Rustup” section. This ensures the correct Rust package
management site is referenced for security considerations.

Signed-off-by: Hwangjae Lee <[email protected]>
Copy link

trunk-io bot commented Oct 14, 2024

⏱️ 32m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 56s 🟩🟩
semgrep/ci 50s 🟩🟩
file_change_determinator 28s 🟩🟩
permission-check 17s 🟥🟥🟩🟩
permission-check 12s 🟥🟥🟩🟩
file_change_determinator 11s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 19m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@JoshLind JoshLind requested review from gedigi, a team and zi0Black October 15, 2024 18:20
Copy link
Contributor

@JoshLind JoshLind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @meetrick 😄

@gedigi gedigi added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Oct 15, 2024
@gedigi gedigi enabled auto-merge (squash) October 15, 2024 18:56

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 7eeba4cd15892717741a614add1afde004c7855f ==> 774d3a2d8a0f1f736976d9800b99166628b82a6b

Compatibility test results for 7eeba4cd15892717741a614add1afde004c7855f ==> 774d3a2d8a0f1f736976d9800b99166628b82a6b (PR)
1. Check liveness of validators at old version: 7eeba4cd15892717741a614add1afde004c7855f
compatibility::simple-validator-upgrade::liveness-check : committed: 10701.98 txn/s, latency: 3109.95 ms, (p50: 2000 ms, p70: 2200, p90: 8600 ms, p99: 20300 ms), latency samples: 347720
2. Upgrading first Validator to new version: 774d3a2d8a0f1f736976d9800b99166628b82a6b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6956.58 txn/s, latency: 4031.70 ms, (p50: 4600 ms, p70: 4800, p90: 5000 ms, p99: 5100 ms), latency samples: 128060
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6598.92 txn/s, latency: 4839.79 ms, (p50: 4800 ms, p70: 5100, p90: 7500 ms, p99: 7800 ms), latency samples: 234360
3. Upgrading rest of first batch to new version: 774d3a2d8a0f1f736976d9800b99166628b82a6b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7340.84 txn/s, latency: 3873.91 ms, (p50: 4300 ms, p70: 4500, p90: 4800 ms, p99: 4900 ms), latency samples: 136500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6944.50 txn/s, latency: 4678.99 ms, (p50: 5100 ms, p70: 5300, p90: 5500 ms, p99: 5500 ms), latency samples: 233180
4. upgrading second batch to new version: 774d3a2d8a0f1f736976d9800b99166628b82a6b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 2130.04 txn/s, latency: 14100.36 ms, (p50: 13500 ms, p70: 14100, p90: 16200 ms, p99: 17400 ms), latency samples: 40000
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10214.17 txn/s, latency: 3040.45 ms, (p50: 3100 ms, p70: 3200, p90: 3700 ms, p99: 4600 ms), latency samples: 333900
5. check swarm health
Compatibility test for 7eeba4cd15892717741a614add1afde004c7855f ==> 774d3a2d8a0f1f736976d9800b99166628b82a6b passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 774d3a2d8a0f1f736976d9800b99166628b82a6b

two traffics test: inner traffic : committed: 13615.27 txn/s, latency: 2921.46 ms, (p50: 2700 ms, p70: 3000, p90: 3200 ms, p99: 3600 ms), latency samples: 5176820
two traffics test : committed: 99.90 txn/s, latency: 2857.01 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 10300 ms), latency samples: 1680
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.230, avg: 0.218", "QsPosToProposal: max: 0.285, avg: 0.246", "ConsensusProposalToOrdered: max: 0.320, avg: 0.299", "ConsensusOrderedToCommit: max: 0.466, avg: 0.449", "ConsensusProposalToCommit: max: 0.768, avg: 0.748"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.94s no progress at version 2808120 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.17s no progress at version 2808118 (avg 8.17s) [limit 15].
Test Ok

@gedigi gedigi merged commit 3a77c22 into aptos-labs:main Oct 15, 2024
99 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants