Refactor: StateComputeResult carries full execution result

[msmouse]

Description

Avoids cloning.

How Has This Been Tested?

existing coverage

Key Areas to Review

Type of Change

• Refactoring

Which Components or Systems Does This Change Impact?

• Validator Node

[trunk-io]

⏱️ 11h 33m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	4h 15m	🟩 🟩 🟩 🟩 🟩 (+9 more)
execution-performance / test-target-determinator	1h 1m	🟩 🟩 🟩 🟩 🟩 (+9 more)
test-target-determinator	59m	🟩 🟩 🟩 🟩 🟩 (+9 more)
check	49m	🟩 🟩 🟩 🟩 🟩 (+9 more)
rust-cargo-deny	25m	🟩 🟩 🟩 🟩 🟩 (+9 more)
fetch-last-released-docker-image-tag	22m	🟩 🟩 🟩 🟩 🟩 (+9 more)
dispatch_event	18m	🟩
check-dynamic-deps	12m	🟩 🟩 🟩 🟩 🟩 (+10 more)
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on 707b11b12b36f45dacab5d7bb2930398539dfb62

two traffics test: inner traffic : committed: 13865.47 txn/s, latency: 2888.96 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 12300 ms), latency samples: 5272080
two traffics test : committed: 100.00 txn/s, latency: 4452.31 ms, (p50: 2500 ms, p70: 2700, p90: 6100 ms, p99: 43200 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.238, avg: 0.217", "QsPosToProposal: max: 0.604, avg: 0.521", "ConsensusProposalToOrdered: max: 0.320, avg: 0.300", "ConsensusOrderedToCommit: max: 0.476, avg: 0.453", "ConsensusProposalToCommit: max: 0.779, avg: 0.753"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 2842090 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.39s no progress at version 2842088 (avg 8.39s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 707b11b12b36f45dacab5d7bb2930398539dfb62

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 707b11b12b36f45dacab5d7bb2930398539dfb62 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 12733.94 txn/s, latency: 2689.22 ms, (p50: 1900 ms, p70: 2100, p90: 2700 ms, p99: 24700 ms), latency samples: 498580
2. Upgrading first Validator to new version: 707b11b12b36f45dacab5d7bb2930398539dfb62
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7722.60 txn/s, latency: 3748.90 ms, (p50: 4100 ms, p70: 4300, p90: 4500 ms, p99: 4600 ms), latency samples: 146100
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6417.22 txn/s, latency: 4732.54 ms, (p50: 4900 ms, p70: 5100, p90: 5100 ms, p99: 6800 ms), latency samples: 241660
3. Upgrading rest of first batch to new version: 707b11b12b36f45dacab5d7bb2930398539dfb62
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7212.99 txn/s, latency: 3905.63 ms, (p50: 4300 ms, p70: 4500, p90: 4800 ms, p99: 5000 ms), latency samples: 134740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7324.69 txn/s, latency: 4364.32 ms, (p50: 4600 ms, p70: 4900, p90: 6100 ms, p99: 6300 ms), latency samples: 248460
4. upgrading second batch to new version: 707b11b12b36f45dacab5d7bb2930398539dfb62
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11137.48 txn/s, latency: 2446.81 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3100 ms), latency samples: 194080
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10565.60 txn/s, latency: 2941.00 ms, (p50: 2900 ms, p70: 3000, p90: 3500 ms, p99: 4200 ms), latency samples: 350440
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 707b11b12b36f45dacab5d7bb2930398539dfb62 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 707b11b12b36f45dacab5d7bb2930398539dfb62

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 707b11b12b36f45dacab5d7bb2930398539dfb62 (PR)
Upgrade the nodes to version: 707b11b12b36f45dacab5d7bb2930398539dfb62
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1240.88 txn/s, submitted: 1242.97 txn/s, failed submission: 2.09 txn/s, expired: 2.09 txn/s, latency: 2518.04 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5100 ms), latency samples: 106820
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1202.40 txn/s, submitted: 1205.05 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2480.40 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 6600 ms), latency samples: 108840
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 707b11b12b36f45dacab5d7bb2930398539dfb62 passed
Upgrade the remaining nodes to version: 707b11b12b36f45dacab5d7bb2930398539dfb62
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1226.03 txn/s, submitted: 1229.05 txn/s, failed submission: 3.02 txn/s, expired: 3.02 txn/s, latency: 2541.40 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5600 ms), latency samples: 105640
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking