[Compiler-v2] add tests for break/continue in lambda #14943

rahxephon89 · 2024-10-11T19:56:26Z

Description

This PR adds test cases on break/continue in lambda to show difference between V1 and V2 compiler.

Related issue: #14944

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-10-11T19:56:30Z

⏱️ 2h 24m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	42m	🟩 🟩
dispatch_event	18m	🟩
rust-move-unit-coverage	16m	🟩
rust-move-unit-coverage	15m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
execution-performance / test-target-determinator	9m	🟩 🟩
rust-doc-tests	5m	🟩
test-target-determinator	4m	🟩
check	4m	⬜ 🟩
rust-cargo-deny	3m	🟩 🟩
check-dynamic-deps	3m	🟩 🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩
semgrep/ci	1m	🟩 🟩 🟩
general-lints	53s	🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

rahxephon89 · 2024-10-11T19:56:45Z

[Compiler-v2] add tests for break/continue in lambda #14943 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rahxephon89 and the rest of your teammates on Graphite

codecov · 2024-10-11T20:14:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.1%. Comparing base (05bacdf) to head (d83efaa).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (05bacdf) and HEAD (d83efaa). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (05bacdf) HEAD (d83efaa)

2 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #14943       +/-   ##
===========================================
- Coverage    71.8%    60.1%    -11.8%     
===========================================
  Files        2409      856     -1553     
  Lines      490324   211020   -279304     
===========================================
- Hits       352093   126831   -225262     
+ Misses     138231    84189    -54042

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-10-13T17:59:28Z

✅ Forge suite `realistic_env_max_load` success on `d83efaa7699aaa39c3c760ea422d3344fc9034a0`

two traffics test: inner traffic : committed: 13571.09 txn/s, latency: 2930.51 ms, (p50: 2700 ms, p70: 3000, p90: 3100 ms, p99: 3600 ms), latency samples: 5160140
two traffics test : committed: 100.00 txn/s, latency: 2595.73 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 7100 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.234, avg: 0.220", "QsPosToProposal: max: 0.295, avg: 0.231", "ConsensusProposalToOrdered: max: 0.327, avg: 0.301", "ConsensusOrderedToCommit: max: 0.489, avg: 0.460", "ConsensusProposalToCommit: max: 0.787, avg: 0.761"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 2655489 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.18s no progress at version 2655487 (avg 8.18s) [limit 15].
Test Ok

github-actions · 2024-10-13T17:59:58Z

✅ Forge suite `compat` success on `7eeba4cd15892717741a614add1afde004c7855f` ==> `d83efaa7699aaa39c3c760ea422d3344fc9034a0`

Compatibility test results for 7eeba4cd15892717741a614add1afde004c7855f ==> d83efaa7699aaa39c3c760ea422d3344fc9034a0 (PR)
1. Check liveness of validators at old version: 7eeba4cd15892717741a614add1afde004c7855f
compatibility::simple-validator-upgrade::liveness-check : committed: 12390.79 txn/s, latency: 2697.65 ms, (p50: 1900 ms, p70: 2200, p90: 6400 ms, p99: 18500 ms), latency samples: 409200
2. Upgrading first Validator to new version: d83efaa7699aaa39c3c760ea422d3344fc9034a0
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5609.61 txn/s, latency: 5159.09 ms, (p50: 5700 ms, p70: 6500, p90: 6900 ms, p99: 7100 ms), latency samples: 107460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4876.11 txn/s, latency: 6762.72 ms, (p50: 7100 ms, p70: 7300, p90: 8700 ms, p99: 9500 ms), latency samples: 173760
3. Upgrading rest of first batch to new version: d83efaa7699aaa39c3c760ea422d3344fc9034a0
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6171.28 txn/s, latency: 4456.74 ms, (p50: 5000 ms, p70: 5200, p90: 5600 ms, p99: 6100 ms), latency samples: 125880
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6977.09 txn/s, latency: 4614.53 ms, (p50: 4700 ms, p70: 4900, p90: 6700 ms, p99: 7000 ms), latency samples: 238660
4. upgrading second batch to new version: d83efaa7699aaa39c3c760ea422d3344fc9034a0
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12139.77 txn/s, latency: 2240.76 ms, (p50: 2400 ms, p70: 2500, p90: 2700 ms, p99: 3000 ms), latency samples: 211500
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11694.50 txn/s, latency: 2678.85 ms, (p50: 2500 ms, p70: 2700, p90: 3300 ms, p99: 5200 ms), latency samples: 377460
5. check swarm health
Compatibility test for 7eeba4cd15892717741a614add1afde004c7855f ==> d83efaa7699aaa39c3c760ea422d3344fc9034a0 passed
Test Ok

github-actions · 2024-10-13T18:00:55Z

✅ Forge suite `framework_upgrade` success on `7eeba4cd15892717741a614add1afde004c7855f` ==> `d83efaa7699aaa39c3c760ea422d3344fc9034a0`

Compatibility test results for 7eeba4cd15892717741a614add1afde004c7855f ==> d83efaa7699aaa39c3c760ea422d3344fc9034a0 (PR)
Upgrade the nodes to version: d83efaa7699aaa39c3c760ea422d3344fc9034a0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1243.99 txn/s, submitted: 1246.41 txn/s, failed submission: 2.42 txn/s, expired: 2.42 txn/s, latency: 2372.29 ms, (p50: 2100 ms, p70: 2700, p90: 3300 ms, p99: 5400 ms), latency samples: 113040
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1172.17 txn/s, submitted: 1174.68 txn/s, failed submission: 2.51 txn/s, expired: 2.51 txn/s, latency: 2598.93 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5700 ms), latency samples: 102580
5. check swarm health
Compatibility test for 7eeba4cd15892717741a614add1afde004c7855f ==> d83efaa7699aaa39c3c760ea422d3344fc9034a0 passed
Upgrade the remaining nodes to version: d83efaa7699aaa39c3c760ea422d3344fc9034a0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1259.57 txn/s, submitted: 1261.39 txn/s, failed submission: 1.82 txn/s, expired: 1.82 txn/s, latency: 2441.97 ms, (p50: 2100 ms, p70: 2600, p90: 3900 ms, p99: 6200 ms), latency samples: 111020
Test Ok

add tests

6b93926

rahxephon89 changed the title ~~add tests~~ [Compiler-v2] add tests for break/continue in lambda Oct 11, 2024

rahxephon89 requested a review from brmataptos October 11, 2024 19:59

rahxephon89 marked this pull request as ready for review October 11, 2024 20:00

brmataptos approved these changes Oct 11, 2024

View reviewed changes

rahxephon89 requested review from vineethk and wrwg October 11, 2024 20:09

rahxephon89 requested a review from fEst1ck October 12, 2024 03:57

wrwg approved these changes Oct 13, 2024

View reviewed changes

rahxephon89 enabled auto-merge (squash) October 13, 2024 17:31

Merge branch 'main' into teng/lambda-break-continue-bug

d83efaa

This comment has been minimized.

Sign in to view

rahxephon89 merged commit 6353f46 into main Oct 13, 2024
51 checks passed

rahxephon89 deleted the teng/lambda-break-continue-bug branch October 13, 2024 18:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Compiler-v2] add tests for break/continue in lambda #14943

[Compiler-v2] add tests for break/continue in lambda #14943

rahxephon89 commented Oct 11, 2024 •

edited

Loading

trunk-io bot commented Oct 11, 2024 •

edited

Loading

rahxephon89 commented Oct 11, 2024

codecov bot commented Oct 11, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 13, 2024

github-actions bot commented Oct 13, 2024

github-actions bot commented Oct 13, 2024

[Compiler-v2] add tests for break/continue in lambda #14943

[Compiler-v2] add tests for break/continue in lambda #14943

Conversation

rahxephon89 commented Oct 11, 2024 • edited Loading

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Oct 11, 2024 • edited Loading

rahxephon89 commented Oct 11, 2024

codecov bot commented Oct 11, 2024 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 13, 2024

✅ Forge suite realistic_env_max_load success on d83efaa7699aaa39c3c760ea422d3344fc9034a0

github-actions bot commented Oct 13, 2024

✅ Forge suite compat success on 7eeba4cd15892717741a614add1afde004c7855f ==> d83efaa7699aaa39c3c760ea422d3344fc9034a0

github-actions bot commented Oct 13, 2024

✅ Forge suite framework_upgrade success on 7eeba4cd15892717741a614add1afde004c7855f ==> d83efaa7699aaa39c3c760ea422d3344fc9034a0

rahxephon89 commented Oct 11, 2024 •

edited

Loading

trunk-io bot commented Oct 11, 2024 •

edited

Loading

codecov bot commented Oct 11, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `d83efaa7699aaa39c3c760ea422d3344fc9034a0`

✅ Forge suite `compat` success on `7eeba4cd15892717741a614add1afde004c7855f` ==> `d83efaa7699aaa39c3c760ea422d3344fc9034a0`

✅ Forge suite `framework_upgrade` success on `7eeba4cd15892717741a614add1afde004c7855f` ==> `d83efaa7699aaa39c3c760ea422d3344fc9034a0`