Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Add a new allowed attribute for skipping mutation testing #14942

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Oct 11, 2024

Description

When running the mutation testing tool, some times we may want to mark pieces of code as not to be mutated. To allow for this, we allow a new attribute #[mutation::skip].

How Has This Been Tested?

Existing tests and one new test.

Type of Change

  • New feature

Which Components or Systems Does This Change Impact?

  • Move Compiler

Copy link

trunk-io bot commented Oct 11, 2024

⏱️ 3h 41m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 42m 🟩🟩
rust-move-unit-coverage 17m 🟩
dispatch_event 16m 🟩
rust-move-unit-coverage 15m 🟩
dispatch_event 14m 🟩
rust-move-unit-coverage 11m 🟩
check 10m 🟩🟩
rust-move-unit-coverage 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 8m 🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check 6m 4m +61%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vineethk and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.1%. Comparing base (8199026) to head (7170455).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14942   +/-   ##
=======================================
  Coverage    60.1%    60.1%           
=======================================
  Files         856      856           
  Lines      211019   211020    +1     
=======================================
+ Hits       126830   126831    +1     
  Misses      84189    84189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vineethk vineethk marked this pull request as ready for review October 11, 2024 18:06
@vineethk vineethk requested review from rahxephon89, fEst1ck and brmataptos and removed request for davidiw and movekevin October 11, 2024 19:00
@vineethk vineethk enabled auto-merge (squash) October 12, 2024 00:18

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 7eeba4cd15892717741a614add1afde004c7855f ==> 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3

Compatibility test results for 7eeba4cd15892717741a614add1afde004c7855f ==> 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3 (PR)
1. Check liveness of validators at old version: 7eeba4cd15892717741a614add1afde004c7855f
compatibility::simple-validator-upgrade::liveness-check : committed: 13115.13 txn/s, latency: 2609.12 ms, (p50: 2100 ms, p70: 2300, p90: 5500 ms, p99: 10500 ms), latency samples: 491800
2. Upgrading first Validator to new version: 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7137.47 txn/s, latency: 3945.96 ms, (p50: 4400 ms, p70: 4800, p90: 5100 ms, p99: 5200 ms), latency samples: 130520
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6206.28 txn/s, latency: 5144.26 ms, (p50: 5100 ms, p70: 5500, p90: 7200 ms, p99: 7600 ms), latency samples: 209220
3. Upgrading rest of first batch to new version: 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6977.00 txn/s, latency: 4030.32 ms, (p50: 4500 ms, p70: 4800, p90: 5000 ms, p99: 5200 ms), latency samples: 129300
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3378.48 txn/s, submitted: 3378.79 txn/s, expired: 0.31 txn/s, latency: 4705.10 ms, (p50: 4900 ms, p70: 5000, p90: 5100 ms, p99: 7100 ms), latency samples: 243158
4. upgrading second batch to new version: 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8415.17 txn/s, latency: 3025.52 ms, (p50: 2700 ms, p70: 3500, p90: 4500 ms, p99: 5500 ms), latency samples: 166920
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11516.78 txn/s, latency: 2702.77 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3400 ms), latency samples: 373320
5. check swarm health
Compatibility test for 7eeba4cd15892717741a614add1afde004c7855f ==> 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3

two traffics test: inner traffic : committed: 13884.69 txn/s, latency: 2864.59 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 3600 ms), latency samples: 5279260
two traffics test : committed: 99.98 txn/s, latency: 2473.61 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 6700 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.249, avg: 0.220", "QsPosToProposal: max: 0.271, avg: 0.240", "ConsensusProposalToOrdered: max: 0.330, avg: 0.298", "ConsensusOrderedToCommit: max: 0.477, avg: 0.443", "ConsensusProposalToCommit: max: 0.775, avg: 0.741"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 2826770 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.38s no progress at version 2826768 (avg 8.38s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 7eeba4cd15892717741a614add1afde004c7855f ==> 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3

Compatibility test results for 7eeba4cd15892717741a614add1afde004c7855f ==> 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3 (PR)
Upgrade the nodes to version: 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 893.91 txn/s, submitted: 896.11 txn/s, failed submission: 2.20 txn/s, expired: 2.20 txn/s, latency: 3316.33 ms, (p50: 2100 ms, p70: 3300, p90: 8400 ms, p99: 10100 ms), latency samples: 81380
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 865.54 txn/s, submitted: 867.54 txn/s, failed submission: 2.00 txn/s, expired: 2.00 txn/s, latency: 3556.49 ms, (p50: 2100 ms, p70: 4300, p90: 7800 ms, p99: 9300 ms), latency samples: 77980
5. check swarm health
Compatibility test for 7eeba4cd15892717741a614add1afde004c7855f ==> 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3 passed
Upgrade the remaining nodes to version: 7170455a6a0b08bbdfcf619e35a0fc5f48da51a3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1226.14 txn/s, submitted: 1229.63 txn/s, failed submission: 3.49 txn/s, expired: 3.49 txn/s, latency: 2529.92 ms, (p50: 2300 ms, p70: 2700, p90: 3900 ms, p99: 5700 ms), latency samples: 105440
Test Ok

@vineethk vineethk merged commit 05bacdf into main Oct 12, 2024
51 checks passed
@vineethk vineethk deleted the vk/mutation-skip branch October 12, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants