-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] main #14937
[test] main #14937
Conversation
⏱️ 2h 6m total CI duration on this PR
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
// daniel hack | ||
Ok(()) | ||
|
||
// Ok(validator.verify(self.signer, &self.info, &self.signature)?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature verification has been disabled, which introduces a significant security vulnerability. This change allows any signature to be considered valid, bypassing a critical security check. To maintain the integrity of the system, please restore the original verification logic by removing the Ok(())
line and uncommenting the original verification:
Ok(validator.verify(self.signer, &self.info, &self.signature)?)
If this change was made for testing purposes, consider using a feature flag or a separate test configuration to enable this behavior in controlled environments only.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist