Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update large packages module #14930

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

0xjunha
Copy link
Contributor

@0xjunha 0xjunha commented Oct 10, 2024

Description

  • Removed Option type in large_packages.move, initially introduced to handle both code deployment and upgrade in a single interface. Separate functions now exist for each operation.
  • Deployed the new version of large_packages.move as an immutable package under address 0x0e1ca3011bdd07246d4d16d909dbb2d6953a86c4735d5acf5865d962c630cce7, both on testnet and mainnet.
  • Updated Move module address in chunked_publish.rs to the latest version.

How Has This Been Tested?

run large_package_publishing e2e test

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 10, 2024

⏱️ 25m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-unit-coverage 11m 🟩
rust-move-tests 10m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 36s 🟩
dispatch_event 33s 🟥
general-lints 27s 🟩
semgrep/ci 27s 🟩
file_change_determinator 14s 🟩
permission-check 5s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@0xjunha 0xjunha disabled auto-merge October 24, 2024 16:06
@0xjunha 0xjunha force-pushed the fix_large_packages branch from 65f6df5 to 0d46312 Compare October 24, 2024 16:08
…ess in chunked_publish.rs to the latest version
@0xjunha 0xjunha force-pushed the fix_large_packages branch from 0d46312 to a579fb8 Compare October 25, 2024 06:33
@0xjunha 0xjunha enabled auto-merge (squash) October 25, 2024 06:36

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a579fb8f908b99a091d9f1ea411c5ba65ab67907

two traffics test: inner traffic : committed: 14230.85 txn/s, latency: 2791.48 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5410980
two traffics test : committed: 100.04 txn/s, latency: 1462.25 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 1700 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.931, avg: 1.567", "ConsensusProposalToOrdered: max: 0.337, avg: 0.298", "ConsensusOrderedToCommit: max: 0.382, avg: 0.364", "ConsensusProposalToCommit: max: 0.673, avg: 0.661"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.93s no progress at version 2866702 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.29s no progress at version 2866700 (avg 8.29s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a579fb8f908b99a091d9f1ea411c5ba65ab67907

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a579fb8f908b99a091d9f1ea411c5ba65ab67907 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 16497.44 txn/s, latency: 2038.75 ms, (p50: 1900 ms, p70: 2100, p90: 2600 ms, p99: 3000 ms), latency samples: 535760
2. Upgrading first Validator to new version: a579fb8f908b99a091d9f1ea411c5ba65ab67907
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5479.01 txn/s, latency: 5158.44 ms, (p50: 5900 ms, p70: 6100, p90: 6300 ms, p99: 6500 ms), latency samples: 105260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5620.40 txn/s, latency: 5663.87 ms, (p50: 6300 ms, p70: 6500, p90: 6900 ms, p99: 7800 ms), latency samples: 191000
3. Upgrading rest of first batch to new version: a579fb8f908b99a091d9f1ea411c5ba65ab67907
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5549.98 txn/s, latency: 5153.00 ms, (p50: 6000 ms, p70: 6100, p90: 6400 ms, p99: 6500 ms), latency samples: 105880
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5104.10 txn/s, latency: 6088.92 ms, (p50: 6600 ms, p70: 6700, p90: 6900 ms, p99: 7900 ms), latency samples: 193800
4. upgrading second batch to new version: a579fb8f908b99a091d9f1ea411c5ba65ab67907
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10217.18 txn/s, latency: 2641.96 ms, (p50: 2400 ms, p70: 3300, p90: 4300 ms, p99: 4500 ms), latency samples: 180980
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10304.80 txn/s, latency: 2987.50 ms, (p50: 2500 ms, p70: 3400, p90: 5000 ms, p99: 6600 ms), latency samples: 336740
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a579fb8f908b99a091d9f1ea411c5ba65ab67907 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a579fb8f908b99a091d9f1ea411c5ba65ab67907

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a579fb8f908b99a091d9f1ea411c5ba65ab67907 (PR)
Upgrade the nodes to version: a579fb8f908b99a091d9f1ea411c5ba65ab67907
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1149.29 txn/s, submitted: 1151.92 txn/s, failed submission: 2.63 txn/s, expired: 2.63 txn/s, latency: 2627.12 ms, (p50: 2600 ms, p70: 2900, p90: 3300 ms, p99: 5100 ms), latency samples: 104780
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1213.01 txn/s, submitted: 1215.03 txn/s, failed submission: 2.03 txn/s, expired: 2.03 txn/s, latency: 2511.89 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5000 ms), latency samples: 107700
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a579fb8f908b99a091d9f1ea411c5ba65ab67907 passed
Upgrade the remaining nodes to version: a579fb8f908b99a091d9f1ea411c5ba65ab67907
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1194.22 txn/s, submitted: 1196.21 txn/s, failed submission: 1.99 txn/s, expired: 1.99 txn/s, latency: 2514.06 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5800 ms), latency samples: 108180
Test Ok

@0xjunha 0xjunha merged commit bb0a7c2 into aptos-labs:main Oct 25, 2024
85 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants