trivial: move a few data structures off executor-types

[msmouse]

Description

The concept of ExecutionOutput is in fact internal to the BlockTree.
The ExecutedChunk is a (unnecessary) helper structure that's local to the executor algorithms.

How Has This Been Tested?

existing coverage

Key Areas to Review

Type of Change

• Refactoring

Which Components or Systems Does This Change Impact?

• Validator Node

[trunk-io]

⏱️ 2h 51m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	46m	🟥 🟩
dispatch_event	16m	🟩
dispatch_event	16m	🟩
dispatch_event	15m	🟩
test-target-determinator	9m	🟩 🟩
rust-targeted-unit-tests	9m	🟩
execution-performance / test-target-determinator	9m	🟩 🟩
rust-cargo-deny	9m	🟩 🟩 🟩 🟩 🟩
check	7m	🟩 🟩
check-dynamic-deps	5m	🟩 🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
fetch-last-released-docker-image-tag	4m	🟩 🟩
general-lints	2m	🟩 🟩 🟩 🟩 🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on 4b97cf281536e82a2ff18edc108fdc1f15c137bb

two traffics test: inner traffic : committed: 13176.11 txn/s, latency: 3022.78 ms, (p50: 3000 ms, p70: 3000, p90: 3300 ms, p99: 4800 ms), latency samples: 5009920
two traffics test : committed: 99.99 txn/s, latency: 2643.98 ms, (p50: 2500 ms, p70: 2700, p90: 3400 ms, p99: 5000 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.237, avg: 0.223", "QsPosToProposal: max: 0.356, avg: 0.288", "ConsensusProposalToOrdered: max: 0.322, avg: 0.309", "ConsensusOrderedToCommit: max: 0.481, avg: 0.461", "ConsensusProposalToCommit: max: 0.800, avg: 0.770"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.86s no progress at version 2190879 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.76s no progress at version 2190877 (avg 8.76s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 4b97cf281536e82a2ff18edc108fdc1f15c137bb

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 4b97cf281536e82a2ff18edc108fdc1f15c137bb (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 12867.91 txn/s, latency: 2658.63 ms, (p50: 2000 ms, p70: 2400, p90: 5000 ms, p99: 9000 ms), latency samples: 463040
2. Upgrading first Validator to new version: 4b97cf281536e82a2ff18edc108fdc1f15c137bb
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7328.05 txn/s, latency: 3897.81 ms, (p50: 4300 ms, p70: 4600, p90: 4800 ms, p99: 4900 ms), latency samples: 137200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6264.27 txn/s, latency: 5002.23 ms, (p50: 5000 ms, p70: 5200, p90: 7100 ms, p99: 7500 ms), latency samples: 238960
3. Upgrading rest of first batch to new version: 4b97cf281536e82a2ff18edc108fdc1f15c137bb
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7191.32 txn/s, latency: 3932.89 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 5000 ms), latency samples: 133540
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6654.75 txn/s, latency: 4567.40 ms, (p50: 4700 ms, p70: 4900, p90: 5000 ms, p99: 6800 ms), latency samples: 248520
4. upgrading second batch to new version: 4b97cf281536e82a2ff18edc108fdc1f15c137bb
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9314.80 txn/s, latency: 2853.28 ms, (p50: 2800 ms, p70: 3200, p90: 4300 ms, p99: 4800 ms), latency samples: 168300
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9569.70 txn/s, latency: 3226.34 ms, (p50: 2900 ms, p70: 3200, p90: 6000 ms, p99: 7600 ms), latency samples: 314380
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 4b97cf281536e82a2ff18edc108fdc1f15c137bb passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 4b97cf281536e82a2ff18edc108fdc1f15c137bb

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 4b97cf281536e82a2ff18edc108fdc1f15c137bb (PR)
Upgrade the nodes to version: 4b97cf281536e82a2ff18edc108fdc1f15c137bb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1140.37 txn/s, submitted: 1142.16 txn/s, failed submission: 1.79 txn/s, expired: 1.79 txn/s, latency: 2652.25 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 6000 ms), latency samples: 101660
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1130.23 txn/s, submitted: 1132.76 txn/s, failed submission: 2.53 txn/s, expired: 2.53 txn/s, latency: 2703.93 ms, (p50: 2200 ms, p70: 2700, p90: 5200 ms, p99: 7100 ms), latency samples: 98420
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 4b97cf281536e82a2ff18edc108fdc1f15c137bb passed
Upgrade the remaining nodes to version: 4b97cf281536e82a2ff18edc108fdc1f15c137bb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1138.52 txn/s, submitted: 1140.81 txn/s, failed submission: 2.28 txn/s, expired: 2.28 txn/s, latency: 2667.93 ms, (p50: 2100 ms, p70: 2700, p90: 5100 ms, p99: 7200 ms), latency samples: 99740
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking