Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple][aptos-workspace-server] fix config issue preventing indexer grpc from starting #14901

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

vgao1996
Copy link
Contributor

@vgao1996 vgao1996 commented Oct 8, 2024

This fixes a config issue preventing the node's indexer grpc service from starting.

We had the same issue with the CLI's Localnet implementation and it was fixed by #14727.

A subsequent PR will add proper tests to ensure the binary always succeed to start.

Copy link

trunk-io bot commented Oct 8, 2024

⏱️ 30m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-doc-tests 4m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 1m 🟩
general-lints 55s 🟩🟩
semgrep/ci 45s 🟩🟩
dispatch_event 38s 🟥
file_change_determinator 21s 🟩🟩
file_change_determinator 10s 🟩
execution-performance / single-node-performance 10s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@grao1991 grao1991 requested a review from larry-aptos October 8, 2024 23:57
@vgao1996 vgao1996 enabled auto-merge (squash) October 8, 2024 23:57

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite realistic_env_max_load success on 6f2f246ec4265b6d717ecd6807e46359d3fcd4b2

two traffics test: inner traffic : committed: 13824.76 txn/s, latency: 2875.82 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 3600 ms), latency samples: 5256500
two traffics test : committed: 100.01 txn/s, latency: 2643.80 ms, (p50: 2400 ms, p70: 2500, p90: 2700 ms, p99: 11600 ms), latency samples: 1660
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.231, avg: 0.218", "QsPosToProposal: max: 0.312, avg: 0.258", "ConsensusProposalToOrdered: max: 0.311, avg: 0.297", "ConsensusOrderedToCommit: max: 0.482, avg: 0.459", "ConsensusProposalToCommit: max: 0.781, avg: 0.756"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.04s no progress at version 2650736 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.30s no progress at version 2650734 (avg 8.30s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 6f2f246ec4265b6d717ecd6807e46359d3fcd4b2

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 6f2f246ec4265b6d717ecd6807e46359d3fcd4b2 (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 8864.85 txn/s, latency: 3264.78 ms, (p50: 2200 ms, p70: 2500, p90: 6000 ms, p99: 19900 ms), latency samples: 403580
2. Upgrading first Validator to new version: 6f2f246ec4265b6d717ecd6807e46359d3fcd4b2
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6810.95 txn/s, latency: 4156.10 ms, (p50: 4700 ms, p70: 5000, p90: 5200 ms, p99: 5300 ms), latency samples: 120280
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6848.85 txn/s, latency: 4724.04 ms, (p50: 4900 ms, p70: 5400, p90: 6300 ms, p99: 6900 ms), latency samples: 232700
3. Upgrading rest of first batch to new version: 6f2f246ec4265b6d717ecd6807e46359d3fcd4b2
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6832.26 txn/s, latency: 3983.22 ms, (p50: 4500 ms, p70: 5000, p90: 5300 ms, p99: 5600 ms), latency samples: 121880
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6644.89 txn/s, latency: 4802.22 ms, (p50: 5100 ms, p70: 5300, p90: 6900 ms, p99: 7100 ms), latency samples: 222040
4. upgrading second batch to new version: 6f2f246ec4265b6d717ecd6807e46359d3fcd4b2
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11208.87 txn/s, latency: 2407.94 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3000 ms), latency samples: 196440
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11509.96 txn/s, latency: 2722.19 ms, (p50: 2600 ms, p70: 2800, p90: 3300 ms, p99: 4900 ms), latency samples: 372780
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 6f2f246ec4265b6d717ecd6807e46359d3fcd4b2 passed
Test Ok

@vgao1996 vgao1996 merged commit 7026a42 into aptos-labs:main Oct 9, 2024
93 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants