Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI][Prover][trivial] set option compile_verify_code to true when running prover using V2 flag #14900

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Oct 8, 2024

Description

This PR set options.compile_verify_code to true when building the model for prover with V2 flag so that aptos move prove --move-2 will verify functions with the attribute #[verify_only].

Close #14895.

How Has This Been Tested?

Manual check by running aptos move prove --move-2.

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 8, 2024

⏱️ 2h 16m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 23m 🟩
dispatch_event 16m 🟩
dispatch_event 15m 🟩
rust-move-unit-coverage 10m 🟩
rust-move-unit-coverage 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-cargo-deny 5m 🟩🟩🟩
test-target-determinator 5m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
check-dynamic-deps 3m 🟩🟩🟩
general-lints 2m 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 23m 17m +39%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rahxephon89 and the rest of your teammates on Graphite Graphite

@rahxephon89 rahxephon89 changed the title add option [CLI][Prover] set option compile_verify_code to true to prover Oct 8, 2024
@rahxephon89 rahxephon89 changed the title [CLI][Prover] set option compile_verify_code to true to prover [CLI][Prover][trivial] set option compile_verify_code to true to prover Oct 8, 2024
@rahxephon89 rahxephon89 marked this pull request as ready for review October 8, 2024 22:38
@rahxephon89 rahxephon89 requested review from brmataptos and wrwg October 8, 2024 22:38
@rahxephon89 rahxephon89 changed the title [CLI][Prover][trivial] set option compile_verify_code to true to prover [CLI][Prover][trivial] set option compile_verify_code to true when running prover using V2 flag Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.0%. Comparing base (cbb4431) to head (94d0dc1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ools/move-package/src/compilation/model_builder.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #14900     +/-   ##
=========================================
- Coverage    60.0%    60.0%   -0.1%     
=========================================
  Files         856      856             
  Lines      210624   210625      +1     
=========================================
  Hits       126573   126573             
- Misses      84051    84052      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahxephon89 rahxephon89 requested a review from vineethk October 9, 2024 17:39
@rahxephon89 rahxephon89 enabled auto-merge (squash) October 9, 2024 18:02

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 94d0dc14f0106818e82a2b5cceecc4c335a5017c

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 94d0dc14f0106818e82a2b5cceecc4c335a5017c (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 12284.70 txn/s, latency: 2578.18 ms, (p50: 1900 ms, p70: 2100, p90: 5400 ms, p99: 12400 ms), latency samples: 436440
2. Upgrading first Validator to new version: 94d0dc14f0106818e82a2b5cceecc4c335a5017c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6728.44 txn/s, latency: 4101.96 ms, (p50: 4100 ms, p70: 4700, p90: 5600 ms, p99: 6100 ms), latency samples: 127040
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6932.98 txn/s, latency: 4668.79 ms, (p50: 4800 ms, p70: 5100, p90: 6400 ms, p99: 6700 ms), latency samples: 236900
3. Upgrading rest of first batch to new version: 94d0dc14f0106818e82a2b5cceecc4c335a5017c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7282.94 txn/s, latency: 3888.52 ms, (p50: 4300 ms, p70: 4800, p90: 5000 ms, p99: 5100 ms), latency samples: 130680
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7065.21 txn/s, latency: 4581.12 ms, (p50: 4800 ms, p70: 5000, p90: 6500 ms, p99: 7000 ms), latency samples: 234400
4. upgrading second batch to new version: 94d0dc14f0106818e82a2b5cceecc4c335a5017c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9523.74 txn/s, latency: 2841.16 ms, (p50: 2800 ms, p70: 3100, p90: 4100 ms, p99: 4400 ms), latency samples: 170780
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9060.61 txn/s, latency: 3462.58 ms, (p50: 2800 ms, p70: 3600, p90: 6900 ms, p99: 9200 ms), latency samples: 342760
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 94d0dc14f0106818e82a2b5cceecc4c335a5017c passed
Test Ok

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite realistic_env_max_load success on 94d0dc14f0106818e82a2b5cceecc4c335a5017c

two traffics test: inner traffic : committed: 13140.66 txn/s, latency: 3053.34 ms, (p50: 2900 ms, p70: 3000, p90: 3300 ms, p99: 12000 ms), latency samples: 4996460
two traffics test : committed: 99.89 txn/s, latency: 2937.75 ms, (p50: 2600 ms, p70: 2700, p90: 3200 ms, p99: 11100 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.253, avg: 0.222", "QsPosToProposal: max: 0.303, avg: 0.244", "ConsensusProposalToOrdered: max: 0.323, avg: 0.302", "ConsensusOrderedToCommit: max: 0.505, avg: 0.484", "ConsensusProposalToCommit: max: 0.807, avg: 0.786"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.15s no progress at version 33778 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.11s no progress at version 1356510 (avg 8.07s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 94d0dc14f0106818e82a2b5cceecc4c335a5017c

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 94d0dc14f0106818e82a2b5cceecc4c335a5017c (PR)
Upgrade the nodes to version: 94d0dc14f0106818e82a2b5cceecc4c335a5017c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1213.62 txn/s, submitted: 1215.67 txn/s, failed submission: 2.04 txn/s, expired: 2.04 txn/s, latency: 2563.86 ms, (p50: 2100 ms, p70: 2700, p90: 4500 ms, p99: 6000 ms), latency samples: 106860
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1121.15 txn/s, submitted: 1122.05 txn/s, failed submission: 0.90 txn/s, expired: 0.90 txn/s, latency: 2683.47 ms, (p50: 2400 ms, p70: 3000, p90: 4200 ms, p99: 6200 ms), latency samples: 99460
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 94d0dc14f0106818e82a2b5cceecc4c335a5017c passed
Upgrade the remaining nodes to version: 94d0dc14f0106818e82a2b5cceecc4c335a5017c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1097.47 txn/s, submitted: 1100.57 txn/s, failed submission: 3.10 txn/s, expired: 3.10 txn/s, latency: 2692.77 ms, (p50: 2400 ms, p70: 2700, p90: 4900 ms, p99: 7500 ms), latency samples: 99160
Test Ok

@rahxephon89 rahxephon89 merged commit c155fde into main Oct 9, 2024
96 checks passed
@rahxephon89 rahxephon89 deleted the teng/aptos-move-prove-verify-only branch October 9, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Prover][Compiler-v2] aptos move prove --move-2 skips #[verify_only]
3 participants