Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the folder name to be consistent #14856

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Oct 3, 2024

Description

This is to update folder name to be consistent with processor repo

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests
  • Other

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • [X ] Other (indexer-test-transactions)

Checklist

  • [ X] I have read and followed the CONTRIBUTING doc
  • [X ] I have performed a self-review of my own code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [X ] I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 3, 2024

⏱️ 38m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 5m 🟩
rust-cargo-deny 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
test-target-determinator 5m 🟩
check 4m 🟩
check-dynamic-deps 3m 🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 32s 🟩🟩🟩
file_change_determinator 11s 🟩
execution-performance / single-node-performance 10s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / test-target-determinator 5m 4m +24%
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@yuunlimm yuunlimm marked this pull request as ready for review October 3, 2024 04:21
@yuunlimm yuunlimm force-pushed the yuunlimm/update-indexer-test-generation branch from 7246f05 to 3383172 Compare October 3, 2024 04:40
@yuunlimm yuunlimm requested a review from larry-aptos October 3, 2024 04:45
@yuunlimm yuunlimm enabled auto-merge (squash) October 3, 2024 04:56

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Forge suite realistic_env_max_load success on 3383172e3a4ad0c7185b199d53abeeb8368e4aa8

two traffics test: inner traffic : committed: 12392.44 txn/s, latency: 3217.85 ms, (p50: 2700 ms, p70: 3000, p90: 4500 ms, p99: 10800 ms), latency samples: 4711860
two traffics test : committed: 100.03 txn/s, latency: 3227.38 ms, (p50: 2500 ms, p70: 3000, p90: 5000 ms, p99: 10600 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.235, avg: 0.220", "QsPosToProposal: max: 0.220, avg: 0.184", "ConsensusProposalToOrdered: max: 0.317, avg: 0.298", "ConsensusOrderedToCommit: max: 0.436, avg: 0.420", "ConsensusProposalToCommit: max: 0.739, avg: 0.719"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 2141054 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.62s no progress at version 2141052 (avg 7.62s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Forge suite compat success on e8a6faf60a98afca8982e0582f929401294bbd33 ==> 3383172e3a4ad0c7185b199d53abeeb8368e4aa8

Compatibility test results for e8a6faf60a98afca8982e0582f929401294bbd33 ==> 3383172e3a4ad0c7185b199d53abeeb8368e4aa8 (PR)
1. Check liveness of validators at old version: e8a6faf60a98afca8982e0582f929401294bbd33
compatibility::simple-validator-upgrade::liveness-check : committed: 2100.02 txn/s, latency: 15799.34 ms, (p50: 15800 ms, p70: 21000, p90: 25300 ms, p99: 28100 ms), latency samples: 78660
2. Upgrading first Validator to new version: 3383172e3a4ad0c7185b199d53abeeb8368e4aa8
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2543.52 txn/s, latency: 11242.24 ms, (p50: 12900 ms, p70: 14400, p90: 15100 ms, p99: 15300 ms), latency samples: 55660
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6736.29 txn/s, latency: 4667.43 ms, (p50: 4800 ms, p70: 4900, p90: 6600 ms, p99: 6900 ms), latency samples: 229000
3. Upgrading rest of first batch to new version: 3383172e3a4ad0c7185b199d53abeeb8368e4aa8
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7185.09 txn/s, latency: 3909.43 ms, (p50: 4400 ms, p70: 4700, p90: 4900 ms, p99: 5000 ms), latency samples: 132320
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6777.82 txn/s, latency: 4710.02 ms, (p50: 4700 ms, p70: 4800, p90: 7300 ms, p99: 7500 ms), latency samples: 240700
4. upgrading second batch to new version: 3383172e3a4ad0c7185b199d53abeeb8368e4aa8
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 1902.91 txn/s, submitted: 1996.46 txn/s, failed submission: 129.61 txn/s, expired: 93.55 txn/s, latency: 10234.31 ms, (p50: 2300 ms, p70: 2700, p90: 39800 ms, p99: 42000 ms), latency samples: 136242
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11515.21 txn/s, latency: 2660.26 ms, (p50: 2700 ms, p70: 2800, p90: 3500 ms, p99: 4300 ms), latency samples: 375640
5. check swarm health
Compatibility test for e8a6faf60a98afca8982e0582f929401294bbd33 ==> 3383172e3a4ad0c7185b199d53abeeb8368e4aa8 passed
Test Ok

@yuunlimm yuunlimm merged commit 1608db6 into main Oct 3, 2024
93 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/update-indexer-test-generation branch October 3, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants