Remove Clone trait for validator verifier

[vusirikala]

Description

For optimistic signature verification feature, signature verification step adds the list of malicious authors (authors who submitted invalid signatures) to validator verifier. Future signature verification for this author will happen pessimistically. For this to work, we need to make sure the same view of validator verifier is held across the entire system. To ensure this, this PR removes "Clone" trait from ValidatorVerifier. Wherever a validator verifier is to be cloned, we use Arc<ValidatorVerifier> instead.

How Has This Been Tested?

Key Areas to Review

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 9h 46m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose	4h 38m	⬜ ⬜ ⬜ ⬜
execution-performance / single-node-performance	2h 24m	🟩 🟩 🟥 🟩 🟩 (+1 more)
execution-performance / test-target-determinator	24m	🟩 🟩 🟩 🟩 🟩
test-target-determinator	18m	🟩 🟩 🟩 🟩
check	15m	🟩 🟩 ⬜ 🟩 🟩
forge-framework-upgrade-test / forge	10m	🟥
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
rust-cargo-deny	9m	🟩 🟩 🟩 🟩 🟩
check-dynamic-deps	8m	🟩 🟩 🟩 🟩 🟩 (+1 more)
fetch-last-released-docker-image-tag	6m	🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
check-dynamic-deps	2m	1m
execution-performance / test-target-determinator	8m	4m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[zekun000]

we can remove the Arc inside the struct now since the whole struct can only be shared with Arc

[vusirikala]

Done

[ibalajiarun]

Suggested change

	// view of ValidatorVerifier is used across the system. In can case a ValidatorVerifier needs to be cloned,
	// view of ValidatorVerifier is used across the system. In case a ValidatorVerifier needs to be cloned,

[github-actions]

✅ Forge suite compat success on e8a6faf60a98afca8982e0582f929401294bbd33 ==> fb0bec49ec5bd0fe07378ea660ba206db3e84bc8

Compatibility test results for e8a6faf60a98afca8982e0582f929401294bbd33 ==> fb0bec49ec5bd0fe07378ea660ba206db3e84bc8 (PR)
1. Check liveness of validators at old version: e8a6faf60a98afca8982e0582f929401294bbd33
compatibility::simple-validator-upgrade::liveness-check : committed: 12299.46 txn/s, latency: 2752.93 ms, (p50: 1900 ms, p70: 2200, p90: 5600 ms, p99: 15700 ms), latency samples: 399340
2. Upgrading first Validator to new version: fb0bec49ec5bd0fe07378ea660ba206db3e84bc8
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6605.06 txn/s, latency: 4309.51 ms, (p50: 4900 ms, p70: 5200, p90: 5400 ms, p99: 5600 ms), latency samples: 120260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6690.21 txn/s, latency: 4854.37 ms, (p50: 5100 ms, p70: 5600, p90: 6400 ms, p99: 6900 ms), latency samples: 228760
3. Upgrading rest of first batch to new version: fb0bec49ec5bd0fe07378ea660ba206db3e84bc8
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7331.88 txn/s, latency: 3815.22 ms, (p50: 4200 ms, p70: 4400, p90: 4800 ms, p99: 4900 ms), latency samples: 134980
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7056.04 txn/s, latency: 4559.21 ms, (p50: 4700 ms, p70: 5000, p90: 6200 ms, p99: 6500 ms), latency samples: 240940
4. upgrading second batch to new version: fb0bec49ec5bd0fe07378ea660ba206db3e84bc8
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9499.35 txn/s, latency: 2784.49 ms, (p50: 2800 ms, p70: 3400, p90: 4000 ms, p99: 4300 ms), latency samples: 177700
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10104.83 txn/s, latency: 3067.87 ms, (p50: 2800 ms, p70: 3500, p90: 4100 ms, p99: 4400 ms), latency samples: 336520
5. check swarm health
Compatibility test for e8a6faf60a98afca8982e0582f929401294bbd33 ==> fb0bec49ec5bd0fe07378ea660ba206db3e84bc8 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on fb0bec49ec5bd0fe07378ea660ba206db3e84bc8

two traffics test: inner traffic : committed: 12551.10 txn/s, latency: 3179.43 ms, (p50: 2700 ms, p70: 3000, p90: 3900 ms, p99: 9600 ms), latency samples: 4772180
two traffics test : committed: 99.95 txn/s, latency: 3444.75 ms, (p50: 2400 ms, p70: 2800, p90: 6900 ms, p99: 9800 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.242, avg: 0.221", "QsPosToProposal: max: 0.276, avg: 0.192", "ConsensusProposalToOrdered: max: 0.331, avg: 0.300", "ConsensusOrderedToCommit: max: 0.442, avg: 0.415", "ConsensusProposalToCommit: max: 0.747, avg: 0.716"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.17s no progress at version 1943149 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.61s no progress at version 1943147 (avg 6.15s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on e8a6faf60a98afca8982e0582f929401294bbd33 ==> fb0bec49ec5bd0fe07378ea660ba206db3e84bc8

Compatibility test results for e8a6faf60a98afca8982e0582f929401294bbd33 ==> fb0bec49ec5bd0fe07378ea660ba206db3e84bc8 (PR)
Upgrade the nodes to version: fb0bec49ec5bd0fe07378ea660ba206db3e84bc8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1218.33 txn/s, submitted: 1221.23 txn/s, failed submission: 2.91 txn/s, expired: 2.91 txn/s, latency: 2557.80 ms, (p50: 2300 ms, p70: 2400, p90: 4200 ms, p99: 6100 ms), latency samples: 108980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1073.16 txn/s, submitted: 1075.39 txn/s, failed submission: 2.22 txn/s, expired: 2.22 txn/s, latency: 2785.61 ms, (p50: 2600 ms, p70: 3000, p90: 4400 ms, p99: 6200 ms), latency samples: 96500
5. check swarm health
Compatibility test for e8a6faf60a98afca8982e0582f929401294bbd33 ==> fb0bec49ec5bd0fe07378ea660ba206db3e84bc8 passed
Upgrade the remaining nodes to version: fb0bec49ec5bd0fe07378ea660ba206db3e84bc8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1247.94 txn/s, submitted: 1249.49 txn/s, failed submission: 1.55 txn/s, expired: 1.55 txn/s, latency: 2652.01 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 7200 ms), latency samples: 112680
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking