[move-vm] Check for empty field variant list

[wrwg]

Description

Add a check to bounds_checker for empty variant field handle lists

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

[trunk-io]

⏱️ 1h 12m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	23m	🟩
rust-move-unit-coverage	11m	🟩
rust-move-tests	10m	🟩
rust-doc-tests	5m	🟩
execution-performance / test-target-determinator	4m	🟩
test-target-determinator	4m	🟩
check	3m	🟩
rust-cargo-deny	3m	⬜ 🟩
check-dynamic-deps	3m	🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩
rust-move-tests	1m	⬜
general-lints	55s	🟩 🟩
semgrep/ci	44s	🟩 🟩
file_change_determinator	22s	🟩 🟩
file_change_determinator	11s	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[wrwg]

• [move-vm] Check for empty field variant list #14841 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.8%. Comparing base (7f784af) to head (0b5890c).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
..._party/move/move-binary-format/src/check_bounds.rs	28.5%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #14841     +/-   ##
=========================================
- Coverage    59.8%    59.8%   -0.1%     
=========================================
  Files         853      853             
  Lines      207923   207930      +7     
=========================================
+ Hits       124342   124344      +2     
- Misses      83581    83586      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Forge suite compat success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 0b5890c91653f8a042f30e239aafa0b8e419be0d

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 0b5890c91653f8a042f30e239aafa0b8e419be0d (PR)
1. Check liveness of validators at old version: 7ef01a26f8d8a38610e3d364b722df517c970749
compatibility::simple-validator-upgrade::liveness-check : committed: 11462.21 txn/s, latency: 2503.75 ms, (p50: 1900 ms, p70: 2100, p90: 2400 ms, p99: 29300 ms), latency samples: 472880
2. Upgrading first Validator to new version: 0b5890c91653f8a042f30e239aafa0b8e419be0d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7254.68 txn/s, latency: 3894.45 ms, (p50: 4400 ms, p70: 4600, p90: 4900 ms, p99: 5000 ms), latency samples: 135080
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6336.69 txn/s, latency: 4625.31 ms, (p50: 4800 ms, p70: 5200, p90: 5400 ms, p99: 5500 ms), latency samples: 234780
3. Upgrading rest of first batch to new version: 0b5890c91653f8a042f30e239aafa0b8e419be0d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6809.06 txn/s, latency: 4130.11 ms, (p50: 4700 ms, p70: 4900, p90: 5200 ms, p99: 5300 ms), latency samples: 126540
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3320.13 txn/s, submitted: 3320.28 txn/s, expired: 0.16 txn/s, latency: 4871.78 ms, (p50: 4900 ms, p70: 5100, p90: 7300 ms, p99: 7500 ms), latency samples: 235089
4. upgrading second batch to new version: 0b5890c91653f8a042f30e239aafa0b8e419be0d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9255.49 txn/s, latency: 2869.17 ms, (p50: 3000 ms, p70: 3300, p90: 3900 ms, p99: 4300 ms), latency samples: 171840
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9607.00 txn/s, latency: 3316.72 ms, (p50: 3200 ms, p70: 3400, p90: 4000 ms, p99: 5600 ms), latency samples: 319420
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 0b5890c91653f8a042f30e239aafa0b8e419be0d passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 0b5890c91653f8a042f30e239aafa0b8e419be0d

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 0b5890c91653f8a042f30e239aafa0b8e419be0d (PR)
Upgrade the nodes to version: 0b5890c91653f8a042f30e239aafa0b8e419be0d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1314.14 txn/s, submitted: 1318.67 txn/s, failed submission: 4.53 txn/s, expired: 4.53 txn/s, latency: 2452.19 ms, (p50: 2100 ms, p70: 2400, p90: 4000 ms, p99: 5700 ms), latency samples: 116100
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1184.25 txn/s, submitted: 1187.63 txn/s, failed submission: 3.38 txn/s, expired: 3.38 txn/s, latency: 2580.65 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 6600 ms), latency samples: 105260
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 0b5890c91653f8a042f30e239aafa0b8e419be0d passed
Upgrade the remaining nodes to version: 0b5890c91653f8a042f30e239aafa0b8e419be0d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1081.32 txn/s, submitted: 1084.01 txn/s, failed submission: 2.69 txn/s, expired: 2.69 txn/s, latency: 2861.15 ms, (p50: 2400 ms, p70: 3000, p90: 5300 ms, p99: 7800 ms), latency samples: 96580
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 0b5890c91653f8a042f30e239aafa0b8e419be0d

two traffics test: inner traffic : committed: 12639.50 txn/s, submitted: 12640.03 txn/s, expired: 0.53 txn/s, latency: 3141.34 ms, (p50: 2700 ms, p70: 3000, p90: 3900 ms, p99: 8700 ms), latency samples: 4806000
two traffics test : committed: 100.02 txn/s, latency: 1888.46 ms, (p50: 1500 ms, p70: 1600, p90: 2000 ms, p99: 8100 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.253, avg: 0.230", "QsPosToProposal: max: 1.019, avg: 0.950", "ConsensusProposalToOrdered: max: 0.355, avg: 0.325", "ConsensusOrderedToCommit: max: 0.605, avg: 0.534", "ConsensusProposalToCommit: max: 0.960, avg: 0.859"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.01s no progress at version 31576 (avg 0.23s) [limit 15].
Max epoch-change gap was: 1 rounds at version 1612141 (avg 0.50) [limit 4], 9.47s no progress at version 1612141 (avg 8.49s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking