Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[movefmt][trivial] format move files in the tests and examples folder #14779

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[movefmt][trivial] format move files in the tests and examples folder #14779

merged 2 commits into from
Sep 30, 2024

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Sep 27, 2024 •
edited
Loading

Description

This PR includes move files inside tests and examples as the format target when executing aptos move fmt.
Close #14776

How Has This Been Tested?

Manual test

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Sep 27, 2024 •
edited
Loading

⏱️ 49m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 7m 🟩 🟩 🟩 🟩 
check-dynamic-deps 5m 🟩 🟩 🟩 🟩 
rust-doc-tests 4m 🟩 
rust-lints 4m 🟥 
test-target-determinator 4m 🟩 
execution-performance / test-target-determinator 4m 🟩 
check 4m 🟩 
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 
general-lints 2m 🟩 🟩 🟩 🟩 
fetch-last-released-docker-image-tag 2m 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 
file_change_determinator 46s 🟩 🟩 🟩 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 19m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@rahxephon89 Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rahxephon89 and the rest of your teammates on Graphite Graphite

@rahxephon89 rahxephon89 changed the title format tests and examples folder [movefmt][trivial] format move files in the tests and examples folder Sep 27, 2024
@rahxephon89 rahxephon89 marked this pull request as ready for review September 27, 2024 19:06
gregnazario
gregnazario approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would include the scripts folder

@rahxephon89
Copy link
Contributor Author

I would include the scripts folder

scripts folder is already included.

@rahxephon89 rahxephon89 enabled auto-merge (squash) September 30, 2024 17:57
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb

two traffics test: inner traffic : committed: 14399.00 txn/s, latency: 2758.47 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5474780
two traffics test : committed: 100.09 txn/s, latency: 1708.58 ms, (p50: 1500 ms, p70: 1500, p90: 1600 ms, p99: 9300 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.246, avg: 0.230", "QsPosToProposal: max: 1.130, avg: 1.094", "ConsensusProposalToOrdered: max: 0.320, avg: 0.293", "ConsensusOrderedToCommit: max: 0.428, avg: 0.412", "ConsensusProposalToCommit: max: 0.718, avg: 0.705"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.40s no progress at version 32324 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.84s no progress at version 3011521 (avg 8.84s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 28abb7db64af8de81a6bc76c6b2d6600181ac578 ==> eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb

Compatibility test results for 28abb7db64af8de81a6bc76c6b2d6600181ac578 ==> eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb (PR)
Upgrade the nodes to version: eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1193.22 txn/s, submitted: 1195.64 txn/s, failed submission: 2.42 txn/s, expired: 2.42 txn/s, latency: 2576.19 ms, (p50: 2100 ms, p70: 2600, p90: 5000 ms, p99: 6300 ms), latency samples: 108260
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1129.61 txn/s, submitted: 1131.61 txn/s, failed submission: 2.00 txn/s, expired: 2.00 txn/s, latency: 2613.42 ms, (p50: 2100 ms, p70: 2700, p90: 4700 ms, p99: 6900 ms), latency samples: 101620
5. check swarm health
Compatibility test for 28abb7db64af8de81a6bc76c6b2d6600181ac578 ==> eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb passed
Upgrade the remaining nodes to version: eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1086.96 txn/s, submitted: 1090.31 txn/s, failed submission: 3.35 txn/s, expired: 3.35 txn/s, latency: 2715.35 ms, (p50: 2100 ms, p70: 2900, p90: 4800 ms, p99: 7200 ms), latency samples: 97240
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 28abb7db64af8de81a6bc76c6b2d6600181ac578 ==> eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb

Compatibility test results for 28abb7db64af8de81a6bc76c6b2d6600181ac578 ==> eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb (PR)
1. Check liveness of validators at old version: 28abb7db64af8de81a6bc76c6b2d6600181ac578
compatibility::simple-validator-upgrade::liveness-check : committed: 16012.64 txn/s, latency: 2132.05 ms, (p50: 2100 ms, p70: 2200, p90: 2400 ms, p99: 3200 ms), latency samples: 514280
2. Upgrading first Validator to new version: eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7415.81 txn/s, latency: 3731.17 ms, (p50: 3800 ms, p70: 4400, p90: 4900 ms, p99: 5300 ms), latency samples: 139460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7282.33 txn/s, latency: 4396.09 ms, (p50: 4500 ms, p70: 4600, p90: 6300 ms, p99: 6500 ms), latency samples: 246800
3. Upgrading rest of first batch to new version: eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6524.99 txn/s, latency: 4266.62 ms, (p50: 4900 ms, p70: 5100, p90: 5300 ms, p99: 5500 ms), latency samples: 119700
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7156.83 txn/s, latency: 4506.48 ms, (p50: 4400 ms, p70: 5000, p90: 6300 ms, p99: 6600 ms), latency samples: 242480
4. upgrading second batch to new version: eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12013.52 txn/s, latency: 2308.85 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 3000 ms), latency samples: 208140
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11848.64 txn/s, latency: 2644.96 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 3900 ms), latency samples: 385280
5. check swarm health
Compatibility test for 28abb7db64af8de81a6bc76c6b2d6600181ac578 ==> eb4a9b9fb2405e84b6a7261c354bbcc5cd8773cb passed
Test Ok

@rahxephon89 rahxephon89 merged commit 5946c57 into main Sep 30, 2024
94 checks passed
@rahxephon89 rahxephon89 deleted the teng/add-test branch September 30, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brmataptos brmataptos brmataptos approved these changes

@gregnazario gregnazario gregnazario approved these changes

@banool banool Awaiting requested review from banool banool is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request][CLI][movefmt] Format move files in the test dir
3 participants
@rahxephon89 @gregnazario @brmataptos