[framework] Add ability to destroy caps from a managed coin #14758

gregnazario · 2024-09-25T23:10:45Z

Description

Managed coins are stuck forever, where all three capabilities are always accessible. This can cause some issues if someone who set it up originally, wanted to no longer allow burning or minting of the coin.

This PR allows you to destroy this ability, or store it elsewhere and choose which to destroy.

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-25T23:10:49Z

⏱️ 2h 38m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	46m	🟩 🟩
rust-move-unit-coverage	15m	🟩
rust-move-unit-coverage	11m	🟩
rust-move-unit-coverage	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟥
rust-move-tests	9m	🟩
execution-performance / test-target-determinator	9m	🟩 🟩
check-dynamic-deps	8m	🟩 🟩 🟩 🟩 🟩
rust-cargo-deny	6m	🟩 🟩 ⬜ 🟩
test-target-determinator	5m	🟩
rust-doc-tests	5m	🟩
check	4m	⬜ 🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩 🟩
general-lints	2m	🟩 🟩 🟩 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
check-dynamic-deps	2m	1m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

aptos-move/framework/aptos-framework/sources/managed_coin.move

JohnChangUK · 2024-10-02T18:16:59Z

aptos-move/framework/aptos-framework/sources/managed_coin.move

+    ): (BurnCapability<CoinType>, FreezeCapability<CoinType>, MintCapability<CoinType>) acquires Capabilities {
+        let account_addr = signer::address_of(account);
+        assert!(
+            exists<Capabilities<CoinType>>(account_addr),


Would be nice to have a public function to view if Capabilities exists in an address.

github-actions · 2024-10-02T18:37:53Z

✅ Forge suite `realistic_env_max_load` success on `80c411312dbe963a0586e42130564688388d45a2`

two traffics test: inner traffic : committed: 11816.76 txn/s, latency: 3360.85 ms, (p50: 3000 ms, p70: 3300, p90: 4200 ms, p99: 7200 ms), latency samples: 4493060
two traffics test : committed: 100.02 txn/s, latency: 2910.86 ms, (p50: 2500 ms, p70: 2700, p90: 3700 ms, p99: 11100 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.242, avg: 0.222", "QsPosToProposal: max: 0.603, avg: 0.479", "ConsensusProposalToOrdered: max: 0.337, avg: 0.324", "ConsensusOrderedToCommit: max: 0.507, avg: 0.470", "ConsensusProposalToCommit: max: 0.840, avg: 0.794"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.86s no progress at version 16776 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.36s no progress at version 2392982 (avg 8.36s) [limit 15].
Test Ok

github-actions · 2024-10-02T18:38:14Z

✅ Forge suite `compat` success on `628e88b8a1971b4986dfb2b88ec763090f85c82f` ==> `80c411312dbe963a0586e42130564688388d45a2`

Compatibility test results for 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 80c411312dbe963a0586e42130564688388d45a2 (PR)
1. Check liveness of validators at old version: 628e88b8a1971b4986dfb2b88ec763090f85c82f
compatibility::simple-validator-upgrade::liveness-check : committed: 12492.43 txn/s, latency: 2325.53 ms, (p50: 2100 ms, p70: 2200, p90: 2500 ms, p99: 10300 ms), latency samples: 486040
2. Upgrading first Validator to new version: 80c411312dbe963a0586e42130564688388d45a2
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7471.62 txn/s, latency: 3718.39 ms, (p50: 3900 ms, p70: 4400, p90: 5000 ms, p99: 5300 ms), latency samples: 137860
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7106.05 txn/s, latency: 4570.99 ms, (p50: 4800 ms, p70: 5000, p90: 6200 ms, p99: 6700 ms), latency samples: 239940
3. Upgrading rest of first batch to new version: 80c411312dbe963a0586e42130564688388d45a2
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5967.32 txn/s, latency: 4756.86 ms, (p50: 5100 ms, p70: 5800, p90: 6200 ms, p99: 6300 ms), latency samples: 112200
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5724.69 txn/s, latency: 5679.35 ms, (p50: 6100 ms, p70: 6300, p90: 6600 ms, p99: 7000 ms), latency samples: 192860
4. upgrading second batch to new version: 80c411312dbe963a0586e42130564688388d45a2
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10822.45 txn/s, latency: 2533.28 ms, (p50: 2800 ms, p70: 2900, p90: 3000 ms, p99: 3100 ms), latency samples: 188920
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11298.05 txn/s, latency: 2772.73 ms, (p50: 2700 ms, p70: 2900, p90: 3200 ms, p99: 4900 ms), latency samples: 362120
5. check swarm health
Compatibility test for 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 80c411312dbe963a0586e42130564688388d45a2 passed
Test Ok

github-actions · 2024-10-02T18:39:46Z

✅ Forge suite `framework_upgrade` success on `628e88b8a1971b4986dfb2b88ec763090f85c82f` ==> `80c411312dbe963a0586e42130564688388d45a2`

Compatibility test results for 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 80c411312dbe963a0586e42130564688388d45a2 (PR)
Upgrade the nodes to version: 80c411312dbe963a0586e42130564688388d45a2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1173.78 txn/s, submitted: 1175.80 txn/s, failed submission: 2.02 txn/s, expired: 2.02 txn/s, latency: 2714.21 ms, (p50: 2400 ms, p70: 2700, p90: 4700 ms, p99: 6500 ms), latency samples: 104580
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1003.95 txn/s, submitted: 1006.53 txn/s, failed submission: 2.58 txn/s, expired: 2.58 txn/s, latency: 3083.01 ms, (p50: 2700 ms, p70: 3300, p90: 5400 ms, p99: 7700 ms), latency samples: 85480
5. check swarm health
Compatibility test for 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 80c411312dbe963a0586e42130564688388d45a2 passed
Upgrade the remaining nodes to version: 80c411312dbe963a0586e42130564688388d45a2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1097.50 txn/s, submitted: 1099.94 txn/s, failed submission: 2.44 txn/s, expired: 2.44 txn/s, latency: 2679.12 ms, (p50: 2400 ms, p70: 3000, p90: 4500 ms, p99: 6000 ms), latency samples: 99040
Test Ok

gregnazario requested review from davidiw, movekevin and wrwg as code owners September 25, 2024 23:10

gregnazario force-pushed the add-ability-to-stop-managed-coin branch from 8965afd to 46f6b0d Compare September 26, 2024 19:34

gregnazario requested a review from junkil-park as a code owner September 26, 2024 19:34

davidiw approved these changes Sep 30, 2024

View reviewed changes

aptos-move/framework/aptos-framework/sources/managed_coin.move Show resolved Hide resolved

[framework] Add ability to destroy caps from a managed coin

5fb05ee

gregnazario force-pushed the add-ability-to-stop-managed-coin branch from 46f6b0d to 5fb05ee Compare October 2, 2024 18:07

gregnazario enabled auto-merge (squash) October 2, 2024 18:08

Merge branch 'main' into add-ability-to-stop-managed-coin

80c4113

JohnChangUK reviewed Oct 2, 2024

View reviewed changes

JohnChangUK approved these changes Oct 2, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

gregnazario merged commit 8d138df into aptos-labs:main Oct 2, 2024
49 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[framework] Add ability to destroy caps from a managed coin #14758

[framework] Add ability to destroy caps from a managed coin #14758

gregnazario commented Sep 25, 2024

trunk-io bot commented Sep 25, 2024 •

edited

Loading

JohnChangUK Oct 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

[framework] Add ability to destroy caps from a managed coin #14758

[framework] Add ability to destroy caps from a managed coin #14758

Conversation

gregnazario commented Sep 25, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Sep 25, 2024 • edited Loading

JohnChangUK Oct 2, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 2, 2024

✅ Forge suite realistic_env_max_load success on 80c411312dbe963a0586e42130564688388d45a2

github-actions bot commented Oct 2, 2024

✅ Forge suite compat success on 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 80c411312dbe963a0586e42130564688388d45a2

github-actions bot commented Oct 2, 2024

✅ Forge suite framework_upgrade success on 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 80c411312dbe963a0586e42130564688388d45a2

trunk-io bot commented Sep 25, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `80c411312dbe963a0586e42130564688388d45a2`

✅ Forge suite `compat` success on `628e88b8a1971b4986dfb2b88ec763090f85c82f` ==> `80c411312dbe963a0586e42130564688388d45a2`

✅ Forge suite `framework_upgrade` success on `628e88b8a1971b4986dfb2b88ec763090f85c82f` ==> `80c411312dbe963a0586e42130564688388d45a2`