Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to StringBodies circuit template #14675

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

rex1fernando
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 18, 2024

@rex1fernando rex1fernando requested a review from zjma September 18, 2024 19:21
@rex1fernando rex1fernando enabled auto-merge (squash) September 18, 2024 22:44

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on f653f8da841049abe77d5a8e884695df98f32573

two traffics test: inner traffic : committed: 14400.29 txn/s, latency: 2757.23 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5475320
two traffics test : committed: 100.01 txn/s, latency: 1656.75 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 7400 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.233, avg: 0.221", "QsPosToProposal: max: 1.110, avg: 1.074", "ConsensusProposalToOrdered: max: 0.318, avg: 0.291", "ConsensusOrderedToCommit: max: 0.421, avg: 0.404", "ConsensusProposalToCommit: max: 0.708, avg: 0.695"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 2970504 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.57s no progress at version 2970502 (avg 8.57s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 70806ff543496aa6de7807feff49e7e1370efd20 ==> f653f8da841049abe77d5a8e884695df98f32573

Compatibility test results for 70806ff543496aa6de7807feff49e7e1370efd20 ==> f653f8da841049abe77d5a8e884695df98f32573 (PR)
1. Check liveness of validators at old version: 70806ff543496aa6de7807feff49e7e1370efd20
compatibility::simple-validator-upgrade::liveness-check : committed: 14536.64 txn/s, latency: 2010.42 ms, (p50: 1900 ms, p70: 2100, p90: 2400 ms, p99: 3800 ms), latency samples: 550400
2. Upgrading first Validator to new version: f653f8da841049abe77d5a8e884695df98f32573
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7789.20 txn/s, latency: 3638.52 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4400 ms), latency samples: 145400
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7186.67 txn/s, latency: 4086.91 ms, (p50: 4300 ms, p70: 4300, p90: 4400 ms, p99: 5800 ms), latency samples: 271580
3. Upgrading rest of first batch to new version: f653f8da841049abe77d5a8e884695df98f32573
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7014.05 txn/s, latency: 3963.61 ms, (p50: 4300 ms, p70: 4500, p90: 5000 ms, p99: 5100 ms), latency samples: 141480
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7762.07 txn/s, latency: 4096.81 ms, (p50: 4100 ms, p70: 4300, p90: 6400 ms, p99: 6600 ms), latency samples: 260160
4. upgrading second batch to new version: f653f8da841049abe77d5a8e884695df98f32573
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11634.54 txn/s, latency: 2351.11 ms, (p50: 2500 ms, p70: 2700, p90: 2900 ms, p99: 3100 ms), latency samples: 203200
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11108.74 txn/s, latency: 2765.94 ms, (p50: 2600 ms, p70: 2900, p90: 4200 ms, p99: 5500 ms), latency samples: 365740
5. check swarm health
Compatibility test for 70806ff543496aa6de7807feff49e7e1370efd20 ==> f653f8da841049abe77d5a8e884695df98f32573 passed
Test Ok

@rex1fernando rex1fernando merged commit 7d41163 into main Sep 18, 2024
49 checks passed
@rex1fernando rex1fernando deleted the rex/circuit_comments branch September 18, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants