Optimistic signature verification for signed batch info #14644

vusirikala · 2024-09-15T01:41:59Z

Description

This PR implements optimistic signature verification to reduce the time required to verify SignedBatchInfo.
When the optimistic signature verification feature flag is enabled, we will not verify these messages up front. We will accumulate the unverified messages, and when the accumulated voting power is higher than a threshold, we will aggregate all the signatures and verify the aggregated signature.
If the verification fails, we need to verify each individual signature. The ValidatorVerifier stores the list of authors that submitted bad messages, and will disable the optimistic signature verification for these malicious voters.

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-15T01:42:02Z

⏱️ 5h 51m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	1h 26m	🟩 🟩 🟩 🟩
forge-compat-test / forge	1h 7m	🟩 🟩 ⬜ 🟩
forge-e2e-test / forge	52m	🟩 🟩 ⬜ 🟩
test-target-determinator	18m	🟩 🟩 🟩 🟩
execution-performance / test-target-determinator	18m	🟩 🟩 🟩 🟩
check	15m	🟩 🟩 🟩 🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
general-lints	7m	⬜ 🟩 🟩 🟩 🟩
rust-cargo-deny	7m	⬜ 🟩 🟩 🟩 🟩
check-dynamic-deps	7m	🟩 🟩 🟩 🟩 🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose	6m	🟥 🟩 🟩 🟩
rust-doc-tests	5m	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
permission-check	4m	3s

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

consensus/src/quorum_store/proof_coordinator.rs

danielxiangzl · 2024-09-16T21:56:59Z

consensus/src/quorum_store/proof_coordinator.rs

+        let all_voters = self.all_voters();
+        epoch_state
+            .verifier
+            .check_voting_power(all_voters.iter(), true)


We still don't use f+1 for quorum store cert? cc @zekun000

danielxiangzl · 2024-09-16T21:57:57Z

consensus/src/quorum_store/proof_coordinator.rs

+                self.unverified_signatures = PartialSignatures::empty();
+                let aggregated_sig = epoch_state
+                    .verifier
+                    .aggregate_signatures(&self.verified_signatures)


Check voting power before aggregating

zekun000

revert the config before landing

config/src/config/consensus_config.rs

…tch_info

github-actions · 2024-10-23T20:25:47Z

✅ Forge suite `realistic_env_max_load` success on `8b3ae380311afb49a971f989e152b0cdc5699dbf`

two traffics test: inner traffic : committed: 14100.12 txn/s, latency: 2816.21 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5361320
two traffics test : committed: 100.07 txn/s, latency: 1715.15 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 10600 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.921, avg: 1.551", "ConsensusProposalToOrdered: max: 0.330, avg: 0.297", "ConsensusOrderedToCommit: max: 0.402, avg: 0.374", "ConsensusProposalToCommit: max: 0.697, avg: 0.672"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.87s no progress at version 2736115 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.03s no progress at version 2736111 (avg 8.03s) [limit 15].
Test Ok

github-actions · 2024-10-23T20:28:36Z

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `8b3ae380311afb49a971f989e152b0cdc5699dbf`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 8b3ae380311afb49a971f989e152b0cdc5699dbf (PR)
Upgrade the nodes to version: 8b3ae380311afb49a971f989e152b0cdc5699dbf
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1202.31 txn/s, submitted: 1204.15 txn/s, failed submission: 1.85 txn/s, expired: 1.85 txn/s, latency: 2541.99 ms, (p50: 2100 ms, p70: 2400, p90: 4500 ms, p99: 6200 ms), latency samples: 104260
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1243.57 txn/s, submitted: 1246.89 txn/s, failed submission: 3.32 txn/s, expired: 3.32 txn/s, latency: 2421.92 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5700 ms), latency samples: 112360
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 8b3ae380311afb49a971f989e152b0cdc5699dbf passed
Upgrade the remaining nodes to version: 8b3ae380311afb49a971f989e152b0cdc5699dbf
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1246.56 txn/s, submitted: 1247.71 txn/s, failed submission: 1.15 txn/s, expired: 1.15 txn/s, latency: 2522.64 ms, (p50: 2200 ms, p70: 2700, p90: 4200 ms, p99: 5900 ms), latency samples: 108440
Test Ok

github-actions · 2024-10-23T20:31:33Z

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `8b3ae380311afb49a971f989e152b0cdc5699dbf`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 8b3ae380311afb49a971f989e152b0cdc5699dbf (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 13883.67 txn/s, latency: 2427.67 ms, (p50: 2100 ms, p70: 2200, p90: 2700 ms, p99: 7800 ms), latency samples: 450460
2. Upgrading first Validator to new version: 8b3ae380311afb49a971f989e152b0cdc5699dbf
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5888.34 txn/s, latency: 4874.74 ms, (p50: 5600 ms, p70: 5800, p90: 6000 ms, p99: 6100 ms), latency samples: 111620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5281.85 txn/s, latency: 5877.19 ms, (p50: 6200 ms, p70: 6300, p90: 6800 ms, p99: 7900 ms), latency samples: 198360
3. Upgrading rest of first batch to new version: 8b3ae380311afb49a971f989e152b0cdc5699dbf
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5603.02 txn/s, latency: 5085.42 ms, (p50: 5800 ms, p70: 6100, p90: 6400 ms, p99: 6800 ms), latency samples: 106780
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5473.33 txn/s, latency: 5951.63 ms, (p50: 6500 ms, p70: 6600, p90: 7100 ms, p99: 7900 ms), latency samples: 189660
4. upgrading second batch to new version: 8b3ae380311afb49a971f989e152b0cdc5699dbf
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8167.18 txn/s, latency: 3259.74 ms, (p50: 3000 ms, p70: 4000, p90: 4600 ms, p99: 5300 ms), latency samples: 151380
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7629.21 txn/s, latency: 4181.71 ms, (p50: 4300 ms, p70: 5000, p90: 5800 ms, p99: 7200 ms), latency samples: 259700
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 8b3ae380311afb49a971f989e152b0cdc5699dbf passed
Test Ok

vusirikala requested review from bchocho, sasha8, gelash, zekun000, ibalajiarun, JoshLind and gregnazario as code owners September 15, 2024 01:42

vusirikala changed the base branch from main to satya/osv_commit_votes September 15, 2024 01:42

vusirikala requested review from sitalkedia, danielxiangzl and igor-aptos and removed request for gregnazario, bchocho, JoshLind, sasha8 and gelash September 15, 2024 01:42

vusirikala added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 15, 2024

This comment has been minimized.

Sign in to view

danielxiangzl approved these changes Sep 16, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

vusirikala changed the base branch from main to satya/refactor_sig_aggregator October 22, 2024 21:50

This comment has been minimized.

Sign in to view

vusirikala added 2 commits October 22, 2024 15:40

Rebased

d794c45

Minor

8f8aa32

zekun000 approved these changes Oct 22, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into satya/refactor_sig_aggregator

ff11a5b

vusirikala commented Oct 23, 2024

View reviewed changes

config/src/config/consensus_config.rs Outdated Show resolved Hide resolved

vusirikala added 2 commits October 23, 2024 10:45

Update config/src/config/consensus_config.rs

d7707bb

Merge branch 'satya/refactor_sig_aggregator' into satya/osv_signed_ba…

8b3ae38

…tch_info

This comment has been minimized.

Sign in to view

Base automatically changed from satya/refactor_sig_aggregator to main October 23, 2024 18:59

vusirikala enabled auto-merge (squash) October 23, 2024 19:58

This comment has been minimized.

Sign in to view

vusirikala merged commit 38e33fe into main Oct 23, 2024
91 of 93 checks passed

vusirikala deleted the satya/osv_signed_batch_info branch October 23, 2024 20:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimistic signature verification for signed batch info #14644

Optimistic signature verification for signed batch info #14644

vusirikala commented Sep 15, 2024 •

edited

Loading

trunk-io bot commented Sep 15, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

danielxiangzl Sep 16, 2024

danielxiangzl Sep 16, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zekun000 left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

Optimistic signature verification for signed batch info #14644

Optimistic signature verification for signed batch info #14644

Conversation

vusirikala commented Sep 15, 2024 • edited Loading

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io bot commented Sep 15, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

danielxiangzl Sep 16, 2024

Choose a reason for hiding this comment

danielxiangzl Sep 16, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zekun000 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 23, 2024

✅ Forge suite realistic_env_max_load success on 8b3ae380311afb49a971f989e152b0cdc5699dbf

github-actions bot commented Oct 23, 2024

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 8b3ae380311afb49a971f989e152b0cdc5699dbf

github-actions bot commented Oct 23, 2024

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 8b3ae380311afb49a971f989e152b0cdc5699dbf

vusirikala commented Sep 15, 2024 •

edited

Loading

trunk-io bot commented Sep 15, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `8b3ae380311afb49a971f989e152b0cdc5699dbf`

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `8b3ae380311afb49a971f989e152b0cdc5699dbf`

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `8b3ae380311afb49a971f989e152b0cdc5699dbf`