Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync helm chart changes for log level annotations #14505

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Sep 3, 2024

Description

Sync helm chart changes. Added support for pod annotations to the helm charts

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Created a values file for testing and ran
helm template . --values test

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon requested review from geekflyer, ibalajiarun and a team September 3, 2024 15:00
@aluon aluon requested a review from a team as a code owner September 3, 2024 15:00
@sionescu
Copy link
Contributor

sionescu commented Sep 3, 2024

Where does this change come from ? It's not in internal-ops.

@aluon aluon enabled auto-merge (squash) September 3, 2024 17:15

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Forge suite realistic_env_max_load success on 514fc20c2de4d5ae49a5a172d09d9ef21ca4857d

two traffics test: inner traffic : committed: 12384.06 txn/s, latency: 3212.27 ms, (p50: 2700 ms, p70: 3000, p90: 3800 ms, p99: 11100 ms), latency samples: 4708680
two traffics test : committed: 100.08 txn/s, latency: 2710.58 ms, (p50: 2400 ms, p70: 2500, p90: 3400 ms, p99: 10800 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.240, avg: 0.224", "QsPosToProposal: max: 0.256, avg: 0.200", "ConsensusProposalToOrdered: max: 0.326, avg: 0.298", "ConsensusOrderedToCommit: max: 0.483, avg: 0.441", "ConsensusProposalToCommit: max: 0.782, avg: 0.739"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.01s no progress at version 2653180 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.74s no progress at version 2653178 (avg 7.74s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 514fc20c2de4d5ae49a5a172d09d9ef21ca4857d

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 514fc20c2de4d5ae49a5a172d09d9ef21ca4857d (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 10903.94 txn/s, latency: 3125.16 ms, (p50: 2400 ms, p70: 2700, p90: 6900 ms, p99: 18100 ms), latency samples: 351740
2. Upgrading first Validator to new version: 514fc20c2de4d5ae49a5a172d09d9ef21ca4857d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7536.95 txn/s, latency: 3772.62 ms, (p50: 4100 ms, p70: 4300, p90: 4500 ms, p99: 4700 ms), latency samples: 141140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7592.05 txn/s, latency: 4190.93 ms, (p50: 4300 ms, p70: 4500, p90: 6200 ms, p99: 6400 ms), latency samples: 254320
3. Upgrading rest of first batch to new version: 514fc20c2de4d5ae49a5a172d09d9ef21ca4857d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7177.91 txn/s, latency: 3811.98 ms, (p50: 4300 ms, p70: 4600, p90: 5000 ms, p99: 5200 ms), latency samples: 130660
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6912.73 txn/s, latency: 4610.44 ms, (p50: 4700 ms, p70: 4900, p90: 6600 ms, p99: 7000 ms), latency samples: 229180
4. upgrading second batch to new version: 514fc20c2de4d5ae49a5a172d09d9ef21ca4857d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10179.00 txn/s, latency: 2694.49 ms, (p50: 2600 ms, p70: 2900, p90: 3300 ms, p99: 3800 ms), latency samples: 185080
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7271.27 txn/s, latency: 3934.64 ms, (p50: 3000 ms, p70: 4100, p90: 6100 ms, p99: 14900 ms), latency samples: 310220
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 514fc20c2de4d5ae49a5a172d09d9ef21ca4857d passed
Test Ok

@aluon aluon merged commit 8a4ab16 into main Sep 3, 2024
92 of 93 checks passed
@aluon aluon deleted the aluon/sync-helm branch September 3, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants