[consensus] Downgrade error!() from channel closing in pipeline execution

[igor-aptos]

Description

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 1h 22m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
forge-framework-upgrade-test / forge	16m	🟩
forge-e2e-test / forge	15m	🟩
forge-compat-test / forge	14m	🟩
execution-performance / test-target-determinator	5m	🟩
rust-doc-tests	5m	🟩
general-lints	5m	🟩 🟩
test-target-determinator	4m	🟩
check-dynamic-deps	4m	🟩 🟩 🟩
check	4m	🟩
rust-cargo-deny	3m	🟩 🟩
rust-move-tests	2m	🟩
rust-move-tests	1m	🟩
semgrep/ci	1m	🟩 🟩 🟩
Backport PR	34s	🟥 🟩
file_change_determinator	34s	⬜ 🟩 🟩
file_change_determinator	24s	🟩 🟩
permission-check	15s	🟩 🟩 🟩
file_change_determinator	10s	🟩
execution-performance / single-node-performance	9s	🟩
permission-check	8s	🟩 🟩 🟩
permission-check	8s	🟩 🟩 🟩
permission-check	6s	🟩 🟩
permission-check	6s	🟩 🟩 🟩
permission-check	3s	🟩
determine-docker-build-metadata	2s	🟩
rust-move-tests	1s	⬜

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	9s	20m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> cae63ffe298252afd6449787459cad989b97d700

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> cae63ffe298252afd6449787459cad989b97d700 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 8038.47 txn/s, latency: 3919.45 ms, (p50: 3000 ms, p90: 6600 ms, p99: 25200 ms), latency samples: 294220
2. Upgrading first Validator to new version: cae63ffe298252afd6449787459cad989b97d700
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5021.98 txn/s, latency: 5567.88 ms, (p50: 4400 ms, p90: 13500 ms, p99: 14800 ms), latency samples: 204740
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7598.83 txn/s, latency: 4263.92 ms, (p50: 4400 ms, p90: 4800 ms, p99: 5200 ms), latency samples: 254660
3. Upgrading rest of first batch to new version: cae63ffe298252afd6449787459cad989b97d700
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7221.57 txn/s, latency: 3683.18 ms, (p50: 4100 ms, p90: 4500 ms, p99: 4700 ms), latency samples: 135140
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6338.33 txn/s, latency: 4848.92 ms, (p50: 4600 ms, p90: 7700 ms, p99: 7900 ms), latency samples: 223000
4. upgrading second batch to new version: cae63ffe298252afd6449787459cad989b97d700
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10887.47 txn/s, latency: 2533.11 ms, (p50: 2600 ms, p90: 2900 ms, p99: 3500 ms), latency samples: 192700
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7253.60 txn/s, latency: 3072.57 ms, (p50: 2600 ms, p90: 5000 ms, p99: 6300 ms), latency samples: 358680
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> cae63ffe298252afd6449787459cad989b97d700 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on cae63ffe298252afd6449787459cad989b97d700

two traffics test: inner traffic : committed: 12605.36 txn/s, latency: 3154.70 ms, (p50: 3000 ms, p90: 3600 ms, p99: 6300 ms), latency samples: 4792840
two traffics test : committed: 100.09 txn/s, latency: 2789.95 ms, (p50: 2600 ms, p90: 3100 ms, p99: 8000 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.235, avg: 0.217", "QsPosToProposal: max: 0.560, avg: 0.389", "ConsensusProposalToOrdered: max: 0.331, avg: 0.315", "ConsensusOrderedToCommit: max: 0.625, avg: 0.586", "ConsensusProposalToCommit: max: 0.951, avg: 0.901"]
Max round gap was 1 [limit 4] at version 2649797. Max no progress secs was 7.79556 [limit 15] at version 2649797.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> cae63ffe298252afd6449787459cad989b97d700

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> cae63ffe298252afd6449787459cad989b97d700 (PR)
Upgrade the nodes to version: cae63ffe298252afd6449787459cad989b97d700
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1143.89 txn/s, submitted: 1147.88 txn/s, failed submission: 3.99 txn/s, expired: 3.99 txn/s, latency: 2697.15 ms, (p50: 2000 ms, p90: 4500 ms, p99: 12400 ms), latency samples: 103320
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1131.70 txn/s, submitted: 1133.76 txn/s, failed submission: 2.06 txn/s, expired: 2.06 txn/s, latency: 2745.37 ms, (p50: 1800 ms, p90: 5200 ms, p99: 11100 ms), latency samples: 98820
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> cae63ffe298252afd6449787459cad989b97d700 passed
Upgrade the remaining nodes to version: cae63ffe298252afd6449787459cad989b97d700
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1163.65 txn/s, submitted: 1165.67 txn/s, failed submission: 2.02 txn/s, expired: 2.02 txn/s, latency: 2691.37 ms, (p50: 2300 ms, p90: 4500 ms, p99: 7300 ms), latency samples: 103680
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	aptos-release-v1.18

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details