Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bump to 3.5.1 #14055

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[cli] Bump to 3.5.1 #14055

merged 1 commit into from
Jul 19, 2024

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Jul 19, 2024

Release needed to fix a breaking bug effecting both v1/v2 compilers.

Release needed to fix a breaking bug effecting both v1/v2 compilers.
@wrwg wrwg requested review from vineethk, banool and rahxephon89 July 19, 2024 18:56
@wrwg wrwg requested a review from gregnazario as a code owner July 19, 2024 18:56
Copy link

trunk-io bot commented Jul 19, 2024

@wrwg wrwg enabled auto-merge (squash) July 19, 2024 19:07

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> a82258ae06a31b39a73eb413c33732d7c66065e3

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> a82258ae06a31b39a73eb413c33732d7c66065e3 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 10724.74729340099 txn/s, latency: 3123.2254029184364 ms, (p50: 2700 ms, p90: 5100 ms, p99: 6900 ms), latency samples: 367320
2. Upgrading first Validator to new version: a82258ae06a31b39a73eb413c33732d7c66065e3
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7309.5548716605645 txn/s, latency: 3638.8814312509016 ms, (p50: 4100 ms, p90: 4300 ms, p99: 4400 ms), latency samples: 138620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6397.609632133058 txn/s, latency: 4607.572608233079 ms, (p50: 4600 ms, p90: 5400 ms, p99: 5600 ms), latency samples: 244380
3. Upgrading rest of first batch to new version: a82258ae06a31b39a73eb413c33732d7c66065e3
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5928.610623284931 txn/s, latency: 4631.577085533263 ms, (p50: 4500 ms, p90: 6200 ms, p99: 6600 ms), latency samples: 113640
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6548.725436128274 txn/s, latency: 4629.481307431888 ms, (p50: 4600 ms, p90: 5400 ms, p99: 7100 ms), latency samples: 248120
4. upgrading second batch to new version: a82258ae06a31b39a73eb413c33732d7c66065e3
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 3633.9107975560773 txn/s, latency: 12900.855547433399 ms, (p50: 9900 ms, p90: 30300 ms, p99: 44000 ms), latency samples: 123120
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10594.755128337962 txn/s, latency: 2961.362873510277 ms, (p50: 2700 ms, p90: 5600 ms, p99: 7500 ms), latency samples: 347380
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> a82258ae06a31b39a73eb413c33732d7c66065e3 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a82258ae06a31b39a73eb413c33732d7c66065e3

two traffics test: inner traffic : committed: 9381.934370990968 txn/s, submitted: 9602.961765990487 txn/s, failed submission: 0.03156031342211111 txn/s, expired: 221.02739499951812 txn/s, latency: 2878.535730424642 ms, (p50: 2700 ms, p90: 3600 ms, p99: 4200 ms), latency samples: 3567240
two traffics test : committed: 100.02865893552324 txn/s, latency: 1906.5965 ms, (p50: 2000 ms, p90: 2200 ms, p99: 2300 ms), latency samples: 2000
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.247, avg: 0.213", "QsPosToProposal: max: 1.295, avg: 0.719", "ConsensusProposalToOrdered: max: 0.330, avg: 0.293", "ConsensusOrderedToCommit: max: 0.399, avg: 0.378", "ConsensusProposalToCommit: max: 0.689, avg: 0.671"]
Max round gap was 1 [limit 4] at version 1971673. Max no progress secs was 5.847572 [limit 15] at version 1971673.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> a82258ae06a31b39a73eb413c33732d7c66065e3

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> a82258ae06a31b39a73eb413c33732d7c66065e3 (PR)
Upgrade the nodes to version: a82258ae06a31b39a73eb413c33732d7c66065e3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1267.9847689916762 txn/s, submitted: 1270.86491611034 txn/s, failed submission: 2.8801471186636594 txn/s, expired: 2.8801471186636594 txn/s, latency: 2564.5322733295475 ms, (p50: 1800 ms, p90: 4500 ms, p99: 10200 ms), latency samples: 105660
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1045.0395172334559 txn/s, submitted: 1047.9864833341142 txn/s, failed submission: 2.946966100658335 txn/s, expired: 2.946966100658335 txn/s, latency: 3005.945835140998 ms, (p50: 2100 ms, p90: 5400 ms, p99: 12900 ms), latency samples: 92200
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> a82258ae06a31b39a73eb413c33732d7c66065e3 passed
Upgrade the remaining nodes to version: a82258ae06a31b39a73eb413c33732d7c66065e3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1127.4747210247042 txn/s, submitted: 1129.4682912583432 txn/s, failed submission: 1.9935702336389662 txn/s, expired: 1.9935702336389662 txn/s, latency: 2846.5004322200393 ms, (p50: 2100 ms, p90: 5100 ms, p99: 10800 ms), latency samples: 101800
Test Ok

@wrwg wrwg merged commit 8aa7437 into main Jul 19, 2024
87 of 89 checks passed
@wrwg wrwg deleted the wrwg/cli branch July 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants