Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove buildkite integration #14054

Merged
merged 1 commit into from
Jul 19, 2024
Merged

remove buildkite integration #14054

merged 1 commit into from
Jul 19, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Jul 19, 2024

Description

Remove buildkite test collector since this isn't being used anymore

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Will run the unit test workflow for this PR

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon added the CICD:run-all-unit-tests Runs all unit tests label Jul 19, 2024
@aluon aluon requested review from brianolson, ibalajiarun and a team July 19, 2024 18:26
@aluon aluon requested a review from a team as a code owner July 19, 2024 18:26
Copy link

trunk-io bot commented Jul 19, 2024

⏱️ 2h 31m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 32m 🟩
test-target-determinator 17m 🟩🟩🟩🟩
forge-e2e-test / forge 16m 🟩
forge-compat-test / forge 14m 🟩
rust-unit-tests 8m 🟥
rust-unit-tests 8m 🟥
general-lints 8m 🟩🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
rust-move-tests 6m 🟩
rust-doc-tests 6m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-move-tests 3m 🟩
rust-move-tests 3m 🟩
rust-unit-tests 3m
rust-move-tests 3m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 47s 🟩🟩🟩🟩
file_change_determinator 46s 🟩🟩🟩🟩
file_change_determinator 41s 🟩🟩🟩🟩
permission-check 20s 🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
execution-performance / single-node-performance 10s 🟩
Backport PR 9s 🟥🟥
determine-docker-build-metadata 9s 🟩🟩🟩🟩
forge-framework-upgrade-test / forge 8s 🟩
permission-check 6s 🟩🟩
rust-unit-tests 1s

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / test-target-determinator 4m 5m -21%
forge-framework-upgrade-test / forge 8s 10m -99%
execution-performance / single-node-performance 10s 15m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@aluon aluon force-pushed the aluon/buildkite-cleanup branch from 206291a to 8b15e86 Compare July 19, 2024 18:45
@aluon aluon force-pushed the aluon/buildkite-cleanup branch from 8b15e86 to fca9c32 Compare July 19, 2024 19:15
@aluon aluon enabled auto-merge (squash) July 19, 2024 19:58

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fca9c323137aa79bb5667b32ec7e0dca1fd0c4e3

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fca9c323137aa79bb5667b32ec7e0dca1fd0c4e3 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 9905.569281064942 txn/s, latency: 3513.9534292157077 ms, (p50: 2700 ms, p90: 6800 ms, p99: 19000 ms), latency samples: 363640
2. Upgrading first Validator to new version: fca9c323137aa79bb5667b32ec7e0dca1fd0c4e3
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7700.020226453816 txn/s, latency: 3398.884847637685 ms, (p50: 3700 ms, p90: 4100 ms, p99: 4200 ms), latency samples: 143080
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6793.017157684766 txn/s, latency: 4709.2708276251105 ms, (p50: 4300 ms, p90: 8500 ms, p99: 9300 ms), latency samples: 248180
3. Upgrading rest of first batch to new version: fca9c323137aa79bb5667b32ec7e0dca1fd0c4e3
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7234.29414176717 txn/s, latency: 3724.515040299367 ms, (p50: 4200 ms, p90: 4500 ms, p99: 4600 ms), latency samples: 138960
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7047.565579322026 txn/s, latency: 4639.095158217362 ms, (p50: 4700 ms, p90: 5400 ms, p99: 5900 ms), latency samples: 241440
4. upgrading second batch to new version: fca9c323137aa79bb5667b32ec7e0dca1fd0c4e3
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11540.97178289049 txn/s, latency: 2475.6466736862258 ms, (p50: 2600 ms, p90: 3200 ms, p99: 3700 ms), latency samples: 208940
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10856.70960006618 txn/s, latency: 3208.7325485382726 ms, (p50: 3100 ms, p90: 4500 ms, p99: 5700 ms), latency samples: 358480
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fca9c323137aa79bb5667b32ec7e0dca1fd0c4e3 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on fca9c323137aa79bb5667b32ec7e0dca1fd0c4e3

two traffics test: inner traffic : committed: 9438.999881362655 txn/s, submitted: 9636.831421512923 txn/s, failed submission: 0.2104031269877881 txn/s, expired: 197.83154015026776 txn/s, latency: 2992.087867102081 ms, (p50: 3000 ms, p90: 3600 ms, p99: 4200 ms), latency samples: 3588920
two traffics test : committed: 99.97948649156447 txn/s, latency: 1888.139 ms, (p50: 2000 ms, p90: 2100 ms, p99: 2300 ms), latency samples: 2000
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.233, avg: 0.213", "QsPosToProposal: max: 1.378, avg: 0.819", "ConsensusProposalToOrdered: max: 0.320, avg: 0.291", "ConsensusOrderedToCommit: max: 0.395, avg: 0.376", "ConsensusProposalToCommit: max: 0.685, avg: 0.667"]
Max round gap was 1 [limit 4] at version 1964917. Max no progress secs was 5.901625 [limit 15] at version 1964917.
Test Ok

@aluon aluon merged commit 99e2d5f into main Jul 19, 2024
89 of 90 checks passed
@aluon aluon deleted the aluon/buildkite-cleanup branch July 19, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-all-unit-tests Runs all unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants