[Storage] Implement shard id extraction in a different way.

[grao1991]

Description

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Existing UT.

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 4h 6m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
test-fuzzers	1h 48m	🟩 🟩 🟩
execution-performance / single-node-performance	30m	🟩
rust-move-tests	15m	🟩
forge-framework-upgrade-test / forge	15m	🟩
rust-move-tests	15m	🟩
forge-e2e-test / forge	14m	🟩
forge-compat-test / forge	13m	🟩
rust-images / rust-all	12m	🟩
test-target-determinator	7m	🟩
execution-performance / test-target-determinator	7m	🟩
check	4m	🟩
general-lints	3m	🟩 🟩
check-dynamic-deps	2m	🟩 🟩 🟩
semgrep/ci	58s	🟩 🟩 🟩
file_change_determinator	26s	🟩 ⬜ 🟩
file_change_determinator	19s	🟩 🟩
file_change_determinator	10s	🟩
permission-check	8s	🟩 🟩 🟩
permission-check	8s	🟩 🟩 🟩
permission-check	8s	🟩 🟩 🟩
permission-check	7s	🟩 🟩 🟩
permission-check	3s	🟩
determine-docker-build-metadata	3s	🟩
rust-move-tests	1s	⬜

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	30m	21m
test-target-determinator	7m	5m
execution-performance / test-target-determinator	7m	5m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> d8e81c920b4c1bd488a712705202975a6fe63268

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> d8e81c920b4c1bd488a712705202975a6fe63268 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 7491.633633510741 txn/s, latency: 3747.120962821735 ms, (p50: 3300 ms, p90: 4700 ms, p99: 20200 ms), latency samples: 314700
2. Upgrading first Validator to new version: d8e81c920b4c1bd488a712705202975a6fe63268
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3007.790304636159 txn/s, latency: 8562.6384699156 ms, (p50: 9200 ms, p90: 12500 ms, p99: 12900 ms), latency samples: 73460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3208.778381270928 txn/s, latency: 9716.812305680662 ms, (p50: 9700 ms, p90: 15000 ms, p99: 15300 ms), latency samples: 137660
3. Upgrading rest of first batch to new version: d8e81c920b4c1bd488a712705202975a6fe63268
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3533.7597810609213 txn/s, latency: 7424.993282390511 ms, (p50: 8900 ms, p90: 9700 ms, p99: 10000 ms), latency samples: 87680
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3217.4943501272373 txn/s, latency: 9676.896496861773 ms, (p50: 9600 ms, p90: 14800 ms, p99: 15300 ms), latency samples: 137020
4. upgrading second batch to new version: d8e81c920b4c1bd488a712705202975a6fe63268
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 3534.537237813431 txn/s, latency: 6580.975274091172 ms, (p50: 4800 ms, p90: 15300 ms, p99: 18400 ms), latency samples: 103980
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6232.4040475668135 txn/s, latency: 5257.9697483780465 ms, (p50: 4800 ms, p90: 9200 ms, p99: 10300 ms), latency samples: 228120
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> d8e81c920b4c1bd488a712705202975a6fe63268 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on d8e81c920b4c1bd488a712705202975a6fe63268

two traffics test: inner traffic : committed: 8519.404388690018 txn/s, latency: 4601.947473956208 ms, (p50: 4500 ms, p90: 5700 ms, p99: 9600 ms), latency samples: 3676500
two traffics test : committed: 100.00912773384775 txn/s, latency: 1985.757738095238 ms, (p50: 2000 ms, p90: 2200 ms, p99: 2400 ms), latency samples: 1680
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.219, avg: 0.207", "QsPosToProposal: max: 0.192, avg: 0.182", "ConsensusProposalToOrdered: max: 0.310, avg: 0.284", "ConsensusOrderedToCommit: max: 0.355, avg: 0.343", "ConsensusProposalToCommit: max: 0.637, avg: 0.627"]
Max round gap was 1 [limit 4] at version 1808254. Max no progress secs was 4.822821 [limit 15] at version 1808254.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> d8e81c920b4c1bd488a712705202975a6fe63268

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> d8e81c920b4c1bd488a712705202975a6fe63268 (PR)
Upgrade the nodes to version: d8e81c920b4c1bd488a712705202975a6fe63268
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1041.5045833778609 txn/s, submitted: 1044.262927010731 txn/s, failed submission: 2.7583436328700794 txn/s, expired: 2.7583436328700794 txn/s, latency: 2961.534903994703 ms, (p50: 2400 ms, p90: 5100 ms, p99: 8100 ms), latency samples: 90620
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1079.2424492561488 txn/s, submitted: 1081.2873296863183 txn/s, failed submission: 2.044880430169545 txn/s, expired: 2.044880430169545 txn/s, latency: 2820.652589473684 ms, (p50: 2100 ms, p90: 5100 ms, p99: 10200 ms), latency samples: 95000
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> d8e81c920b4c1bd488a712705202975a6fe63268 passed
Upgrade the remaining nodes to version: d8e81c920b4c1bd488a712705202975a6fe63268
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1135.7519817764696 txn/s, submitted: 1138.4970016720017 txn/s, failed submission: 2.745019895532253 txn/s, expired: 2.745019895532253 txn/s, latency: 2822.9223867069486 ms, (p50: 2100 ms, p90: 5100 ms, p99: 9000 ms), latency samples: 99300
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking