Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: remove usage of normalized types and improve module complexity check (1.15) #13937

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

vgao1996
Copy link
Contributor

@vgao1996 vgao1996 commented Jul 8, 2024

No description provided.

…lexity check (aptos-labs#260)

* improve metadata check efficiency

* mark normalized types as deprecated

* improve module complexity check

* Update timed_features.rs

* Add activation time

* Update feature flag name

* [release-1.15] Deactivate broken package overrides (aptos-labs#13797)

Renaming the tomls for deactivating the tests

* Update timed_features.rs

---------

Co-authored-by: runtianz <[email protected]>
Co-authored-by: Wolfgang Grieskamp <[email protected]>
Copy link

trunk-io bot commented Jul 8, 2024

⏱️ 4h 54m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 53m 🟩🟩
execution-performance / single-node-performance 32m 🟩
rust-move-tests 30m 🟩🟩
rust-smoke-tests 22m 🟥
forge-framework-upgrade-test / forge 19m 🟩
rust-lints 18m 🟩🟩
rust-images / rust-all 18m 🟩
forge-e2e-test / forge 17m 🟩
rust-move-unit-coverage 17m 🟩
forge-compat-test / forge 15m 🟩
test-target-determinator 13m 🟩
execution-performance / test-target-determinator 13m 🟩
rust-build-cached-packages 10m 🟩
run-tests-main-branch 4m 🟥🟥
check 4m 🟩
check-dynamic-deps 4m 🟩🟩
general-lints 3m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 1m 🟩
semgrep/ci 44s 🟩🟩
file_change_determinator 23s 🟩🟩
file_change_determinator 20s 🟩🟩
file_change_determinator 10s 🟩
permission-check 7s 🟩🟩
permission-check 7s 🟩🟩
permission-check 6s 🟩🟩
permission-check 5s 🟩🟩
permission-check 3s 🟩
determine-docker-build-metadata 1s 🟩
🚨 6 jobs on the last run were significantly faster/slower than expected
Job Duration vs 7d avg Delta
test-target-determinator 13m 5m +177%
execution-performance / test-target-determinator 13m 5m +171%
execution-performance / single-node-performance 32m 21m +53%
rust-images / rust-all 18m 12m +44%
forge-framework-upgrade-test / forge 19m 14m +30%
forge-e2e-test / forge 17m 14m +22%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sherry-x sherry-x enabled auto-merge (squash) July 8, 2024 20:06

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> 19b519983d3089b809f893e1dc75619101d36a02

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> 19b519983d3089b809f893e1dc75619101d36a02 (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 9227.726287654681 txn/s, latency: 3589.7636529759834 ms, (p50: 2700 ms, p90: 6300 ms, p99: 28600 ms), latency samples: 344760
2. Upgrading first Validator to new version: 19b519983d3089b809f893e1dc75619101d36a02
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2436.3707002916103 txn/s, latency: 12577.845626996805 ms, (p50: 12800 ms, p90: 20100 ms, p99: 21700 ms), latency samples: 100160
3. Upgrading rest of first batch to new version: 19b519983d3089b809f893e1dc75619101d36a02
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2590.5234436986366 txn/s, latency: 11902.317880351682 ms, (p50: 12500 ms, p90: 16800 ms, p99: 18800 ms), latency samples: 104640
4. upgrading second batch to new version: 19b519983d3089b809f893e1dc75619101d36a02
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6405.907884868062 txn/s, latency: 5114.95665626625 ms, (p50: 4800 ms, p90: 8100 ms, p99: 9200 ms), latency samples: 230760
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> 19b519983d3089b809f893e1dc75619101d36a02 passed
Test Ok

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ Forge suite realistic_env_max_load success on 19b519983d3089b809f893e1dc75619101d36a02

two traffics test: inner traffic : committed: 8544.862946332463 txn/s, latency: 4588.341939425135 ms, (p50: 4500 ms, p90: 5400 ms, p99: 9600 ms), latency samples: 3691300
two traffics test : committed: 99.9615741275237 txn/s, latency: 1992.7411764705882 ms, (p50: 1900 ms, p90: 2200 ms, p99: 3500 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.224, avg: 0.211", "QsPosToProposal: max: 0.305, avg: 0.247", "ConsensusProposalToOrdered: max: 0.315, avg: 0.288", "ConsensusOrderedToCommit: max: 0.372, avg: 0.361", "ConsensusProposalToCommit: max: 0.663, avg: 0.648"]
Max round gap was 1 [limit 4] at version 7567. Max no progress secs was 4.435195 [limit 15] at version 2580760.
Test Ok

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ Forge suite framework_upgrade success on a68e71c05caebf01504d4499110f3fba213fb53d ==> 19b519983d3089b809f893e1dc75619101d36a02

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> 19b519983d3089b809f893e1dc75619101d36a02 (PR)
Upgrade the nodes to version: 19b519983d3089b809f893e1dc75619101d36a02
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1140.017320027476 txn/s, submitted: 1143.3637505167933 txn/s, failed submission: 3.346430489317444 txn/s, expired: 3.346430489317444 txn/s, latency: 2710.8409784735813 ms, (p50: 2100 ms, p90: 4600 ms, p99: 11400 ms), latency samples: 102200
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1153.7206110784768 txn/s, submitted: 1156.7702995583509 txn/s, failed submission: 3.049688479873973 txn/s, expired: 3.049688479873973 txn/s, latency: 2737.329615697438 ms, (p50: 2100 ms, p90: 5100 ms, p99: 9200 ms), latency samples: 98360
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> 19b519983d3089b809f893e1dc75619101d36a02 passed
Upgrade the remaining nodes to version: 19b519983d3089b809f893e1dc75619101d36a02
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 923.1898434995361 txn/s, submitted: 925.2800846546294 txn/s, failed submission: 2.090241155093289 txn/s, expired: 2.090241155093289 txn/s, latency: 3792.6432704402514 ms, (p50: 2700 ms, p90: 7600 ms, p99: 11500 ms), latency samples: 79500
Test Ok

@sherry-x sherry-x merged commit a390f69 into aptos-labs:aptos-release-v1.15 Jul 8, 2024
83 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants