Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing tests/compiler-v2/doc/ files for move_pr.sh #13918

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brmataptos
Copy link
Contributor

Description

Restores some new files that were missing from PR #13652.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Not at all

Key Areas to Review

Is this all the files?

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jul 3, 2024

⏱️ 56m total CI duration on this PR
Job Cumulative Duration Recent Runs
test-fuzzers 36m 🟩
rust-move-tests 8m 🟩
rust-move-unit-coverage 8m 🟩
general-lints 2m 🟩
check-dynamic-deps 36s 🟩
semgrep/ci 22s 🟩
file_change_determinator 11s 🟩
file_change_determinator 11s 🟩
permission-check 9s 🟩
permission-check 8s 🟩
permission-check 4s 🟩
permission-check 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.9%. Comparing base (1feb429) to head (eb06843).
Report is 823 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13918   +/-   ##
=======================================
  Coverage    58.9%    58.9%           
=======================================
  Files         824      824           
  Lines      198320   198320           
=======================================
  Hits       117008   117008           
  Misses      81312    81312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 26, 2024
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 11, 2024
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant